Commit Graph

12301 Commits

Author SHA1 Message Date
Chris Loer
e5a3a7a451 [core] Fix potential race condition crash in symbol querying..
Second half of fix for issue #11538.

If a global placement took place between the time a tile's non-symbol layout updated and the time new symbol buckets arrived, the tile's new FeatureIndex would be committed, but the global CollisionIndex would be generated against the old symbolBuckets. The mismatch could cause the CollisionIndex to contain indices that didn't exist in the new FeatureIndex, and attempting to access them would generate an out-of-bounds exception.
2018-03-29 09:04:23 -07:00
Chris Loer
f9b6d5f09c [core] Fix potential race condition crash in symbol querying..
First half of fix for issue #11538.

Testing `if (pendingData)` didn't work if there _was_ a data update, but the update was "the data for this tile is now null". In that case, the tile's FeatureIndex would be updated, but the tile's data member would remain unchanged.

In the case of a tile's data being deleted, the matching FeatureIndex would have an empty set of bucketLayerIDs, but the _old_ data would still be in place for querying, and the symbolBuckets might not be updated yet (pending onPlacement). In this case `bucketLayerIDs.at(indexedFeature.bucketName)` could throw an out-of-range exception.
2018-03-29 09:04:23 -07:00
Fabian Guerra Soto
2aaa038ef1 [ios, macos] Add lookup and feature operators. (#11528)
* [ios, macos] Add Expressions 'at' operator.

* [ios, macos] Implement 'has' operator.

* [ios, macos] Implement expressions feature operators.

* [ios, macos] Refactor expressions variable name and 'mgl_has' implementation.

* [ios, macos] Refactor expresssion variable names.

* [ios, macos] Update 'mgl_has' to support non-self operands.
2018-03-28 18:09:17 -04:00
Łukasz Paczos
fbd6e2b618 Release Android v6.0.0-beta.5 (#11537)
* [android] Updated changelog for 6.0.0-beta.5 release
2018-03-28 15:35:33 +02:00
Chris Loer
3c18610d1f [core] Add 'apiBaseURL' argument to mbgl-offline util. 2018-03-27 15:26:38 -07:00
Łukasz Paczos
7f18b0bbb2 [android] bumped gestures library version to 0.2.0 (#11535) 2018-03-27 18:23:07 +02:00
Łukasz Paczos
a7e35d94b5 [android] bumped telemetry library version to 3.0.0-beta.3 (#11534) 2018-03-27 17:49:21 +02:00
Jason Wray
4f196d48dd [build] Save raw Xcode build logs 2018-03-26 18:08:03 -04:00
Jason Wray
e018b01c42 [ios, build] Run static analyzer on CircleCI 2018-03-26 16:26:29 -04:00
Jason Wray
4b8c27edef [ios, build] Run undefined behavior sanitizer on CircleCI 2018-03-26 16:25:07 -04:00
Fabian Guerra Soto
9a663fb479 [ios, macos] Add match expressions support. (#11464)
* [ios, macos] Add match expressions support.

* [ios, macos] Add coalesce operator support.

* [ios, macos] Add coalesce operator test.

* [ios, macos] Match operator implementation is moved to NSPredicate.

* [ios, macos] Match operator function implementation refactor.

* [ios, macos] Address merge conflicts.
2018-03-26 15:22:54 -04:00
Tobrun
9eff2c52fb [android] - update changelog v5.5.1 2018-03-26 15:03:47 -04:00
Tobrun
f5ce99f3e3 [android] - allow multiple expressions in string, number and bool asserting expressions 2018-03-26 13:03:14 -04:00
Fabian Guerra Soto
dd301fbc0f [ios, macos] Change the format for case expressions to a flat structure. (#11450)
* [ios, macos] Change the format for case expressions to a flat structure.

* [ios, macos] Add support for multiple branches case expression.

* [ios, macos] Add multiple branch tests to case expressions.

* [ios, macos] Case operator now has iOS 8 support.
2018-03-26 12:53:34 -04:00
Tobrun
ce3c42a1c2 [android] - don't load default style if style json string was set (#11520) 2018-03-26 09:40:22 -04:00
Tobrun
c44fe25200 [android] - correctly convert Android int colors with to-color expression (#11506) 2018-03-23 09:54:22 -04:00
John Firebaugh
9499a2bda7 [core] Don't resolve tokens after evaluating a text-field or icon-image expression (#11509) 2018-03-22 16:44:12 -07:00
Tobrun
1d29f82c1b [android] - expose public api telemetry (#11503) 2018-03-22 17:10:26 -04:00
Chris Loer
673f9e3648 [core] Double maximum label width by reducing glyph precision.
Fixes issue #11507.
Port of GL JS PR #6375.
2018-03-22 13:24:26 -07:00
Tobrun
61e6e62663 [android] - make default output param from step expression more descriptive, add param to javadoc (#11501) 2018-03-22 12:45:27 -04:00
Tobrun
1eb90c1448 Literal array conversion of primitive arrays (#11500)
* [android] - literal array conversion of primitives types
2018-03-22 12:40:43 -04:00
Chris Loer
4dc191b8da [core] Avoid flashing on pitched overzoomed tiles.
Clamps perspective ratios in shaders.
Fixes issue #11487.
Port of GL JS PR #6365.
2018-03-21 13:26:30 -07:00
Julian Rex
d4f2bc07ca [ios,macos] Selecting offscreen annotation pans map to fit annotation & callout view (#3249, #9790) 2018-03-21 13:51:10 -04:00
Tobrun
4b3d0638b8 [android] - update changelog for v6.0.0-beta.4 (#11485) 2018-03-21 09:09:49 +01:00
Jordan Kiley
68fcbf0a72 [ios, macos] Document to use subclasses of MGLFeature to access attributes (#11462) 2018-03-20 10:33:44 -07:00
Łukasz Paczos
a2250098f5 [android] bumped gestures library version to 0.1.0 (#11483) 2018-03-20 13:03:06 +01:00
Ansis Brammanis
ef1dcc0d5b [core] don't hide icons if text is an empty string 2018-03-19 15:31:38 -07:00
Tobrun
f011035017 Expression filters (#11429)
* [android] - add expression filter integration
2018-03-19 15:11:17 +01:00
Tobrun
c5075e33ec [android] - verify optional before accessing it 2018-03-19 15:10:15 +01:00
Guardiola31337
7d5304ebc1 [android] bump mapbox-android-telemetry version to 3.0.0-beta.2 and adapt events related code 2018-03-19 14:55:47 +01:00
Ivo van Dongen
2464520da1 [android] high-level jni bindings for geojson conversion 2018-03-19 11:19:09 +02:00
Osana Babayan
f2fbe69b32 update to MAS3.0-beta.4 (#11468) 2018-03-16 14:11:07 -04:00
Tobrun
aba24da180 [android] - implement expression literal on arrays 2018-03-16 17:09:35 +01:00
Łukasz Paczos
d59646fc1f Test activity for gestures manager (#11449) 2018-03-16 13:21:11 +01:00
Łukasz Paczos
146e615bae [android] fixed TWO_FINGER_TAP telemetry event (#11460) 2018-03-16 10:41:34 +01:00
John Firebaugh
449c68e329 [core] Update mapbox-gl-js 2018-03-14 15:26:28 -07:00
John Firebaugh
2912a1423d [core] Stringify expression syntax, not function syntax 2018-03-14 15:26:28 -07:00
Jason Wray
be2fae838c [ios] Prepare changelog for ios-v3.7.6 2018-03-14 15:47:21 -04:00
Jason Wray
6718887f0b [ios, build] Move iOS release builds to CircleCI 2018-03-14 15:46:52 -04:00
Jason Wray
4acd671a65 [ios] Add camera limit debug option to iosapp
Adapted from cdff47276d/Examples/ObjectiveC/BlockingGesturesDelegateExample.m
2018-03-14 15:46:43 -04:00
Jason Wray
d37edadacb [ios] Fix pinch drift ignoring delegate camera change response 2018-03-14 15:46:31 -04:00
Jason Wray
2230af1425 [ios] Improved heading indicator arrow visibility 2018-03-14 15:46:00 -04:00
Łukasz Paczos
3294f279e3 [android] build release Test App before publishing (#11418) 2018-03-14 15:41:15 +01:00
Lloyd Sheng
4404a2669b [ios, macos] Fix an issue where a wrong annotation may selected if annotations were set close together (#11438)
* [ios] Fix an issue where wrong annotation may selected when annotations very close #10734

* [macos] Fix an issue where a wrong annotation may selected if annotations were set close together

* update the iOS change log and the macOS change log

* Fix an issue where the comment referenced to the wrong variable name
2018-03-13 11:26:15 -07:00
Tobrun
961aba1552 [android] - revisit proguard configuration for release-boba 2018-03-12 16:36:45 +01:00
Asheem Mamoowala
a57be420b0 [core] TileJSON conversion clamps bounds longitude to [-180,180], per spec 2018-03-09 12:00:12 -08:00
Lucas Wojciechowski
8a3deab733 [core] Add expression filter support (#11251)
* WIP

* WIP

* WIP

* Remove Filter::operator()(const Feature&)

* WIP

* WIP

* WIP

* WIP

* Hook up expression filter evaluator

* Replace `shared_ptr` with &reference

* Fill in implementation of `void operator()(const ExpressionFilter&)`

* Fix failing tests

* Switch back to a shared_ptr per chat with @anandthakker

* Fix benchmark compilation

* Shot in the dark to fix CI

* Shot in the dark to fix CI (part 2)

* Shot in the dark to fix CI (part 3)

* In src/mbgl/style/conversion/filter.cpp, add a port of isExpressionFilter and use it to decide in Converter<Filter>::operator() whether to parse the incoming JSON as an ExpressionFilter or one of the legacy filter types

* Remove bool Filter::operator()(const GeometryTileFeature&) const

*  Ensure the map zoom is passed into filtering operations wherever applicable

* Add expression filter tests

* Addressed PR feedback

* Implement `NSPredicate *operator()(mbgl::style::ExpressionFilter filter)`

* Fix formatting& nit
2018-03-09 11:12:14 +01:00
Tobrun
6179110b6b [android] - add expression conversion, add getters (#11352) 2018-03-08 16:27:02 +01:00
Łukasz Paczos
dfdfbc0990 [android] calculating camera's LatLng for bounds without map padding (#11410) 2018-03-08 15:55:47 +01:00
Tobrun
ea525fd08a [android] - check for null body on http request, cleanup code 2018-03-08 15:51:07 +01:00