Commit Graph

15852 Commits

Author SHA1 Message Date
Thiago Marcos P. Santos
dffe00feea [core] Fix readability-avoid-const-params-in-decls errors in header files
As reported by clang-tidy-8.
2020-04-17 13:36:50 +03:00
Thiago Marcos P. Santos
2eebd7170a [build] Make the code tidy
Now clang-tidy runs for all the mbgl-core.
2020-04-17 13:36:50 +03:00
Alexander Shalamov
a71e672dfa Update changelog 2020-04-16 13:52:54 -04:00
Alexander Shalamov
ffea0af9bf Add generic setter for 'source' property
- Add setter for 'source' property
- Test generic setters via setProperty method
2020-04-16 13:52:54 -04:00
Thiago Marcos P. Santos
7f0c13967d [baselines] Update binary size baselines
New image, new libraries we link against.
2020-04-16 19:31:23 +03:00
Thiago Marcos P. Santos
aa2e8fbb6a [build] Move to Ubuntu Eoan
Disco has reached EOL and apt-get fails.
2020-04-16 19:31:23 +03:00
Gali Nelle
545a09fcb3 Fix LocationIndicator not updating image sizes when image manager content changes 2020-04-16 11:56:02 +03:00
Thiago Marcos P. Santos
4da54d61cc [build] Ignore location indicator on iOS until we port to ::gfx
Remove the ignore after https://github.com/mapbox/mapbox-gl-native/issues/16401 is done.
2020-04-15 20:37:10 +03:00
Juha Alanen
f3df304a20 [build] Compare benchmark results to baseline 2020-04-15 19:11:28 +03:00
Juha Alanen
3a91597c5d [benchmark] Add script for comparing benchmark results to baseline
Benchmark will fail if the average time is more than 5% higher
than the baseline.
2020-04-15 19:11:28 +03:00
Juha Alanen
36175d57b4 [build] Disable benchmark for MacOS debug CI builds 2020-04-15 19:11:28 +03:00
Juha Alanen
4a8dea7527 [metrics] Add baselines for benchmark tests 2020-04-15 19:11:28 +03:00
Juha Alanen
39329516dd [android, ios] Increase benchmark repetition count
More repetitions give more stable results.
2020-04-15 19:11:28 +03:00
Juha Alanen
07d7afd6c9 [benchmark] Increase iteration count for some benchmarks
Some benchmarks were run less than 5 iterations, which is not enough
for stable results.
2020-04-15 19:11:28 +03:00
Juha Alanen
8c499c9955 [benchmark] Add new benchmark for rendering a map 2020-04-15 19:11:28 +03:00
Juha Alanen
5d8ad4c99e [build] Bump benchmark to v1.5.0 2020-04-15 19:11:28 +03:00
Juha Alanen
7ead748f6c [build] Save rebaselined metrics as artifacts 2020-04-15 19:11:28 +03:00
Alexander Shalamov
81e1f89c8c Update baselines for macos bot 2020-04-15 10:42:11 -04:00
Alexander Shalamov
51000f6d6d Use single threaded fixture log 2020-04-15 10:42:11 -04:00
Rinigus
42ceb70365 [build] Drop unused modules from .gitmodules 2020-04-15 12:11:47 +03:00
Mikhail Pozdnyakov
66ac554459 Add change log entry 2020-04-14 22:30:40 +03:00
Mikhail Pozdnyakov
cf2bccdcc2 Update baselines 2020-04-14 22:30:40 +03:00
Mikhail Pozdnyakov
364ea4b3b7 [core] RenderCircleLayer fixes 2020-04-14 22:30:40 +03:00
Mikhail Pozdnyakov
3ba2fc6ea2 [core] CircleLayout fixes 2020-04-14 22:30:40 +03:00
Andrew Hay Kurtz
0c95acf103 Enable 'circle-sort-key' layout property 2020-04-14 22:30:40 +03:00
Łukasz Paczos
08ad742164 [core] add regression test for #16391 2020-04-14 17:32:00 +02:00
Łukasz Paczos
f79334c124 when removing an image use the correct list ptr for presence verification
This fixes an issues where calling `removeImage` would crash if the image was not present and the original list was not empty.
2020-04-10 16:55:17 +02:00
Kevin Li
be9ca95e9a [android] Fix onStyleImageMissing callback in Snapshotter not fired issue. (#16386) 2020-04-10 18:13:57 +08:00
Gali Nelle
209857f8ac Fix LocationIndicator Layer
This changes image size properties to be scales instead of pixel sizes.
The commit also adds fixes for handling image updates with the same ID,
adds tests for expressions in paint properties, as well as tests for using images
with pixel ratio greater than 1.
Finally it moves image-tilt-displacement and perspective-compensation properties
from layout to paint properties, and includes other minor cleanups.
2020-04-10 00:15:43 +03:00
Mikhail Pozdnyakov
e6c156420d [core] PlacedSymbolData contains layer id 2020-04-09 17:18:21 +03:00
Mikhail Pozdnyakov
718dd295ab Add change log entry 2020-04-08 17:00:21 +03:00
Mikhail Pozdnyakov
5a9fa44d55 [core][tile mode] Support variable placement + icon-text-fit 2020-04-08 17:00:21 +03:00
Gali Nelle
fe9ba477a8 Update baselines after addition of Location Indicator layer 2020-04-08 14:00:26 +03:00
Gali Nelle
cd91664935 Add unit tests for Rotation interpolator 2020-04-08 14:00:26 +03:00
Gali Nelle
8e581c88ea Make location indicator bearing a paint property
This change introduces a new property type, Rotation, that uses
a custom interpolator, and that is currently applied to
all style properties named "bearing", with a period attribute.
2020-04-08 14:00:26 +03:00
Gali Nelle
9a55c282fe Add LocationIndicatorLayer
New key is "G" in mbgl-glfw, cycling between no puck, centered
in the viewport and positioned in Tokyo.
2020-04-08 14:00:26 +03:00
Mikhail Pozdnyakov
7f53cec17b Add change log entry 2020-04-08 11:19:37 +03:00
Mikhail Pozdnyakov
39cdbb63c6 Update render tests expectations 2020-04-08 11:19:37 +03:00
Mikhail Pozdnyakov
fd218daa00 [core][tile mode] Fix placement mismatch for the labels with same geomerty 2020-04-08 11:19:37 +03:00
Mikhail Pozdnyakov
88337c23f7 [core][tile mode] Improve placement algorithm for variable labels 2020-04-08 11:19:37 +03:00
Mikhail Pozdnyakov
8165b7dee1 [core][tile mode] Placement algorithm improvements
Now, the intersecting symbols are placed across all layers according to the following rules:
1) First we look, which of the tile border(s) the symbol intersects and prioritize the the symbol accordingly (high priority -> low priority):
vertical & horizontal -> vertical -> horizontal

2) For the symbols that intersect the same tile border(s), assuming the tile border split symbol into several sections, we look at the minimal section length.
The symbol with a larger minimal section length is placed first.

3) Finally, for the symbols that intersect the same tile border(s), and have equal minimal section length, we look at the anchor Y cordinate.
2020-04-08 11:19:37 +03:00
Mikhail Pozdnyakov
e6bac0eb9f [core] Symbol by symbol placement for intersections 2020-04-08 11:19:37 +03:00
Mikhail Pozdnyakov
a32672b9e6 [core] Introduce PlacementContext
Make `placeSymbol()` a method and introduce copiable `PlacementContext`.
2020-04-08 11:19:37 +03:00
Thiago Marcos P. Santos
42dc1e997f [test] Rename deprecated gtest method
The old name was marked as deprecated and failing to build with clang.
2020-04-08 02:07:38 +03:00
Thiago Marcos P. Santos
e3485c2df1 [build] Bump googletest to 1.10.0
Reason: gmock supports better syntax for defining mock methods.
2020-04-08 02:07:38 +03:00
zmiao
bf4c7340f3 [build] Fix undefined behavour sanitizer (#16375)
* [build] Fix integer overflow runtime error for core part

Temporarily remove circle ci UBSAN build precondition

* [build] Enable all of the ubsans

[build] Check runtime error

[build] Update UBSAN_OPTION

* [build] Add UBSAN blacklist

[build] Ignore system libraries

[build] Ignore vendor library

* [build] Fix implicit conversion runtime error in core

* [build] Fix division by zero runtime error

* [build] Add unfixed error to ubsan blacklist

* [build] Make UBSAN halt on error

Revert "Temporary remove build precondition"

* [build] Fix division by zero error

* [build] Make UBSAN officially work without FIXME prefix

* [build] Fix implicit conversion from int64_t to uint64_t

* [build] Rename style test json file name

* Address review findings
2020-04-07 16:30:30 +03:00
Mikhail Pozdnyakov
8986b558eb [render tests][tile mode] Check symbol icons cut-offs 2020-04-06 19:18:06 +03:00
Mikhail Pozdnyakov
b2ab0804f8 [render tests][tile mode] Enable automatic labels cut-off detection 2020-04-06 19:18:06 +03:00
Thiago Marcos P. Santos
c829ea7e92 [build] Add option to disable -Werror
mkdir build && cd build && cmake .. -DMBGL_WITH_WERROR=OFF
2020-04-06 18:18:17 +03:00
Mikko Pulkki
d0c103fa8f Refactor tileCover to support lod tiles 2020-04-06 12:10:21 +03:00