Commit Graph

7032 Commits

Author SHA1 Message Date
Dane Springmeyer
cfa2eaf5c2 fix more 'result is not floating point' coverity warnings 2015-05-03 23:28:52 -07:00
Dane Springmeyer
33f30aae93 fix integer division to work in doubles in transform.cpp 2015-05-03 23:23:13 -07:00
John Firebaugh
aa19f07ccf RunLoop must outlive Object
~Object is likely to join threads that want to dispatch results
back to this RunLoop. This happens, for example, when MapContext
is destructed: it joins the worker threads, which need to complete
work before shutting down.
2015-05-02 12:57:25 -04:00
Minh Nguyễn
98dc0b6f81 Avoid creating MGLMapboxEvents when Metrics is disabled
Mapbox Metrics already has a bottleneck; might as well use it to avoid fetching data in the first place.
2015-05-01 19:24:14 -04:00
John Firebaugh
5013be138e Fix CURL handle leak (fixes #1394) 2015-05-01 18:48:07 -04:00
John Firebaugh
5475f3138b Fix potential crash
The promise could be deallocated before promise.set_value() had returned,
which apparently caused an invalid read on some implementations.

By moving the promise declaration up the stack, we ensure that the map is
deallocated first, and therefore the map thread is joined, before the
promise is deallocated.
2015-05-01 18:25:41 -04:00
John Firebaugh
b713930c7f Merge branch 'uv_leak' 2015-05-01 18:24:58 -04:00
John Firebaugh
4c8f716f20 Eliminate uv::async leak (fixes #1393) 2015-05-01 18:13:35 -04:00
John Firebaugh
24695f6c02 More bandaids to avoid #1309
Even though we only bind the shared_ptr in the after callback, the
worker thread was still copying the callback and therefore gaining
a shared reference. Here we try to eliminate the copies.
2015-05-01 17:14:06 -04:00
John Firebaugh
dac4b7d3c9 Reset previous style before creating new one
This ensures that the worker threads associated with the
style are joined before new worker threads are launched.
I don't know exactly why, but it seems to fix #1384.
2015-05-01 16:29:06 -04:00
John Firebaugh
415bc8bb74 Merge pull request #1397 from mapbox/clang-3.6
Fix compile with clang-3.6
2015-05-01 14:35:17 -04:00
John Firebaugh
36f695b411 Write SQLite tests in terms of Impl 2015-05-01 14:31:39 -04:00
Dane Springmeyer
74604af9c5 fix compile with clang-3.6 2015-05-01 11:00:01 -07:00
John Firebaugh
51c0695028 Replace unsafe use of future with packaged_task 2015-05-01 12:07:34 -04:00
John Firebaugh
09496737eb Merge pull request #1392 from mapbox/valgrind
Fix some bugs found via valgrind
2015-05-01 10:17:44 -04:00
John Firebaugh
2d8d375356 Fix intended identity comparisons 2015-05-01 10:06:04 -04:00
John Firebaugh
bb3eb8d83d Fix uninitialized variable 2015-05-01 10:06:04 -04:00
Justin R. Miller
e3c310e80f [publish ios-v0.2.19] 2015-05-01 09:38:14 -04:00
Justin R. Miller
3b9a7c5036 bump podspec to 0.2.19 2015-05-01 09:37:17 -04:00
Minh Nguyễn
93f62188ea Merge pull request #1292 from mapbox/1266-slippy
Slip and slide
2015-05-01 00:49:01 -04:00
Minh Nguyễn
5e6bf19144 Fixed build errors from merge
Follow-up to cf33edf16d.
2015-05-01 00:37:51 -04:00
Justin R. Miller
cf33edf16d Merge branch 'master' into 1266-slippy 2015-05-01 00:06:47 -04:00
Justin R. Miller
6743e22230 [publish ios-v0.2.18] 2015-04-30 23:05:56 -04:00
Justin R. Miller
e0a4fb2fca bump podspec to 0.2.18 2015-04-30 23:05:12 -04:00
Ansis Brammanis
ed9ef0f7d1 fix pixelForLatLng during animated zoom
fix #1160
2015-04-30 16:03:35 -07:00
Justin R. Miller
c69e985fa5 fixes #1102: implement reference-counted shared file cache vendor 2015-04-30 17:52:42 -04:00
Justin R. Miller
8192d2ed10 Merge pull request #1386 from mapbox/1103-no-clobber-pointers
fixes #1103: allow multiple maps by not using global pointers
2015-04-30 17:27:38 -04:00
Minh Nguyễn
5780b676b0 Fixed iOS 7 test breakage and crash from #1382
These APIs were introduced in iOS 8+, hence the `-respondsToSelector:` check. But I saw that, thinking it was just redundant, and removed it in #1382, leading to a crash on launch on iOS 7.
2015-04-30 16:02:20 -04:00
Jason Wray
812448f830 Merge pull request #1370 from mapbox/compass-1x
Antialias compass.png N text
2015-04-30 14:28:29 -04:00
Minh Nguyễn
34e43f73bc Merge pull request #1382 from mapbox/1ec5-events-nits
Formalize NSURLSession lifetime; streamline MGLMetricsLocationManager methods
2015-04-30 14:19:50 -04:00
John Firebaugh
6197763780 Merge branch '1368-http-request-crash' 2015-04-30 14:18:14 -04:00
Brad Leege
facbdae3e8 Merge pull request #1383 from mapbox/1381-accuracy-throttle
Throttling The Requested Accuracy Level Down
2015-04-30 14:11:59 -04:00
Justin R. Miller
858bb5dbe4 fixes #1103: allow multiple maps by not using global pointers 2015-04-30 14:08:46 -04:00
John Firebaugh
f3f3e1b443 Copy resource
Fixes #1368
2015-04-30 12:55:36 -04:00
Minh Nguyễn
c935acc52d Typo 2015-04-30 12:48:36 -04:00
John Firebaugh
7584599ea6 uv::handle base class 2015-04-30 12:40:26 -04:00
John Firebaugh
64251eec75 Introduce and use uv::timer 2015-04-30 12:40:10 -04:00
Minh Nguyễn
6342712591 Pause collection when tearing down MGLMapboxEvents for whatever reason 2015-04-30 12:28:35 -04:00
Minh Nguyễn
97fb9f6fcf Tied NSURLSession lifetime to metrics collection
Call `-resumeMetricsCollection` on `init` to consolidate the various steps to initialize `MGLMetricsLocationManager`.
2015-04-30 12:22:51 -04:00
John Firebaugh
95214472d4 Use uv::async 2015-04-30 12:02:41 -04:00
Brad Leege
6811e7c39d #1381 - Setting desiredAccuracy to 3KM 2015-04-30 11:58:31 -04:00
John Firebaugh
bb88b9cd8e Merge pull request #1379 from mapbox/readme-update
Updates to README for linux
2015-04-30 11:52:16 -04:00
Minh Nguyễn
6790a09a08 Turned class methods into instance methods
Avoids unnecessary steps to access singletons. Now `MGLMapboxEvents` and `MGLMetricsLocationManager` instances can message themselves directly.
2015-04-30 11:48:56 -04:00
Minh Nguyễn
87c61657a1 Objective-C niceties
Added macro for main thread assertions based on `NSAssert()`. Reworded Boolean property per Objective-C conventions.
2015-04-30 11:35:52 -04:00
John Firebaugh
7da30dc1d0 Manual configure is not required 2015-04-30 11:21:40 -04:00
John Firebaugh
b9ff7cfaf2 export CXX=g++-4.8 is required 2015-04-30 11:21:15 -04:00
John Firebaugh
bbcc7c26d9 Merge pull request #1065 from mapbox/1065-separate-ui-from-map-thread
Better separation between UI thread and Map thread
2015-04-30 10:22:06 -04:00
John Firebaugh
2b6e680e4a Disable headless tests temporarily 2015-04-30 09:58:31 -04:00
John Firebaugh
1d957d6898 Deactivate after cleanup 2015-04-30 09:57:58 -04:00
Justin R. Miller
c48962ebf2 Merge pull request #1296 from mapbox/1258-deadpan
Cancel animations on touch down
2015-04-29 16:24:43 -04:00