Commit Graph

14395 Commits

Author SHA1 Message Date
Alexander Shalamov
100eb61fa4 [core] Forward ImageManagerObserver::onRemoveUnusedStyleImages to MapObserver interface 2019-05-21 06:49:17 -07:00
Alexander Shalamov
d24524440c [core] Add onRemoveUnusedStyleImages observer API 2019-05-21 06:49:17 -07:00
Alexander Shalamov
0344ce36c4 [core] Define max cache size for ImageManager 2019-05-21 06:49:17 -07:00
Thiago Marcos P. Santos
c2f974f2a5 [core] Remove binary shader support
The implementation is buggy and not worth maintaining anymore
because performance benefits are not substantial or sometimes
worse. Also, removing it saves about 150 ~ 180 KB in binary size.

Below timings are averages of minimum 5 runs.

```
Device          Init launch     Average relaunch
s10             1129.8 ms       700 ms
s10 - binary    1346.75 ms      694 ms
Pixel           1692 ms         723 ms
Pixel - binary  1883 ms         1039 ms
Kazam           17948 ms        1339 ms
Kazam - binary  19157 ms        1564 ms
Wiko            2060 ms         1278 ms
Wiko - binary   3876 ms         1136 ms
```

Fixes #14294
2019-05-21 15:05:37 +03:00
Ander Conselvan de Oliveira
f210bbbb6c [core] Don't use optional unique_ptr in function coversion code
Since unique_ptr is already nullable there is no need to wrap it in an
optional<>.
2019-05-21 12:14:22 +03:00
Ander Conselvan de Oliveira
e30ff619c6 [core] Forward args in style::expression::dsl::compound() 2019-05-21 12:14:22 +03:00
Ander Conselvan de Oliveira
d502b72449 [core] Pass legacy/categorical/*-default expression tests
Handle categorical function default value properly in conversion to
expreexpression so related tests pass.
2019-05-21 12:14:22 +03:00
Ander Conselvan de Oliveira
1e620d3bd8 [core] Fix legacy/{interval,exponential}/*-default expression tests
Consider the function default value in interval and exponential
functions conversion.
2019-05-21 12:14:22 +03:00
Ander Conselvan de Oliveira
f2f2e64fc8 [core] Expose dsl::compound() internally
This will be used in a follow up patch by the function to expression
conversion code.
2019-05-21 12:14:22 +03:00
Ander Conselvan de Oliveira
343df18954 [core] Fix some of the legacy interval function expression tests
The tests for conversion of legacy interval functions to expressions
expects that the first stop in the "step" expression be omitted.
2019-05-21 12:14:22 +03:00
Ander Conselvan de Oliveira
33cfd080c2 [core] Fix most identity function with default legacy expression tests
Add handling of default value to the conversion of legacy identity
functions. The color and enum tests still don't pass though.
2019-05-21 12:14:22 +03:00
Ander Conselvan de Oliveira
11055f9a88 [core] Fix indentation of src/mbgl/style/conversion/function.cpp
One line in that file was indented with tabs instead of spaces.
2019-05-21 12:14:22 +03:00
Ander Conselvan de Oliveira
80edc3b821 [node] Convert legacy functions to expressions in NodeExpression::Parse
In order to test the conversion from function to expressions using the
legacy tests in the expression test suite, parse function objects into
expressions in NodeExpression::Parse.

v2: Coding style fixes.
2019-05-21 12:14:22 +03:00
Jason Wray
29140f5b11 [ios] Enable SKU tokens for all requests
Removes conditional code that relied on a plist flag. Other small cleanups.
2019-05-20 22:49:50 -07:00
Aleksandar Stojiljkovic
3cd8c6c1fd [core] Refactor HeadlessFrontend/Backend: GL separation and factory (#14692)
Refactor out HeadlessFrontend and HeadlessBackend gl independent code to gfx.
Define gl::HeadlessBackend as subclass, instantiated by gfx::HeadlessBackend static factory method.
GL dependent tests are still using gl::HeadlessBackend directly (not through gfx).
2019-05-21 07:37:49 +03:00
Thiago Marcos P. Santos
88ef7d89c4 [benchmark] Add benchmark for tile invalidation 2019-05-21 01:04:01 +03:00
Thiago Marcos P. Santos
19f5686eb2 [tests] Add unit tests for offline data invalidation 2019-05-21 01:04:01 +03:00
Thiago Marcos P. Santos
1def782cf2 [core] Add API for invalidating tiles
Add new APIs for invalidating tiles, effectively forcing Mapbox
GL Native to check with the servers if the tiles are valid before
using them. This is more efficient then deleting tiles, because
in case of valid tiles, they won't get downloaded.

Fixes #4376.
2019-05-21 01:04:01 +03:00
Aleksandar Stojiljkovic
2a3a1c7bb3 [core] Remove re-linking programs approach (#14482)
Remove re-linking programs as redundant.
It costs (cheaper to link once than twice) and (subjective) is not that common GL API
usage pattern, although perfectly legal and permitted.
Initial idea, behind the removed code, was to enable work on optimization
that would reduce number of attrib setup calls in case when VAO is not
available (as described in #9433).

As such optimization is not implemented, and it is arguable if it makes sense
to do it now, we can remove re-linking.

Related to closed PRs #9433 and PR #11583.

I have [measured the time spent just on relinking](https://gist.github.com/astojilj/29bd5a5c5dc0b2d9f29ecb660da07fbf) using release build on iPhone SE (A9, same as iPhone 6S):

- 1st run after reboot or installation
Total 37.14ms, average per program:1.86ms

- reopening
Total: 2.47ms, average per program: 0.12ms

This time we save using the patch here.
2019-05-20 16:17:19 +03:00
Mikhail Pozdnyakov
8d91264160 [core] CrossTileSymbolIndex::pruneUnusedLayers() does not create intermadiate containers 2019-05-20 14:33:41 +03:00
Łukasz Paczos
30d4a55716 [android] show multiple maps in a recycler view example 2019-05-20 12:47:52 +02:00
Alexander Shalamov
521ac5c993 [core] Check if pattern dependencies or pattern positions are missing
Add check for optional pattern dependencies and don't bind empty vertex
buffers if pattern positions are missing.
2019-05-20 01:19:04 -07:00
Mikhail Pozdnyakov
9fe5256ce7 [core] Avoid bucket downcasting in Placement 2019-05-19 18:15:33 +03:00
Mikhail Pozdnyakov
18ddced9b6 [core] Remove Bucket::supportsLayer 2019-05-19 18:15:33 +03:00
Mikhail Pozdnyakov
f2ad89c463 [core] Remove RenderLayerSymbolInterface 2019-05-19 18:15:33 +03:00
Mikhail Pozdnyakov
44fd6dcf7c [core] Placement accepts RenderLayer instances 2019-05-19 18:15:33 +03:00
Mikhail Pozdnyakov
febe696d4b [core] Avoid unneeded proj matrix calculations in renderer 2019-05-19 18:15:33 +03:00
Mikhail Pozdnyakov
0e45138547 [core] RenderLayerSymbolInterface is not used in CrossTileSymbolIndex 2019-05-19 18:15:33 +03:00
tobrun
52a69044e8 [android] - wrap jni callback with try-catch 2019-05-17 19:36:23 +02:00
tobrun
99f090b955 [android] - bump snapshot version to 8.1.0 2019-05-17 17:05:19 +02:00
Osana Babayan
ff3295bd05 [android] added connectivity state attribute to tile loading metric (#14667) 2019-05-17 09:27:37 -04:00
tobrun
0b776ff175 [android] - updat changelog for releasing v6.8.2 2019-05-17 10:57:05 +02:00
tobrun
8281a929e6 Revert "[android] new manifest flag to enable/disable sku tokens"
This reverts commit 71fd147480.
2019-05-17 09:28:29 +02:00
Nadia Barbosa
a0467ca76d [ios] Podspec updates for v4.12.0-beta.1 2019-05-16 15:03:54 -07:00
Fabian Guerra
65990b3e25 [ios] Rename performance's metrics variable names. 2019-05-16 11:13:39 -07:00
tobrun
517e8f8ae5 [android] - update changelog for v8.0.0-beta.1 2019-05-16 20:04:31 +02:00
tobrun
3f48f27363 [android] - ignore telemtry schema size test for map load 2019-05-16 19:31:56 +02:00
Jason Wray
6e92ca5de3 [ios] Update to libmbxaccounts 0.0.5 (#14683) 2019-05-16 09:43:42 -04:00
Łukasz Paczos
60a6ae2d0f [android] pull in Polish translation and updates to Czech and Hungarian 2019-05-16 10:06:04 +02:00
Sam Fader
163c085c38 [ios, macos] clarified documentation for newCamera param of the shouldChangeFromCamera delegate (#14680)
* [ios, macos] clarified documentation for newCamera in shouldChangeFromCamera

* [ios, macos] clarified documentation for newCamera param of the shouldChangeFromCamera delegate part 2
2019-05-15 18:30:28 -07:00
Fabian Guerra
295ce38f2b [ios] Update podspec to v4.11.0. 2019-05-15 14:34:54 -07:00
Konstantin Käfer
3a6ff7710f [core] add gfx::UploadPass, split startRender into prepare and upload 2019-05-15 11:57:43 -07:00
Konstantin Käfer
bf0998697e [core] don't upload empty buffers 2019-05-15 11:57:43 -07:00
Konstantin Käfer
03e434e901 [core] use float for storing opacity attribute 2019-05-15 11:57:43 -07:00
Konstantin Käfer
179c5fe83b [core] add gfx::CommandEncoder::present() 2019-05-15 11:57:43 -07:00
Konstantin Käfer
da5bd4d6e3 [core] use unique IDs for DrawScopes 2019-05-15 11:57:43 -07:00
tobrun
d5e7fabf45 [android] - remove CI execution of android nitpick, now part of android check 2019-05-15 19:32:15 +02:00
tobrun
ec2e5fc6be [android] - add nitpick validation to make android-check 2019-05-15 19:32:15 +02:00
Osana Babayan
a4c98f5a62 [android] Changelog for 7.4.0 release (#14677) 2019-05-15 11:43:13 -04:00
Łukasz Paczos
ab8caabd15 [android] fix FragmentBackStackActivity navigation 2019-05-15 16:58:13 +02:00