Remove hacks because of Glyph requests could not be canceled

This commit is contained in:
Thiago Marcos P. Santos
2015-07-15 12:02:58 +03:00
parent cd2c1200c8
commit dd818874cc
2 changed files with 2 additions and 11 deletions

View File

@@ -14,11 +14,7 @@ namespace mbgl {
class Worker::Impl {
public:
explicit Impl(FileSource* fs) {
// FIXME: Workers should not access the FileSource but it
// is currently needed because of GlyphsPBF. See #1664.
util::ThreadContext::setFileSource(fs);
}
Impl() = default;
void parseRasterTile(RasterBucket* bucket, std::string data, std::function<void (TileParseResult)> callback) {
std::unique_ptr<util::Image> image(new util::Image(data));
@@ -59,7 +55,7 @@ public:
Worker::Worker(std::size_t count) {
util::ThreadContext context = {"Worker", util::ThreadType::Worker, util::ThreadPriority::Low};
for (std::size_t i = 0; i < count; i++) {
threads.emplace_back(std::make_unique<util::Thread<Impl>>(context, util::ThreadContext::getFileSource()));
threads.emplace_back(std::make_unique<util::Thread<Impl>>(context));
}
}

View File

@@ -21,11 +21,6 @@ class PendingResources : public ::testing::TestWithParam<std::string> {
// the Map object after that. The idea here is to test if these pending requests
// are getting canceled correctly if on shutdown.
TEST_P(PendingResources, DeleteMapObjectWithPendingRequest) {
// TODO: The glyphs test is blocked by the issue #1664.
if (GetParam() == "glyphs.pbf") {
return;
}
util::RunLoop loop(uv_default_loop());
auto display = std::make_shared<mbgl::HeadlessDisplay>();