From dd818874cc1d959960e428dfcf93c7ed4bf78160 Mon Sep 17 00:00:00 2001 From: "Thiago Marcos P. Santos" Date: Wed, 15 Jul 2015 12:02:58 +0300 Subject: [PATCH] Remove hacks because of Glyph requests could not be canceled --- src/mbgl/util/worker.cpp | 8 ++------ test/style/pending_resources.cpp | 5 ----- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/src/mbgl/util/worker.cpp b/src/mbgl/util/worker.cpp index 60adbc803..516d2f5db 100644 --- a/src/mbgl/util/worker.cpp +++ b/src/mbgl/util/worker.cpp @@ -14,11 +14,7 @@ namespace mbgl { class Worker::Impl { public: - explicit Impl(FileSource* fs) { - // FIXME: Workers should not access the FileSource but it - // is currently needed because of GlyphsPBF. See #1664. - util::ThreadContext::setFileSource(fs); - } + Impl() = default; void parseRasterTile(RasterBucket* bucket, std::string data, std::function callback) { std::unique_ptr image(new util::Image(data)); @@ -59,7 +55,7 @@ public: Worker::Worker(std::size_t count) { util::ThreadContext context = {"Worker", util::ThreadType::Worker, util::ThreadPriority::Low}; for (std::size_t i = 0; i < count; i++) { - threads.emplace_back(std::make_unique>(context, util::ThreadContext::getFileSource())); + threads.emplace_back(std::make_unique>(context)); } } diff --git a/test/style/pending_resources.cpp b/test/style/pending_resources.cpp index 4513d1864..3ba59657d 100644 --- a/test/style/pending_resources.cpp +++ b/test/style/pending_resources.cpp @@ -21,11 +21,6 @@ class PendingResources : public ::testing::TestWithParam { // the Map object after that. The idea here is to test if these pending requests // are getting canceled correctly if on shutdown. TEST_P(PendingResources, DeleteMapObjectWithPendingRequest) { - // TODO: The glyphs test is blocked by the issue #1664. - if (GetParam() == "glyphs.pbf") { - return; - } - util::RunLoop loop(uv_default_loop()); auto display = std::make_shared();