Previously, we initialized global variables that held pointers to the extension functions. While this seemed to work, the spec doesn't guarantee that the function pointers are identical for different OpenGL contexts. Therefore, we are now making them a member variable of the Context object.
* Verbose commenting on getSegmentGlyphs
This came out of @cloer and @anandthakker trying to figure out
how getSegmentGlyphs actually worked.
Goal is to use this commented version as the base for a refactor.
* Refactor getSegmentGlyphs for clarity.
* Add more documentation, inline helper functions
* Initialize VirtualSegments directly
* Fix virtual anchor diagram
* [ios, macos] Corrected map load error descriptions
Ensured the uniqueness of localizable string IDs. Ran make genstrings to add the -[MGLMapViewDelegate mapViewDidFailToLoad:withError:] error description strings to the base localization.
* [ios, macos] Moved failure error changelog entry to new release
* [android] [auto] Update properties to version 5.0.0 in preparation for build.
* [android] - bump snapshot version
* [android] remove typo in gradle-javadoc.gradle
* [android] revert to 5.0.0-SNAPSHOT
* [android] revert to 5.0.0
* [android] [auto] Update properties to version 5.0.0 in preparation for build.
* next release is now 5.1.0-SNAPSHOT
`apt-get install` commands were present when the nightly build was introduced. Prior to 12b99f0 they were in a separate section without `set -eu -o pipefail`, so the error was ignored. I assume they are not needed, since the build was succeeding despite the error.
While here, ensure xcpretty is installed.
PaintPropertyBinder and subclass templates were being instantiated for every unique attribute type (e.g. a_color, a_fill_color, a_halo_color) even though they behave identically for a given property value type (e.g. Color). To fix this, a unique type such as a_color no longer derives from gl::Attribute<...> -- instead it has an inner Type typedef, which should be used wherever neither a unique type nor attribute name is required. This reduces binary size substantially:
VM SIZE FILE SIZE
++++++++++++++ GROWING ++++++++++++++
-------------- SHRINKING --------------
-2.0% -49.3Ki __TEXT,__text -49.3Ki -2.0%
-3.1% -5.21Ki [None] -2.79Ki -1.6%
-2.1% -4.12Ki __TEXT,__const -4.12Ki -2.1%
-1.4% -4.04Ki __TEXT,__gcc_except_tab -4.04Ki -1.4%
-19.3% -3.62Ki __DATA,__data -3.62Ki -19.3%
-2.5% -1.65Ki __TEXT,__unwind_info -1.65Ki -2.5%
-4.2% -8 __DATA,__mod_init_func 0 [ = ]
-1.9% -68.0Ki TOTAL -65.6Ki -1.9%
