Commit Graph

4001 Commits

Author SHA1 Message Date
Justin R. Miller
efc4bb4ef6 add header docs for new MGLAccountManager; reorg 2015-05-12 16:44:26 -07:00
Justin R. Miller
18b96ec4fd fix spacing, ordering, imports 2015-05-12 16:33:32 -07:00
Minh Nguyễn
7ed31065ed Cleaned up in-app opt-out property
Renamed the property to be consistent with the public class methods. Also removed a spurious #import of a .m file.
2015-05-12 16:16:48 -07:00
Minh Nguyễn
9850488253 Merge branch '1ec5-metrics-determinism' into 1ec5-metrics-opt-way-out 2015-05-12 16:12:25 -07:00
Minh Nguyễn
b1992a4516 Merge branch 'master' into 1ec5-metrics-opt-way-out 2015-05-12 16:09:10 -07:00
Minh Nguyễn
afbb9c2717 Enable Metrics by default default default
Enable Mapbox Metrics by default when Settings.bundle is absent, but allow Settings.bundle to override the default. Don’t register defaults for non-Mapbox preferences. The two-phase registration ensures that the defaults don’t default to unexpected values, yet gives the developer a chance to call `+[MGLAccountManager mapboxMetricsEnabledSettingShownInApp]` before the hard assertion.

Fixes #1518.
2015-05-12 15:26:07 -07:00
Justin R. Miller
50d7add6b0 Merge pull request #1517 from mapbox/metrics-tests
refs #1491: iOS metrics testing
2015-05-12 13:54:39 -07:00
Justin R. Miller
44835707a2 update test app to use fake in-app settings 2015-05-12 13:53:54 -07:00
Justin R. Miller
1ad640f5b7 iOS metrics tests 2015-05-12 13:49:03 -07:00
Minh Nguyễn
476fec6b74 Merge pull request #1530 from mapbox/1ec5-metrics-assert
Corrected Settings.bundle assertion message
2015-05-12 13:46:58 -07:00
Minh Nguyễn
b88b917cd4 Acknowledge the existence of other Mapbox GL classes 2015-05-12 12:28:43 -07:00
Minh Nguyễn
576caf0855 Corrected Settings.bundle assertion message
It’s `-[MGLAccountManager setMapboxMetricsEnabledSettingShownInApp:]`. Also clarified when the setter has to be called.
2015-05-12 11:49:40 -07:00
John Firebaugh
4c89323f6d Merge pull request #1527 from mapbox/travis-setup
break out setup.sh from run.sh, take two
2015-05-12 10:51:00 -07:00
Minh Nguyễn
310e26f45b Merge pull request #1528 from mapbox/1516-getter
Adding Getter Method
2015-05-12 10:16:46 -07:00
Brad Leege
8548ab0346 #1516 - Adding public setter method to MGLAccountManager.h. Fixing example signal opt out in MBXAppDelegate. 2015-05-12 11:37:40 -05:00
Mike Morris
2b7d2c2319 source install.sh to export mason on PATH 2015-05-12 12:13:10 -04:00
Brad Leege
3391d8f6d8 Merge pull request #1520 from mapbox/1516-opt-out-checking
Explicit Opt Out Checking
2015-05-12 11:04:14 -05:00
Mike Morris
3034d9d704 Revert "Revert "Merge pull request #1429 from mapbox/travis-setup""
This reverts commit 3ccb0b5610.

Conflicts:
	.travis.yml
2015-05-12 11:51:46 -04:00
Brad Leege
87551c6d0e #1516 - Renaming setShowsOptOutInApp to setMapboxMetricsEnabledSettingShownInApp for app consistency. Implementing wordsmith edits to NSAssert text. Removing technical debt. 2015-05-12 10:50:46 -05:00
Konstantin Käfer
1062121586 Merge pull request #1524 from mapbox/1524-build-render-on-travis
Build mbgl-render on Travis
2015-05-12 15:29:38 +02:00
Konstantin Käfer
fc74f8dcd5 Merge pull request #1484 from mapbox/fix-line-atlas-overflow
Fix potential integer overflow in line_atlas
2015-05-12 15:21:00 +02:00
Konstantin Käfer
f31b3d2ce5 build render binary 2015-05-12 15:15:05 +02:00
Konstantin Käfer
bb33493710 use boost_program_options from mason 2015-05-12 15:10:03 +02:00
Konstantin Käfer
e12c70337e Merge pull request #1510 from mapbox/after-failure
Run correct after_failure script
2015-05-12 13:31:22 +02:00
John Firebaugh
57d78bd46a Run correct after_failure script 2015-05-12 13:20:58 +02:00
Konstantin Käfer
448ffac2fa Merge pull request #1513 from mapbox/1478-vanishing-layers
Set correct strata for background render
2015-05-12 11:15:17 +02:00
John Firebaugh
76b922453a Set correct strata for background render
Fixes #1478
2015-05-12 10:50:36 +02:00
Minh Nguyễn
54a703bcb2 Consolidated logic for pausing/resuming MGLMapboxEvents
`MGLMapboxEvents` automatically recreates its location manager when the host app is reauthorized for Location Services. Added some redundancy to ensure that there is no location manager when either Location Services or Mapbox Metrics is off.
2015-05-12 01:38:04 -07:00
Minh Nguyễn
58d695f6d3 Respond to opt-out setting change immediately
As soon as the user returns to the host app after changing the opt-out preference in Settings, `MGLMapboxEvents` responds by pausing or resuming. Also moved the IB designables agent check to occur only once, at launch, since the process name is not expected to change mid-session.
2015-05-12 01:38:04 -07:00
Minh Nguyễn
ff0ec15e1d More cleanup and sanitization
Moved constant values from ivars into constants. Invalidate the flush timer and clear the event queue on pause. Rewrote some flush logic to be easier to follow.
2015-05-12 01:38:04 -07:00
Minh Nguyễn
2f02a6538e Folded MGLMetricsLocationManager into MGLMapboxEvents
`MGLMetricsLocationManager` was nothing but overhead for `CLLocationManager`. Also removed an unused method.
2015-05-12 01:36:56 -07:00
Minh Nguyễn
c1fe6e1890 Resume iff Metrics is enabled 2015-05-12 01:36:56 -07:00
Minh Nguyễn
f860169f35 Refactored MGLMapboxEvents for better data management
The shared `MGLMapboxEvents` now owns the only instance of `MGLMetricsLocationManager`. It also owns a `MGLMapboxEventsData` object, to which all user-specific data has been relegated. This object can be built up and torn down on the fly, whenever the opt-out preference is toggled. `MGLMapboxEvents` has also given up knowledge of the access token and now queries `MGLAccountManager` for that information, which `MGLMapView` keeps up-to-date.
2015-05-12 01:36:56 -07:00
Minh Nguyễn
60ed9e6d2e Objective-C method naming convention
Removed “get” from names of methods that perform no network or file access.
2015-05-12 01:36:29 -07:00
Minh Nguyễn
1503f33140 Predicate MGLMapboxEvents initialization on user opt-out 2015-05-12 01:36:29 -07:00
Minh Nguyễn
4837359471 Register default user defaults on class initialization
`-[MGLMapboxEvents init]` only gets called if `-[MGLMapboxEvents sharedManager]` sees that user defaults call for an `MGLMapboxEvents` to be created. But those user defaults were only being registered inside `-[MGLMapboxEvents init]`. This change moves the registration to `+initialize`, which is called as soon as the class is loaded.
2015-05-12 01:36:29 -07:00
John Firebaugh
3ccb0b5610 Revert "Merge pull request #1429 from mapbox/travis-setup"
This reverts commit 9a233c7ed2, reversing
changes made to 642024af6d.
2015-05-11 22:03:46 -07:00
Brad Leege
48e21ae6e9 #1516 - Adding explicit checks for developer implementation of user Opt Out functionality 2015-05-11 23:31:22 -05:00
Justin R. Miller
b67ce2b09a Merge pull request #1508 from mapbox/1503-add-changelog
refs #1503: add changelog to appledoc
2015-05-11 15:31:37 -07:00
Justin R. Miller
93a5b71af9 Merge pull request #1507 from mapbox/1502-fix-appledoc
pin to appledoc 2.2v963
2015-05-11 15:31:11 -07:00
Justin R. Miller
0664c1ed9d Merge pull request #1505 from mapbox/they-took-our-jobs
bring back $JOBS for ios packaging
2015-05-11 15:30:36 -07:00
Justin R. Miller
d784f4755c Merge pull request #1508 from mapbox/1503-add-changelog
refs #1503: add changelog to appledoc
2015-05-11 13:29:54 -07:00
Justin R. Miller
e46d50c09e Merge pull request #1505 from mapbox/they-took-our-jobs
bring back $JOBS for ios packaging
2015-05-11 13:27:51 -07:00
Justin R. Miller
834e59722c fixes #1503: add changelog w/ notes to appledoc index 2015-05-11 13:01:09 -07:00
Justin R. Miller
9ac29c6e44 remove outdated build-related iOS README 2015-05-11 12:46:10 -07:00
Justin R. Miller
467bf65635 first cut of iOS beta-started changelog 2015-05-11 12:45:57 -07:00
Justin R. Miller
44cb91c656 Merge pull request #1507 from mapbox/1502-fix-appledoc
pin to appledoc 2.2v963
2015-05-11 12:38:41 -07:00
Mike Morris
319d940161 bring back $JOBS for ios packaging 2015-05-11 15:06:51 -04:00
Justin R. Miller
0d89af422e pin to appledoc 2.2v963 for now until HEAD is better tested with our setup 2015-05-11 12:00:35 -07:00
John Firebaugh
ad5450173e Use ios-b1 branch of styles 2015-05-11 11:17:25 -07:00