Commit Graph

6405 Commits

Author SHA1 Message Date
Ansis Brammanis
e44db93f1c [core] place symbol layers in correct order
Previously, the placement of symbols depended on the order in which the
glyphs they need were loaded. The placement order should be based on the
style.

To fix this, symbol layers are placed in `placementPending` after they
are parsed. After all layers are parsed, symbol layers (stored in
`placementPending`) are placed and returned.
2016-01-14 17:51:29 -08:00
Minh Nguyễn
15f4ca51f9 [ios] Fixed static analyzer warnings 2016-01-14 16:48:16 -08:00
Minh Nguyễn
714dfab8ae [osx] Fixed static analyzer warnings 2016-01-14 16:48:16 -08:00
Jason Wray
b52b634e5b Update changelog for #3495
[skipci]
2016-01-14 19:02:01 -05:00
Jason Wray
b57e237b14 [ios] send turnstile event when telemetry is paused 2016-01-14 18:30:51 -05:00
Jason Wray
75ed155f4f [ios] remove testCompassTap test
Fails on CI because KIF is unstable. Refs
61615a44fd, #2769, #2734
2016-01-14 17:58:09 -05:00
John Firebaugh
0066637e58 [core] Let SQLiteCache decide when store or refresh responses 2016-01-14 13:46:03 -08:00
John Firebaugh
1c887ff728 [core] Use notModified rather than storing the previous response body 2016-01-14 13:46:03 -08:00
John Firebaugh
2aafdbc1b8 [core] Add an explicit "not modified" indicator to Response 2016-01-14 13:46:03 -08:00
John Firebaugh
2ee1fe4178 [core] std::shared_ptr<const Response> ⇢ const Response& 2016-01-14 13:46:03 -08:00
John Firebaugh
7fb5e973ed [core] Eliminate FileCache interface
There is only one implementation and we're unlikely to add more.
2016-01-14 13:46:03 -08:00
Thiago Marcos P. Santos
f9574e350c [core] Fix crash on transitionFrameFn callback
This is a tricky one:

We are storing a lambda at the member variable `transitionFrameFn` and
capturing `this` at this lambda function.

At some point when running the callback, we set `transitionFrameFn` to
`nullptr`, effectively destroying the callback that is being executed.

After this point, `this` is no longer valid, as the memory gets
cleared and it might point to the correct location (or not). That
is why it works on some compilers but not on g++ 5.3.1. Touching
any `this->[smth]` is undefined after that.

The fix is just move `transitionFrameFn = nullptr` to the last
thing we do on the callback. This behaves similarly to calling
`delete this` on a class method.
2016-01-14 18:59:38 +02:00
Konstantin Käfer
4515bb00c0 [node] extract the error message from the Error object
this avoids double "Error: Error: reason" messages
2016-01-14 14:35:02 +01:00
Konstantin Käfer
e195d86100 [test] don't pass raw strings as error messages 2016-01-14 14:35:02 +01:00
Tobrun
35855889df [android] #3461 - upgrade to okhttp3 for faster tile loading! 🚀 2016-01-14 14:21:46 +01:00
Tobrun
1f31de288f [android] #3535 - improve disabling tracking modes 2016-01-14 13:25:58 +01:00
Tobrun
5d9485e02e [android] #3539 - silence warning about unused param message that was breaking our build on CI 2016-01-14 11:10:45 +01:00
Minh Nguyễn
4f08ef150d [core] Fixed build error in Xcode 7.3
Removed std::move() call per Xcode fix-it suggestion.
2016-01-14 10:52:13 +01:00
Minh Nguyễn
ff8b014c5b [core] Consolidated easeTo and flyTo
Pushed much of easeTo() and flyTo() into startTransition() to avoid code duplication.
2016-01-14 00:40:46 -08:00
Minh Nguyễn
02d00662fb [core] Moved camera methods next to each other 2016-01-14 00:40:45 -08:00
Minh Nguyễn
8bad15bf87 [core] Consolidated zoom and angle anchor logic
Made anchor a CameraOption for easeTo().
2016-01-14 00:40:03 -08:00
Minh Nguyễn
a3d4aeefec [osx] Consistent origins in gesture recognizers
Cleaned up gesture recognizers, flipping the origins of anchor points only and always before calling mbgl methods. This exposed the fact that the cursor locking feature during drag-zoom/rotate/tilt was broken, so I fixed it to match MapKit behavior exactly and also account for modifier changes in mid-gesture.
2016-01-14 00:39:57 -08:00
Minh Nguyễn
ac4b1b7479 [core] Standardize transform origin
All Transform methods that take a PrecisionPoint now assume a “flipped” origin at the upper-left corner of the view. Previously, some methods assumed an origin at the lower-left corner.
2016-01-14 00:39:56 -08:00
Minh Nguyễn
d26b956a48 [core] Cleaned up Transform
Eliminated many redundant methods on Transform. Minimized usage of TransformState::x and TransformState::y. Added convenient constructors for AnimationOptions. When scaling, passing in view’s origin as the anchor no longer anchors the scaling operation at the view’s center. To specify no anchor, use NaN.

Increased precision of worldSize(), now that it’s used much more heavily in transform methods.
2016-01-14 00:39:18 -08:00
Minh Nguyễn
27b308a234 [core] Separated AnimationOptions from CameraOptions 2016-01-14 00:39:12 -08:00
Ansis Brammanis
5119ce8155 [core] fix overscaled line patterns and re-enable render tests
fix #3489
fix #2648
2016-01-13 16:39:02 -08:00
Ansis Brammanis
f7acc91d21 [core] set u_texture uniform value
fix #1685
2016-01-13 16:01:41 -08:00
Ansis Brammanis
e577354567 [core] remove bilinear, nearest scaling, fix #3164 2016-01-13 15:02:41 -08:00
Ansis Brammanis
bdfa1277a5 [core] match icon rendering with -js
port https://github.com/mapbox/mapbox-gl-js/pull/1919/files
2016-01-13 14:48:07 -08:00
John Firebaugh
618902e06c [core] Remove request coalescing in OnlineFileSource 2016-01-13 13:43:05 -08:00
John Firebaugh
716a9c92cb [core] Inline a temporary variable which is now used only once 2016-01-13 13:40:31 -08:00
John Firebaugh
5a7d2fd60e [core] Eliminate platform::assetRoot()
I regenerated assets.zip so that all file paths have an `assets/` prefix, as the Android AssetFileSource implementation asserts, and removed `TEST_DATA` from the paths.
2016-01-13 13:40:31 -08:00
John Firebaugh
86c8446d3a [core] Simplify asset:// implementation
* Move asset:// URL handling to DefaultFileSource.
* AssetFileSource implements FileSource interface and follows familiar implementation patterns.
* Move default implementation to platform/default, zip implementation to platform/android.
* Don't bother with modified / expires / etag -- assets are not cached so it doesn't matter.
* Don't bother with interleaving individual IO calls on the implementation thread. That adds a lot of complexity for very little benefit.
2016-01-13 13:40:31 -08:00
John Firebaugh
2126e34e52 [core] Further clarify timeout calculations 2016-01-13 13:38:12 -08:00
John Firebaugh
54fc3831f2 [core] Use Seconds::max() rather than -1 for simpler logic 2016-01-13 13:38:12 -08:00
John Firebaugh
96781c0a8d [core] Inline OnlineFileRequestImpl::setResponse
In the cache response case, we don't want the failedRequests logic; cached errors, should they occur, shouldn't affect the scheduling behavior for real requests.
2016-01-13 13:38:12 -08:00
John Firebaugh
601e3d9d45 [core] Refactor down to two methods for scheduling a cache or real request 2016-01-13 13:38:12 -08:00
John Firebaugh
682b2335e5 [core] Inline OnlineFileRequestImpl::getRetryTimeout 2016-01-13 13:38:12 -08:00
John Firebaugh
ea45075e4d [core] Inline OnlineFileRequestImpl::checkResponseFreshness 2016-01-13 13:38:12 -08:00
John Firebaugh
6f9de6ae47 [core] Refactor to instance methods on OnlineFileRequestImpl 2016-01-13 13:38:12 -08:00
John Firebaugh
e9eb29719b [core] Simplify logic for notification with pre-existing response
We already had a condition that checks if a response is immediately available for an incoming request. Call the callback there, rather than in addObserver.
2016-01-13 13:38:12 -08:00
John Firebaugh
dd3ca81589 [core] Inline sole use of OnlineFileSource::Impl::update 2016-01-13 13:38:12 -08:00
John Firebaugh
f8d3cf41ae [core] Simplify OnlineFileSource::Impl::reschedule 2016-01-13 13:38:12 -08:00
Minh Nguyễn
61615a44fd [ios] Removed -testCenterSet
This test is causing frequent failures on Bitrise; the failure doesn’t appear to reflect a real-world problem.
2016-01-13 13:17:43 -08:00
Konstantin Käfer
e8705d535d [core] move SourceInfo parsing to StyleParser 2016-01-13 13:04:59 -08:00
Konstantin Käfer
cef05b9017 [core] move invariant Source ID from SourceInfo to Source 2016-01-13 13:04:59 -08:00
Konstantin Käfer
8cca5c89b2 [core] rename "id" to "tileID" to avoid naming conflicts 2016-01-13 13:04:59 -08:00
Konstantin Käfer
f00a6a997b [core] move invariant SourceType from SourceInfo to Source 2016-01-13 13:04:59 -08:00
Konstantin Käfer
62973f9e5a [core] move raster tile URL normalization to source parsing 2016-01-13 13:04:59 -08:00
Konstantin Käfer
1ff317c1cd [core] remove SourceInfo dependency from *TileData 2016-01-13 13:04:59 -08:00