Commit Graph

270 Commits

Author SHA1 Message Date
Minh Nguyễn
afbb9c2717 Enable Metrics by default default default
Enable Mapbox Metrics by default when Settings.bundle is absent, but allow Settings.bundle to override the default. Don’t register defaults for non-Mapbox preferences. The two-phase registration ensures that the defaults don’t default to unexpected values, yet gives the developer a chance to call `+[MGLAccountManager mapboxMetricsEnabledSettingShownInApp]` before the hard assertion.

Fixes #1518.
2015-05-12 15:26:07 -07:00
Minh Nguyễn
b88b917cd4 Acknowledge the existence of other Mapbox GL classes 2015-05-12 12:28:43 -07:00
Minh Nguyễn
576caf0855 Corrected Settings.bundle assertion message
It’s `-[MGLAccountManager setMapboxMetricsEnabledSettingShownInApp:]`. Also clarified when the setter has to be called.
2015-05-12 11:49:40 -07:00
Brad Leege
3391d8f6d8 Merge pull request #1520 from mapbox/1516-opt-out-checking
Explicit Opt Out Checking
2015-05-12 11:04:14 -05:00
Brad Leege
87551c6d0e #1516 - Renaming setShowsOptOutInApp to setMapboxMetricsEnabledSettingShownInApp for app consistency. Implementing wordsmith edits to NSAssert text. Removing technical debt. 2015-05-12 10:50:46 -05:00
Brad Leege
48e21ae6e9 #1516 - Adding explicit checks for developer implementation of user Opt Out functionality 2015-05-11 23:31:22 -05:00
Brad Leege
d4fcb5bb98 Merge pull request #1469 from mapbox/1435-android-gl-crash
Android GL Crash
2015-05-11 11:42:21 -05:00
Minh Nguyễn
965bc41d43 Round zoom level for Map Feedback tool
The Map Feedback tool is still using mapbox.js, so it doesn’t support fractional zoom levels yet.
2015-05-10 23:34:47 -07:00
Minh Nguyễn
7da7f65579 Dismiss attribution popover on rotation
Constraints go invalid when rotating an iPad while the popover is visible and anchored to the ℹ️.
2015-05-10 23:32:38 -07:00
Jason Wray
fbafa15395 Add long/lat/zoom to feedback URL 2015-05-10 23:14:16 -07:00
Minh Nguyễn
4de7f89f47 Turned copyright notices into action buttons 2015-05-10 04:19:01 -07:00
Minh Nguyễn
965f90c449 Attribute Mapbox and OpenStreetMap in-app
ℹ️ now pops up an action sheet with explicit attribution and a direct link to the Map Feedback tool.
2015-05-10 03:53:24 -07:00
Leith Bade
703e0bc2ee Ignore deactivate when no valid EGL display. Fixes #1435
Initialise NativeMapView's EGL variables before Map

Fix hang

Add check for double pause

Add test for double pause
2015-05-09 12:02:39 +10:00
Brad Leege
08f1d4b511 #1481 - Changing events array to be created with +arrayWithArray 2015-05-08 15:24:19 -05:00
Brad Leege
2eef6b4412 #1481 - Refactoring to use iOS -copy and -removeAllObjects to get away from having to do potentially less stable index calculations 2015-05-08 15:02:32 -05:00
Brad Leege
9d0b67450d #1481 - Replacing flushAt with eventQueue count of upper range limit 2015-05-08 14:53:39 -05:00
Minh Nguyễn
13a88c5dec Merge pull request #1480 from mapbox/1ec5-metrics-keys
Rename settings keys
2015-05-08 12:06:51 -07:00
Minh Nguyễn
bb788f56f2 Renamed settings keys
The new keys fit the standard naming convention for Info.plist keys and more clearly communicate how they’re to be used.
2015-05-08 11:51:48 -07:00
Konstantin Käfer
f96580de61 catch NaN values from UIPinchGestureRecognizer 2015-05-08 20:25:43 +02:00
Brad Leege
9f0e9fe847 #1474 - Setting flushAfter back to 60 seconds. Removing debug log statements 2015-05-08 10:23:14 -05:00
Brad Leege
11886a9004 #1474 - Adding timer cleanup logic to -flush so that it doesn't loop indefinitely 2015-05-08 10:21:00 -05:00
Brad Leege
ea3979b19e #1474 - Refactoring timer to be started when first event is added to queue. Debug logic and content also included 2015-05-08 10:13:05 -05:00
Justin R. Miller
68ff978cd6 fix lingering backgrounding crashes & add debug mode 2015-05-06 15:13:51 -07:00
Minh Nguyễn
61523d50b8 Merge branch 'master' into 1ec5-analyzer 2015-05-06 12:04:19 -07:00
Brad Leege
acd27fc386 Merge pull request #1329 from mapbox/1225-start-token
MapboxGL Startup Infrastructure
2015-05-05 13:00:25 -05:00
Brad Leege
804c092c81 #1225 - Simplifying MGLAccountManager for initial setup and access to AccessToken 2015-05-05 11:50:01 -05:00
Minh Nguyễn
ec3757309f Fixed leaks of copied CF objects 2015-05-05 12:10:44 -04:00
Minh Nguyễn
fc576ddef6 Suppressed an uninitialized value warning from the static analyzer
While tracking the user’s location, a double tap not near the user dot now turns off location tracking instead of bouncing between the tapped location and the user location.
2015-05-05 12:02:47 -04:00
Minh Nguyễn
900d140f23 Fixed dead store analyzer warnings
These values weren’t being used for anything.
2015-05-05 11:41:02 -04:00
Konstantin Käfer
691c305467 add Map::isFullyLoaded()
returns whether the Map is still loading/parsing any assets or whether everything is there and a render will likely be complete
2015-05-05 11:47:23 +02:00
Konstantin Käfer
286338c978 [iOS] send map rendering notifications 2015-05-05 11:47:22 +02:00
Brad Leege
4ce4e979ff Updating from master 2015-05-04 17:04:46 -05:00
Brad Leege
7f6cc6cc6d #1225 - Renaming getAccessToken method to sharedAccessToken to avoid any iOS get naming conventions 2015-05-04 16:52:41 -05:00
Brad Leege
0e36bf1c8d #1225 - Restoring MapboxGL.h as an Umbrella header file by splitting the singleton code into MGLAccountManager.h and .m 2015-05-04 16:13:18 -05:00
Brad Leege
fef58d624f Merge pull request #1411 from mapbox/1410-one-kilometer
One Kilometer Desired Accuracy
2015-05-04 13:54:07 -05:00
Brad Leege
f4e2cccf0b #1410 - Switching Metrics Location Manager's desiredAccuracy to 1 Kilometer from 3 Kilometers 2015-05-04 13:33:42 -05:00
Minh Nguyễn
0a03f8bf5e Merge pull request #1400 from mapbox/1ec5-disable-events-163
Avoid creating MGLMapboxEvents when Metrics is disabled
2015-05-04 14:01:10 -04:00
Konstantin Käfer
914b6f01f8 add gl::groups back for easier debugging in Xcode 2015-05-04 17:33:05 +02:00
Minh Nguyễn
98dc0b6f81 Avoid creating MGLMapboxEvents when Metrics is disabled
Mapbox Metrics already has a bottleneck; might as well use it to avoid fetching data in the first place.
2015-05-01 19:24:14 -04:00
Minh Nguyễn
5e6bf19144 Fixed build errors from merge
Follow-up to cf33edf16d.
2015-05-01 00:37:51 -04:00
Justin R. Miller
cf33edf16d Merge branch 'master' into 1266-slippy 2015-05-01 00:06:47 -04:00
Justin R. Miller
c69e985fa5 fixes #1102: implement reference-counted shared file cache vendor 2015-04-30 17:52:42 -04:00
Justin R. Miller
8192d2ed10 Merge pull request #1386 from mapbox/1103-no-clobber-pointers
fixes #1103: allow multiple maps by not using global pointers
2015-04-30 17:27:38 -04:00
Minh Nguyễn
5780b676b0 Fixed iOS 7 test breakage and crash from #1382
These APIs were introduced in iOS 8+, hence the `-respondsToSelector:` check. But I saw that, thinking it was just redundant, and removed it in #1382, leading to a crash on launch on iOS 7.
2015-04-30 16:02:20 -04:00
Jason Wray
812448f830 Merge pull request #1370 from mapbox/compass-1x
Antialias compass.png N text
2015-04-30 14:28:29 -04:00
Minh Nguyễn
34e43f73bc Merge pull request #1382 from mapbox/1ec5-events-nits
Formalize NSURLSession lifetime; streamline MGLMetricsLocationManager methods
2015-04-30 14:19:50 -04:00
Justin R. Miller
858bb5dbe4 fixes #1103: allow multiple maps by not using global pointers 2015-04-30 14:08:46 -04:00
Minh Nguyễn
6342712591 Pause collection when tearing down MGLMapboxEvents for whatever reason 2015-04-30 12:28:35 -04:00
Minh Nguyễn
97fb9f6fcf Tied NSURLSession lifetime to metrics collection
Call `-resumeMetricsCollection` on `init` to consolidate the various steps to initialize `MGLMetricsLocationManager`.
2015-04-30 12:22:51 -04:00
Brad Leege
6811e7c39d #1381 - Setting desiredAccuracy to 3KM 2015-04-30 11:58:31 -04:00