Commit Graph

4438 Commits

Author SHA1 Message Date
Minh Nguyễn
a22efd4e80 Fixed compass overspinning
Rely on mbgl to drive compass rotation for simplicity. Eliminated fall-through from mbgl::MapChangeRegionIsChanging to mbgl::MapChangeRegionDidChange, because is-changing should not cause did-change to be fired.
2015-07-06 13:08:50 -07:00
Minh Nguyễn
46a6173bd7 [wrap)
If (wrap] is desired, it is the responsibility of the caller to handle the case in which min is returned.
2015-07-06 13:07:34 -07:00
Minh Nguyễn
78126f3b6b Refactored -[MGLMapView direction]
Fixed a bug in which -[MGLMapView direction] could return 360 instead of 0. Switched to mbgl::util::wrap() for clarity. -updateCompass now relies on -direction to avoid code duplication.
2015-07-06 13:07:34 -07:00
Konstantin Käfer
3ea640e6e3 run the Assert.Always test first by reordering the symbols 2015-07-06 16:44:48 +02:00
Thiago Marcos P. Santos
ec1b4c43fd Do not force uv_loop_t as the first parameter for a threaded object ctor 2015-07-06 16:01:59 +03:00
Thiago Marcos P. Santos
f6b8dd4be9 Add simple static method to retrieve the current loop
In the lines of how we do for getting information of the
current thread.
2015-07-06 15:54:51 +03:00
Bruno de Oliveira Abinader
106312c0b8 Merge pull request #1836 from mapbox/ycm-osx
Update YCM to support OSX
2015-07-06 15:21:54 +03:00
Bruno de Oliveira Abinader
c15c26eb3d Update YCM to support OSX
Besides a couple file path modifiers, we need to manually add the OSX SDK system root path.
2015-07-05 16:28:58 +03:00
Minh Nguyễn
ec93fba84a Fixed crash on launch on iOS 7
In #1793, I conflated the compass container’s constraints to its parent view with the compass container’s content size constraints, but only in the iOS 7 code path. The result was a crash on launch due to an unprepared view hierarchy.

Fixes #1818.
2015-07-05 01:35:04 -07:00
Bruno de Oliveira Abinader
d8af7319b4 Fixed test run script
- If we cannot find 'gdb' on the system (eg. OSX does not come with gdb
  by default), just run the command for now;
- We were missing passing the whole list of parameters, so I've replaced
  $1 with $@ and added '--args' for gdb to forward the params to the
  program call;
2015-07-03 13:49:38 +03:00
John Firebaugh
108792420c Check for matching source when parsing tiles (fixes #1698) 2015-07-02 15:56:02 -07:00
John Firebaugh
4870bccaba Use gdb to get backtraces
Core dumps don't work on Travis docker containers.
2015-07-02 15:23:34 -07:00
Thiago Marcos P. Santos
f74bc9d8ce Update the unit tests to check for raster tiles failures 2015-07-02 23:21:42 +03:00
Thiago Marcos P. Santos
e4cc06b798 Add test fixtures for testing raster tiles
Add a raster source for the style we use for testing that will
force requests for raster tiles.
2015-07-02 23:21:42 +03:00
Thiago Marcos P. Santos
9cc986e758 Report errors when parsing raster tiles
Use the same API/pattern for parsing raster tiles as we use for vector
tiles. Forward the error as an exception that will ultimately reach the
StillImageCallback.

Also set the tile to State::obsolete on error like we do for vector
tiles.
2015-07-02 23:21:42 +03:00
John Firebaugh
c357ce540a Use unique_ptr for Source objects (fixes #904) 2015-07-02 12:55:53 -07:00
Minh Nguyễn
9361cbfd5f Fixed round-tripping between pixelForLatLng() / latLngForPixel()
Followup to cfa2eaf5c2 for #1406.
2015-07-02 10:48:01 -07:00
John Firebaugh
f5f19d0eb0 External synchronization for AnnotationManager 2015-07-02 10:12:04 -07:00
John Firebaugh
117322d349 Don't inherit for code reuse 2015-07-02 10:12:04 -07:00
John Firebaugh
1da2c3f840 Remove unnecessary virtual methods from TileData 2015-07-02 10:12:03 -07:00
Jason Wray
dba1e44f55 Add collision box debugging to the global debug toggle 2015-07-02 10:10:32 -07:00
Ansis Brammanis
9d714dcf83 fix line tessellation, fix #1814 2015-07-02 13:18:59 +02:00
Ansis Brammanis
a8f77d23cc reduce collision box linewidth to 1
06eece43a8
2015-07-02 12:35:15 +02:00
Ansis Brammanis
45e4938f9e fix cross-tile label collisions
fix #1816
fix #1689

The missing label was the only one in it's bucket. Since the label was
outside the tile boundaries it wouldn't need to be drawn by the bucket.
Since the bucket had no features to draw, it was dropped completely.
Even if a bucket doesn't have any features that need to be rendered, it
may have features that need to impact the placement of features in other
layers.
2015-07-02 12:31:50 +02:00
Justin R. Miller
4a44b70407 [publish ios-v0.4.4] 2015-07-02 01:58:53 -04:00
Justin R. Miller
28fa8952fc bump podspec to 0.4.4 2015-07-02 01:58:24 -04:00
John Firebaugh
e466348dea Remove unnecessary use of optional 2015-07-01 17:12:21 -07:00
John Firebaugh
c0af683f2e Reapply style layer copy technique 2015-07-01 16:12:12 -07:00
John Firebaugh
fc64e97bce Simplify RunLoop
Instead of transforming between return value and callback, pass
the wrapped callback on to the invoked function as the last argument.

This eliminates the need for multiple invokeWithArgument overloads
and permits invoked functions to be asynchronous.
2015-07-01 16:12:12 -07:00
John Firebaugh
3ab682e627 Fix name shadowing 2015-07-01 15:21:11 -07:00
John Firebaugh
db1202e8e3 Don't pass Worker& around so much 2015-07-01 15:21:11 -07:00
John Firebaugh
abdf205510 Rename workerData ⇢ tileWorker 2015-07-01 15:21:11 -07:00
Thiago Marcos P. Santos
d30fce5f7d Catch exceptions when parsing tile PBFs
Also improved the error message and updated the test case.
2015-07-01 15:21:10 -07:00
John Firebaugh
3670a78569 Convert Worker tests to Thread tests 2015-07-01 15:21:10 -07:00
John Firebaugh
eee02425fa Single-purpose Worker functions 2015-07-01 15:21:10 -07:00
John Firebaugh
f14e4c67fd Add comment about a subtlety 2015-07-01 15:21:10 -07:00
John Firebaugh
5fadda53e5 Move WorkerTask functionality into RunLoop core
As a byproduct, this makes FileCache get requests properly
cancelable.
2015-07-01 15:21:10 -07:00
John Firebaugh
d596d9dc38 Clean up bucket creation loop 2015-07-01 15:21:09 -07:00
John Firebaugh
24f50fdd4f Remove indirection 2015-07-01 15:21:09 -07:00
Konstantin Käfer
9e0b241dde reset partialParse when starting a new parsing run 2015-07-01 15:21:09 -07:00
John Firebaugh
4676553a3e Merge TileParser into TileWorker 2015-07-01 15:21:09 -07:00
John Firebaugh
875ef979be Remove indirection 2015-07-01 15:21:09 -07:00
John Firebaugh
217c376291 Push TileMembers members down hierarchy 2015-07-01 15:21:09 -07:00
John Firebaugh
29a2cd908f Introduce TileWorker 2015-07-01 15:21:08 -07:00
John Firebaugh
7e71145a89 Make request and reparse pure virtual 2015-07-01 15:21:08 -07:00
John Firebaugh
ee46378583 Reduce number of arguments in Source::update pathway 2015-07-01 15:21:08 -07:00
John Firebaugh
4eff674c1d Revert "Do not hold a reference to the Style at the [Live|Vector]TileData"
This reverts commit 044454417b.
2015-07-01 15:21:08 -07:00
Justin R. Miller
424629d7fc Merge pull request #1815 from mapbox/expose-ios-subviews
fixes #1770: rename & expose compass, logo, and attribution
2015-07-01 12:30:23 -04:00
Justin R. Miller
76333dfc0c fixes #1770: rename & expose compass, logo, and attribution 2015-07-01 12:09:33 -04:00
Jason Wray
81d88755df Remove tracking mode reset from resetNorthAnimated 2015-07-01 11:16:43 -04:00