Commit Graph

4150 Commits

Author SHA1 Message Date
Minh Nguyễn
7fea85a429 Pulled self-less utility methods out into functions
Also include the name of the requested resource when asserting because one can’t be found.
2015-05-21 15:19:08 -07:00
Minh Nguyễn
eb146c0431 Merge pull request #1617 from friedbunny/ios-tests-phablet-support
Add iOS tests support for all screen sizes
2015-05-21 15:13:16 -07:00
Jason Wray
a898ec02b0 Change LaunchScreen text to © because unicode is awesome 2015-05-21 15:10:54 -07:00
Jason Wray
9c309808bd Add iOS test project launch images for older devices, too 2015-05-21 14:59:43 -07:00
Jason Wray
ddc8d63730 Add iOS tests support for iPhone 6/6+ screen sizes 2015-05-21 14:34:04 -07:00
Minh Nguyễn
a2a63301ec Merge pull request #1615 from mapbox/1ec5-plist-order
Fixed account type setting; reworded IB designable message
2015-05-21 14:12:25 -07:00
Minh Nguyễn
2200c51a33 Removed unavailable method implementation
This class method is marked unavailable in MGLAccountManager.h, so this code can never be reached.
2015-05-21 13:29:46 -07:00
Minh Nguyễn
93f92b7805 Rewrote IB designable message
IB designables inside frameworks have no access whatsoever to the host app’s bundle (especially if the host app lacks any designables of its own). So it has no way of knowing whether the access token is set in Info.plist. We could continue to check whether it was set programmatically, but we’d still have no way of knowing whether the host app has a Settings bundle, the other prerequisite for displaying Mapbox maps. Therefore, this change removes the Mapbox logo from the designable and displays a reworded reminder unconditionally. It now displays the URL of the “First steps with Mapbox GL for iOS” guide. I kept Mapbox blue in the designable, but as a border, so you can easily tell where the view ends (a major usability problem for custom views in IB).
2015-05-21 10:10:35 -07:00
Minh Nguyễn
e74997e2c1 Clarified IB designable message
Access tokens are only required for showing Mapbox-hosted maps.
2015-05-21 08:53:40 -07:00
Minh Nguyễn
0c783141f6 Merge pull request #1614 from friedbunny/update-tests-for-token-changes
Update iOS tests for access token changes
2015-05-21 07:13:50 -07:00
Jason Wray
dfd6ff00a2 Update tests for access token changes 2015-05-21 03:13:55 -07:00
Minh Nguyễn
a91b1d73e2 Merge pull request #1611 from friedbunny/1519-actionsheet-metrics-squash
[squash] Add action sheet shortcut to Settings.app metrics opt-out
2015-05-21 01:55:17 -07:00
Minh Nguyễn
c718d2ea66 Made accessToken uninspectable 2015-05-21 01:51:18 -07:00
Minh Nguyễn
70381d2705 Fixed up various Info.plist edge cases
Need to look in the main bundle for Info.plist settings, because the developer has no access to the framework’s Info.plist. Need to check MGLMapboxMetricsEnabledSettingShownInApp before MGLMapboxAccessToken; otherwise, `MGLMapboxEvents` inspects the Settings bundle plist before MGLMapboxMetricsEnabledSettingShownInApp is even checked.
2015-05-21 01:49:53 -07:00
Jason Wray
911a8ffc60 Add action sheet shortcut to Settings.app metrics opt-out
Only applicable to iOS 8+. Checks if metrics setting has been declared to be offered in app, if not: adds ℹ️ action to open the app's Settings.app section.

Fixes #1519. Squash of #1529.
2015-05-21 00:12:49 -07:00
Leith Bade
8a83c31e05 Merge pull request #1610 from mapbox/android-latlng-swap
Fix swapped lat/lng
2015-05-21 10:16:35 +10:00
Leith Bade
a89a75f5c7 Merge pull request #1609 from mapbox/android-gradle-123
Update Android gradle plugin to 1.2.3
2015-05-21 09:53:40 +10:00
Leith Bade
cea926c62e Fix swapped lat/lng 2015-05-21 09:51:43 +10:00
Leith Bade
710ec54a55 Update Android gradle plugin to 1.2.3 2015-05-21 09:00:03 +10:00
Minh Nguyễn
256b748458 Merge branch '1ec5-plist-1535' 2015-05-20 14:38:36 -07:00
Brad Leege
8f8631963b Merge pull request #1603 from mapbox/1595-internal-billing
Counting App Users For Billing
2015-05-20 15:56:18 -05:00
Brad Leege
a47438d42a #1595 - Changing to strongSelf 2015-05-20 15:12:48 -05:00
Brad Leege
cbcc3a3e49 #1595 - Separating pushTurnstileEvent from primary pushEvent infrastructure. Adding event, created, and appBundleId to posted Turnstile Event data model. 2015-05-20 15:05:56 -05:00
Brad Leege
a29587726c #1595 - Moving MGLEventTypeAppUserTurnstile event to end of MGLMapboxEvents init method to ensure it only gets called once 2015-05-20 14:32:16 -05:00
Brad Leege
44caf2c7a9 #1595 - Improving stability by moving MGLEventTypeAppUserTurnstile after the strongSelf check 2015-05-20 14:18:39 -05:00
Minh Nguyễn
90a50c0c41 Observe access token changes
The singleton `MGLAccountManager` wants to be the sole arbiter of the access token, but each instance of `mbgl::Map` (`mbgl::DefaultFileSource` in #1607) has its own copy of the access token. Now `MGLMapView` observes for changes to the `MGLAccountManager`’s access token and synchronizes `mbgl::Map` with it.
2015-05-20 11:49:59 -07:00
Justin R. Miller
51618c35d7 update README to mention desktop style toggling 2015-05-20 11:07:23 -07:00
Minh Nguyễn
a081f1af5b Removed redundant declaration 2015-05-20 10:47:42 -07:00
Minh Nguyễn
9a57464f82 Removed accessToken from MGLMapView public API
With helpful instructions for migrating to Info.plist or the `MGLAccountManager` API.
2015-05-20 10:45:26 -07:00
Brad Leege
a5bd2fa3c6 #1595 - Adding exception so that Turnstile event will always be sent in 2015-05-20 12:31:20 -05:00
Brad Leege
58b967605a Implementing suggestions to tighten up MGLAccountManager and rename MGLEventTypeUserCount to MGLEventTypeAppUserTurnstile 2015-05-20 11:32:57 -05:00
Minh Nguyễn
b6765a2eb1 Merge pull request #1453 from mapbox/1ec5-whee-2
Prevent full-circle spin during animated rotation
2015-05-19 16:18:26 -07:00
Minh Nguyễn
2a02f42b4a Merge pull request #1601 from mapbox/1ec5-metrics-param-url
Compare hostname for adding events=true
2015-05-19 16:14:14 -07:00
Brad Leege
f3d7212137 #1595 - Adding App User count event to be triggered and immediately sent when Access Token is set. 2015-05-19 17:02:54 -05:00
Minh Nguyễn
d474f35371 Check account type before comparing hostname 2015-05-19 14:33:19 -07:00
Minh Nguyễn
52670f0560 Cache account type user default 2015-05-19 14:31:30 -07:00
Minh Nguyễn
90b70180c5 Compare hostname for adding events=true
ref #1596, #1599
2015-05-19 13:44:29 -07:00
Brad Leege
f74fe69cb8 Merge pull request #1599 from mapbox/1596-non-mapbox-tiles
Adding mapbox.com checking to http requests
2015-05-19 14:37:16 -05:00
Brad Leege
ec4cd494cb #1596 - Adding mapbox.com checking to http requests 2015-05-19 14:23:21 -05:00
John Firebaugh
bd4fca2ec3 Update test suite 2015-05-19 11:28:00 -07:00
Ansis Brammanis
03d5e2da80 port sprite atlas pollution fix
fixes #1398

js: 212760981493460b438f1cc117001825773fad91
https://github.com/mapbox/mapbox-gl-js/pull/1195

The sprite atlas already had two empty pixels between each each icon.
But the icon's real boundary isn't used for drawing. Drawing uses an
icon's box rounded up to the nearest multiple of four. Sometimes this
rounded boundary was directly on the edge of another icon. When the icon
was sampled with linear interpolation it's edge would get polluted with
values from the other icon.

This commit shifts all icons and glyphs by 1px so that there is padding
on all sides of the box being drawn. The quads used for drawing are
shifted in the opposite direction by 1px to compensate for this.
2015-05-19 10:04:46 -07:00
Konstantin Käfer
d7bd429619 bump test suite 2015-05-19 17:56:20 +02:00
Konstantin Käfer
bcf66b7449 only return locked FontStack objects 2015-05-19 16:13:36 +02:00
Konstantin Käfer
b0c89e7f44 extend the FontStack lock to returned values 2015-05-19 16:13:36 +02:00
Konstantin Käfer
ab3105aac9 don't mark the glyphs as parsed until we've actually parsed them 2015-05-19 16:13:36 +02:00
Konstantin Käfer
58c9e2687d Merge pull request #1591 from mapbox/1591-always-upload-tests
Upload test results regardless of outcome
2015-05-19 16:13:00 +02:00
Konstantin Käfer
a87c58fcb1 fix Travis stage name 2015-05-19 15:58:14 +02:00
Brad Leege
5572504d38 Merge pull request #1589 from mapbox/1396-info-plist-only
Manage Metrics TEST URL Via Info.plist
2015-05-18 21:40:26 -05:00
Minh Nguyễn
1102f85a83 Less bland default title for user dot annotation
What’s a map without a You Are Here sticker?
2015-05-18 17:21:49 -07:00
Minh Nguyễn
b7b4515d48 Marked unused parameters with __unused
Replaced haphazard usage of pragmas and `(void)` expressions with the `__unused` keyword.
2015-05-18 17:11:12 -07:00