Testing must-revalidate: true required an expiration date in the future, which exposed a round-tripping problem from translating NSDate to time_point based on now().
Use epoch of 1970 instead (although technically it's not guaranteed to be the epoch for system_clock until C++20)
* [android] Update release script to support CircleCI builds (#8950)
* update release script to trigger builds on circleci now
* update release script to trigger builds on circleci now
* [core] When a layer is added, reload its source's tiles
* [android] - keep observer when timeout occurs, make observer param nullable, fixup log messages (#8919)
* [android] - avoid crashing when deleting already deleted region (#8920)
* [android] - update LOST to 2.3.0 (#8872)
* [android] - update proguard config, allow debug mimification, update OkHttp to latest version (#8944)
* [core, android, ios, macos, qt] v10 default styles
Upgraded from v9 default styles to v10 wherever the developer expects to get the latest and greatest, as well as in a couple tests where it may be beneficial to ensure that we can handle a two-digit version number in the style URL.
Cherry-picked from ed54849e99.
* [ios, macos] Updated documented default style version
MGLStyleDefaultVersion is just for Streets now. Deleted style version documentation tests because not all styles are on the same version.
Cherry-picked from ca97dd8cf4.
* [ios, macos] Undeprecated unversioned style URL factory methods
Undeprecated the unversioned style URL factory methods in MGLStyle for consistency with the Android and Qt SDKs. Added warnings about using them with the runtime styling API.
Refactored mbgl::util::default_styles to track different versions for different styles.
Cherry-picked from 9e384b78fb.
* [core, android, ios, macos] Added Traffic Day/Night to default styles
The Styles API section of the Mapbox API Documentation site now lists Traffic Day v2 and Traffic Night v2, so this change adds those styles to all the places where styles are listed.
Also switched iosapp and macosapp to unversioned style factory methods since MGLStyleDefaultVersion is no longer applicable for all styles.
Cherry-picked from 4d6f54553d.
* [android] Release android-v5.1.0-beta.2 (#8976)
* [android] url getter on sources
* [android] fix ui test filter in makefile
* [android] - build SNAPSHOT from release branch (#8958)
* [android] - update changelog for 5.1.0-beta.2
* [android] - bump version number
* [android] - Camera change listener v2.0
* [core] allow filesource url transform reset
* [android] Update attribution wordmark (#8774)
* Update wordmark on android
* Moved attribution i icon to the right of mapbox word (in mapview preview image)
* update padding and margin
* [android] update hardcoded branch name
* revert version to 5.1.0-SNAPSHOT
* [android] - MarkerView deselect events with OnMarkerViewClickListener integration (#8996)
* [android] - publish SNAPSHOT from release 5.1.0 branch (#8995)
* [ios, macos] edited identity interpolation mode documentation (#8657)
* [ios, macos] Factored out tile URL template guide
Factored out redundant tile URL template documentation from the MGLRasterSource and MGLVectorSource documentation into a jazzy guide. This documentation used to live in one place, on a method on MGLTileSource, but that method had to be moved to MGLTileSource’s concrete subclasses. A jazzy guide is easier to link to, in any case.
* [ios] Telemetry button in modal view controllers (#9027)
Fixes#8980.
* [android] - bump tools and support lib version due to SNAPSHOT dependencies (#9046)
* [android] - bump tools and support lib version for SNAPSHOT dependencies
* revert unsupported Circle CI build tools version
* [core] Make destructor virtual to avoid object splicing during destruction
* [core] add error for non-virtual destructor deletes + add virtual dtors
* [android] - remove marker from selected markers when removing marker from annotation manager. (#9047)
* Observe layout guides (#7716)
* [ios] observe layout guides
* [ios] update changelog
* [ios, macos] Change == to = in style function initializers
* [ios] Add annotation view initializer with annotation and reuse id (#9029)
* [ios] Remove annotation view from container view when annotation removed (#9025)
The annotation container view keeps an array of annotation views that is separate from the array of subviews that is a property of the UIView parent class. This removes an annotation view from that container view array when the associated annotation is removed. This avoids issue related to previously removed annotation views continuing to be involved in map view logic around annotation view selection due to taps.
* [android] - correct bearing conversion when animating the map with jumpTo, easeTo and animateTo. (#9050)
* [ios, macos] Updated `maximumZoomLevel` description, cherry-picked #8818 (#8842)
Cherry-picked from a3e4e67ea6.
* [ios] Updated podspecs and changelog for v3.5.3 (#8870)
Cherry-picked from 25c19902a2.
* [ios] Update podspecs and changelog for iOS v3.5.4
Cherry-picked from db7bb509e9.
* [ios, macos] Updated changelogs
* [ios, macos] changed TRUE -> 'true' (#9059) fixes#9056
* [ios, macos] Light property implementation in MGLStyle (#9043)
* [ios, macos] Add MGLLight to MGLStyle
* [ios, macos] Implement Objc bindings for Light object
* [ios, macos] Remove rawLight from MGLLight and re-implement it as value class
* [ios, macos] Fix build on macos
* [ios, macos] Add MGLLight documentation, Move MGLLightPosition to MGLLight
* [ios, macos] Add MGLLight tests.
* [ios, macos] Update changelogs
* [ios, macos] Fix misspelling
* [ios, macos] Fix MGLLightAnchor enum property names
* [ios, macos] Update documentation. Improve varialble naming.
* [ios, macos] Rename MGLLightPosition to MGLSphericalPosition
* [ios, macos] Update data types of MGLSphericalPosition
* [android] - horizontally rotated in snapshot (#9083)
* Cherry-pick arabic text to release branch v3.6.0 (#9071)
* [core] Throttle tiles to redo symbol placement at most once every 300ms.
Fixes issue #8435 and prepares for pitch-scaling changes in issue #8967.
* [core] Disable letter-spacing for Arabic labels (issue #9057)
* [ios,macos] multipolygon coordinate (#8713)
* [ios] MGLMultiPolygon's coordinate property implemented
* [ios,macos] Add polylabalel to project config
* [ios,macos] Change coordinate property for MGLPolyline,MGLPolygon,MGLMultiPolygon
* [macos] Change project configuration to support polilabel
* [ios,macos] Add MGLLocationCoordinate2DFromPoint
* [ios, macos] Update changelogs
* [ios, macos] remove unnecesary variables
* [ios, macos] Add radians conversions
* [ios, macos] Add coordinate calc to MGLPolyline
* [ios, macos] Move radian fuctions to MGLGeometry_Private.h
* [ios, macos] Fix code style
* [ios, macos] Fix code indentation
* [ios, macos] Fix radian per meters constant
* [ios, macos] Add test scenarios to testPolyline
* [ios, macos] Fix test accuracy
* [ios, macos] More robust Streets localization
Added Arabic, Portuguese, and Simplified Chinese to the list of languages with specialized fields in the Mapbox Streets source.
Rely on NSBundle to select the most appropriate locale based on the user’s preferred languages.
* [ios] Fallback to Mapbox.bundle as the framework bundle (#9074)
Fixes an issue where localizations could not be found when using static builds.
Throws exception if our bundle can't be found.
* [ios] Move image resources to an asset catalog & switch to PDFs
* [ios, macos] Updated changelogs
Reorganized the changelogs with a new packaging section. Added blurbs about #9062, #8713, #9060, and #9031.
* [ios] Update pods spec for iOS v3.6.0-beta.1
* [macos] Enable View ‣ Traffic Night
Enable the View ‣ Traffic Night menu item and check it when that style is active.
* [android] - stop location updates when toggle MyLocationView state (#9099)
* [android] - LatLngBounds bearing default value (#9102)
* [ios, macos] Fix MGLLight.achor to accept style functions
* [ios] Fix annotation initializers for subclasses of MGLAnnotationView (#9104)
Use a common init function in both of the provided initializers so that subclasses of `MGLAnnotationView` written in Swift don't need to override `init(annotation, reuseIdentifier)`
* [ios] Moved `MGLLight` in jazzy table of contents (#9111)
* [android] - logo placement for creating a Mapview programatically (#9094)
* [android] - Correct logo placement for creating a Mapview programatically, fixup non default placements
* Fixed NIGHTY_TWO_DP typo to NINETY_TWO_DP
* [android] - add binding support for Light (#9013)
* [android] Update Lost to final version 3.0.0 (#9112)
* update lost to final version 3.0.0
* bump MAS version to 2.1.1
* [android] - convert dp to pixels when getting meters per pixel at. (#9048)
* Release Android v5.1.0-beta.3 (#9115)
* [android] - Changelog update for Android release v5.1.0-beta.3
* update CI & version
* reset release properties
* [android] - harden orientation changes (#9128)
* [ios] Remove filter of single metric event
* [ios] remove layout guide observers
* Migrate to GL JS–powered feedback form (#9078)
* [ios, macos] Updated feedback URL
* [ios, macos] Add referrer, heading, pitch to feedback URL
* [ios, macos] Updated changelogs for feedback changes
* [ios] Vary referrer by platform
* [android] - javadoc update for 5.1.0 release (#9138)
* [android] - javadoc update for 5.1.0 release
* oxford comma
* Grammar/spelling tweaks
* grammar tweak
* grammar tweak
* Grammar tweaks
* Grammar tweaks
* [android] fix missing access token variable issue (#9151)
* [ios] Update pods spec for iOS v3.6.0-beta.2
* [android] Cherry picking 9133 (#9145)
* [android] Fix tracking mode + camera race condition (#9133)
* [android] fix tracking mode + camera race condition
* fix resetTrackingModesIfRequired bug (comparing current camera position with target camera position
* cherry pick #9133 and update CHANGELOG
* add null check to prevent null pointer exception
* add null check in custom location engine activity to prevent null pointer exception (#9159)
* [core] Make TransformState LatLngBounds optional
* [ios] Make annotation view rotation alignment configurable (#9147)
This commit adds `rotatesWithMap` property on `MGLAnnotationView`. This
property, when set to `YES` fixes the annotation to a map such that view
follows map's rotation angle. This is useful when user wants to display
rotation-dependent annotations (e.g. sector lights).
* [android] - validate if gestures should execute (#9173)
When linking Mapbox GL as a static library, the object file (MGLFoundation.o) containing the global static variable initialization was not linked into the resulting binary since it was not referenced. This resulted in the RunLoop not being initialized in the main thread.
Reverts 03a14ff000
This uses the pause/resume API on the default file source to pause
network and revalidation activity when the host iOS application goes
into the background. Activity is resumed when the host application goes
into the foreground.
The intention of this change is to avoid edge cases on some OSs where
resources (i.e. sqlite) are not available when the host app is not
visible to the user.
This commit also gets rid of private `MGLOfflinePackDelegate` protocol.
`userInfo` dictionary in notification objects retain the `state` and
`progress` values for backwards compatibility. They can be removed in
later major release.
Renamed MGLGeoJSONSourceOption and MGLOfflinePackUserInfoKey constants for clarity and to remove redundancy in the Swift-bridged names. Left the old MGLOfflinePackUserInfoKey constants in place as deprecated aliases.
We cannot guarantee that the offline/ambient tile cache (cache.db) will be created in a timely manner, so it's safer to set the backup exclusion key on its containing directory.
But, because we placed cache.db in the base of the app's Application Support directory (where backups are expected to be allowed), we need to move cache.db into a directory that we control and can exclude from backups with impunity.
This is an amalgam of https://github.com/mapbox/mapbox-gl-native/pull/5578 (directory exclusion) and https://github.com/mapbox/mapbox-gl-native/pull/5585 (refactored URL methods, but without the new database size method).
Also:
* Prefix mapbox subdirectory with dot, for extra safety
* Update changelog entry with new ticket, less speculation
Consolidated NSValue categories to work around realm/jazzy#539. Documented MGLErrorCode. Moved jazzy configuration file into platform/ios/. Removed redundant include/Mapbox.h that was only being used by jazzy, now that the static frameworks’s umbrella header is based on that of the dynamic framework. Moved framework/Mapbox.h to include/Mapbox.h for consistency.
Requesting progress is expensive, so it is once again computed only on demand, rather than automatically at launch. Moved progress requesting back to iosapp and osxapp.
An MGLOfflinePackProgressChangedNotification notification now includes the pack’s state and progress values, which match the values in the corresponding MGLOfflinePack properties. Implemented NSValue category methods to store MGLOfflinePackProgress inside a dictionary.
Fixed an incomplete variable renaming. Don’t bother creating intermediate directories to the legacy cache path. When the main bundle lacks a bundle identifier, as is the case when the SDK runs in the test bundle, fall back on the SDK’s bundle.
Made MGLOfflineStorage.packs strong rather than copy so that KVO notifications on that key path include index paths. Replaced custom KVO mutable collection methods with calls to -mutableArrayValueForKey:, avoiding redundant casts.
Privatized MGLOfflinePackDelegate and made its methods required, since MGLOfflineStorage is the only conforming implementation. Require a pack to be explicitly invalidated before deallocation by its owner (MGLOfflineStorage). Added a method to reload the canonical collection of packs.
Previously, if the user adds an offline pack without specifying a name in the alert, the pack would be named “Untitled n” for the nth pack created since the application was launched. This logic could result in identically named packs (for example, if the user relaunches and creates another unnamed pack). Instead, use the visible coordinate bounds as a placeholder and fallback name.
Resume a pack upon successful addition. Removed an extraneous weakSelf/strongSelf dance. When possible, update individual labels in a cell instead of reloading the entire cell. That way, if the user swipes to the left to reveal the Delete accessory button while the pack is actively downloading, the accessory button remains on screen as progress updates come in.
MGLOfflineStorage now maintains a centralized, strongly held, KVO-compliant collection of all extant offline packs. MGLOfflineStorage issues notifications for progress updates. Client code can now react to the successful addition of an offline pack either via the completion block or via a KVO insertion.
Fixes#4287.
Avoid backing up the offline cache onto iCloud, because it can be redownloaded and would easily take up a significant portion of a standard iCloud account. Ideally, we’d even put ambiently cached resources in Caches, so it can be reclaimed by the system when disk space runs low. But unfortunately it has to live in the same file as offline resources.
There is now only one instance of mbgl::OfflineFileSource, created when the shared MGLOfflineStorage object is initialized. Also create and use the shared MGLOfflineStorage object when initializing an MGLMapView object. The unified cache file is located in a subdirectory of Application Support, where the SDK has control over the file’s lifetime. The subdirectory is already named after the host application’s bundle identifier, ensuring that each Mapbox-powered application has an independent tile limit. If there’s an ambient cache in a subdirectory of Caches, delete it. If there’s an offline cache in a subdirectory of Documents on iOS or Caches on OS X, move it to the unified cache location in a subdirectory of Application Support.
Fixes the iOS/OS X side of #4338.
Fixed a race condition that could occur if a progress update comes after a call to remove the task but before the removal is complete. Avoid synchronously setting the task’s state inside -resume and -suspend; instead, rely on the observer to set the state asynchronously.
