Only the logo view’s baseline is aligned to the attribution view’s baseline; the X-height doesn’t need to be aligned. Previously, macOS ignored the X-height constraint inferred from the alignment rect, but now it honors it in addition to the baseline.
This updates the package script to include a pre-built iOS app in the published assets of the dynamic SDK. It symlinks the Mapbox.framework in that dynamic build to the demo app so the only real increase in size is the demo Xcode project itself.
The addtional step in the publish script checks that the Mapbox.framework that is symlinked in for building in the demo project can actually be built. If it cannot, then the step is skipped and the build will continue as it normally would. Since the demo app is currently not required for publishing it should not block publishing a build.
Updated comment to reflect that MapView's lifecycle callback in a fragment should be called from onDestroyView rather than on onDestroy. This is consistent with that MapFragment is doing.
* [macos] Deploy macosapp as part of releases
Added steps to the packaging script to archive and export macosapp. Upload the exported, compressed application bundle to the GitHub release when deploying a release.
* [macos] Explicitly named function argument
* [macos] Consolidated xcodebuild invocations
* [ios] Fix toCamera.centerCoordinate in shouldChangeFromCamera has same center as oldCamera.
* [ios] Update changelog.
* [ios] Remove unnecessary variables.
* [ios] Clarify changelog doc.
* [android] - downgrade minimum sdk version to 14
* [android] bump MAS version to the one which includes min sdk version 14
* bump lost version to 3.0.4
* [android] fix map snapshotter marker example
The reference to the MapSnapshotter needs to be held for the duration of the snapshot, otherwise it might be GC'd
* [android] MapRendererRunnable - avoid weak reference table overflow
Apparently on some devices the weak reference table is limited (numbers around 52000). Even though we don't use that many weak references, when GC is not called for a while they can stack up and a crash will occur before the GC has had the time to clear the references. The C++ peer now holds on to a global ref (strong) which can be obtained to queue the java peer and then release automatically so that the GC can take over after the runnable has been executed.
* [ios] Summarize places, roads after zooming with VoiceOver
After zooming, MGLMapView’s accessibility value now indicates the number of visible roads and lists out a few places visible in the current viewport, starting with the features at the highest z-index (not necessarily the largest or the closest to the center of the view). Avoid saying that no annotations are visible.
* [ios] Allow VoiceOver to navigate among place features
Split out a separate header for the various accessibility elements tied to MGLMapView. Wrap place features in accessibility elements and insert them into the narration order after the visible annotations but before the attribution button. Refactored MGLMapView’s accessibility code to rely on ranges to avoid off-by-one errors.
* [ios] Post layout change notification when fully rendered
Post a layout change notification when fully finishing a map render.
* [ios, macos] Moved MGLVectorSource+MGLAdditions to more specific group
* [ios] Localize accessibility feature names
* [ios] Find place feature accessibility elements by identifier
* [ios] Refactored accessibility traits
Also created a new MGLPlaceFeatureAccessibilityElement class.
* [ios] Sort accessibility elements by screen distance from center
Sort annotation accessibility elements by screen distance, not the hypotenuse of coordinates, which can yield incorrect results when the map is rotated or tilted or when the user is located at high latitudes. Sort place feature accessibility elements by screen distance as well.
* [ios] Create a place feature accessibility element, not an abstract feature accessibility element
* [ios] Only query for visible place features once per camera
Improved accessibility performance after changing the map camera. MGLMapView no longer queries the map for place features once per place feature.
* [ios] Made roads accessible
Wrap visible road features in accessibility elements described by the road name, route number, and general direction of travel.
* [ios] Cleaned up radian conversions
* [ios] Thickened road accessibility elements
* [ios] Made unioned roads accessible
* [ios] Consistently sort accessibility elements
Also fixed an issue causing road feature accessibility elements to get treated like place feature accessibility elements.
* [ios] Announce direction of divided roads
Announce the direction of a divided road based on the direction of its first polyline.
* [ios] Refined announced elevation units
* [ios] Romanize feature names
* [ios] Updated changelog
* [ios] Delay zoom announcement
A 100-millisecond delay is enough for the post-zooming announcement to reflect the new zoom level rather than the previous zoom level.
* [ios] Consolidated geometry functions
Adopted MGLGeometry_Private.h in the accessibility code, forcing a conversion to Objective-C++. Avoid inlining some of the more complex geometric functions.
* [ios] Fixed feature name romanization in accessibility labels
NSLocale.scriptCode is only set when the locale identifier explicitly specifies a script. Use NSOrthography to identify the dominant orthography regardless of locale.
Also added a unit test of feature accessibility element labels.
* [ios] Added tests for place, road accessibility values
* [ios] Announce one-way roads
A road feature’s accessibility value now indicates whether the road is a one-way road.
