Commit Graph

6855 Commits

Author SHA1 Message Date
John Firebaugh
1bdeddab2c [core] Fix subtle bug in OfflineDatabase with updated resources
SQLite REPLACE is *not* UPSERT. If a conflict occurs, it first deletes the existing row, then inserts a new row. This means that AUTOINCREMENT primary keys change. This will break foreign keys to that value, which we use.

Instead we must try an UPDATE, and fall back to an INSERT if the UPDATE changes zero rows.
2016-02-24 13:38:14 -08:00
John Firebaugh
65c06e6270 [core] status.requiredResourceCountIsIndeterminate ⇢ status.requiredResourceCountIsPrecise
Change the name and reverse the sense. Naming things in the positive is better than naming them in the negative.
2016-02-24 13:38:14 -08:00
John Firebaugh
5a6cee0dd0 [core] Add a descriptive comment about maximumCacheSize 2016-02-24 13:38:14 -08:00
Minh Nguyễn
d8c066ce0a [ios] Deleted redundant certificates
These certificates were copied to platform/default/resources/ in 4719b73ac7 but remained here, producing build warnings about duplicate build rules.
2016-02-24 12:24:08 -08:00
Jesse Bounds
f3ff38d125 [ios] Reduce async complexity 2016-02-24 09:32:26 -08:00
Minh Nguyễn
17f44d7bd9 Merge branch 'release-ios-v3.1.0' 2016-02-24 09:06:43 -08:00
Konstantin Käfer
662edea020 [ios] fix benchmark app 2016-02-24 16:49:05 +01:00
Konstantin Käfer
9557cd8d93 [core] use a store enum instead of RTTI
RTTI is pretty slow, in particular in iOS devices
2016-02-24 15:58:56 +01:00
Konstantin Käfer
f4bf961622 [core] fix uninitialized member variable 2016-02-24 15:57:54 +01:00
Tobrun
6679e7835d [android] #4094 - bring back view package 2016-02-24 15:40:50 +01:00
Thiago Marcos P. Santos
46557874ec [node] Add test that explicitly doesn call map.release()
Make sure mbgl.Map is not holding any references to the node's main
loop and thus preventing the node from exit.
2016-02-24 14:31:11 +02:00
Thiago Marcos P. Santos
63982e0010 Revert "[node] Destroy the RunLoop with the last Map object"
This reverts commit 3633fd7ebd.
2016-02-24 14:31:11 +02:00
Thiago Marcos P. Santos
931ac77af4 Revert "[core] libuv unref() not really needed"
This reverts commit 8a53c1a881.
2016-02-24 14:31:11 +02:00
Tobrun
72c2f5a95b [android] #4089 - remove mapboxmapsettings integration 2016-02-24 13:11:04 +01:00
Tobrun
896a62e589 [android] #3755 - fix package visibility issue with camera package, added javadoc and general cleanup 2016-02-24 13:06:56 +01:00
Tobrun
79609b7ff5 [android] #4083 - relax permissions check + renamed location services + code clean + javadoc 2016-02-24 13:05:13 +01:00
Tobrun
7b40cbcfd9 [android] #4038 - fix crash on polygons and polylines with empty points + formatting commit 2016-02-23 13:17:27 +01:00
Thiago Marcos P. Santos
18380708cd [android] Fix crash on HTTP 200 with no data 2016-02-23 00:21:57 +02:00
Thiago Marcos P. Santos
2b44c4b096 [tests] Add utests for HTTP 200 with no data
The implementation should return a valid empty string.
2016-02-23 00:21:57 +02:00
Minh Nguyễn
f74900e704 ios-v3.1.2 2016-02-22 10:47:09 -08:00
Minh Nguyễn
7bed2cebd2 [ios] Restored framework dependencies to static installation instructions
Backed out documentation about #4029 because it doesn’t apply when using a storyboard, and the installation instructions use a storyboard.
2016-02-22 10:44:49 -08:00
Minh Nguyễn
d836638407 [ios] Fixed zoom level for map feedback tool
The map feedback tool uses mapbox.js, so its zoom levels are one off the zoom levels used by Mapbox GL.
2016-02-22 09:44:43 -08:00
Tobrun
565f4eff63 [andriod] #4051 - add callback to move camera api 2016-02-22 11:10:12 +01:00
Tobrun
271d8df998 [android] #3688 - naming consistency bearing and direction 2016-02-22 10:58:03 +01:00
Tobrun
9061d004db [android] #4050 - expose style urls via public.xml 2016-02-22 10:38:32 +01:00
Tobrun
ab8441ebdc [android] #4057 - quick zoom fix 2016-02-22 09:18:38 +01:00
Thiago Marcos P. Santos
c51c0d5db2 [tests] Timer is not needed to keep the main loop alive
The loop will be alive until `.stop()` is called.
2016-02-22 09:21:51 +02:00
Bruno de Oliveira Abinader
59c70f7d7c [gyp] Check for gyp variable conditions on OS X 2016-02-21 17:34:34 +02:00
Bruno de Oliveira Abinader
0c57efb9a8 [gyp] Use variant compiler flags when needed 2016-02-21 17:34:15 +02:00
Bruno de Oliveira Abinader
bfd5ad3220 [gyp] Coverage only if BUILDTYPE=Debug and ENABLE_COVERAGE=1
Coverage compiler and linker flags are used only when (1) in debug build
and (2) with ENABLE_COVERAGE set to 1. Besides, because OS X's libtool
is unable to understand '--coverage', this linker flag is only used
genrating executable targets. Also, using 'link_settings' to specify
linker options and separate instructions for OSX and Linux.
2016-02-21 17:22:26 +02:00
Thiago Marcos P. Santos
8219d72135 [node] Not all tests were calling map.release()
Which prevents the test runner to close.
2016-02-20 18:16:33 +02:00
Thiago Marcos P. Santos
3633fd7ebd [node] Destroy the RunLoop with the last Map object
The last map object to get destroyed will also destroy
the RunLoop (which will also destroy the AsyncTask).

This will clear any reference to the Node default main
loop and let it close.

Downside is that we need to make sure we are always calling
`map.release()`.
2016-02-20 13:33:13 +02:00
Thiago Marcos P. Santos
8a53c1a881 [core] libuv unref() not really needed
The run loop will be kept alive because it has an `AsyncTask`. We
also can simple stop the loop with `uv_stop()`.

The `RunLoop` is still gonna be the last object to be destroyed
because it is the first object to be created in the thread, so
by design it won't outlive `Timer`s and `AsyncTask`s.

This patch won't change the current behavior, will just make
the code simpler.
2016-02-20 13:33:13 +02:00
Bruno de Oliveira Abinader
1dbfbfe7e3 [tests] Upload coverage reports to coveralls.io 2016-02-20 11:43:42 +02:00
John Firebaugh
675a628aa2 [node] Fix handling of response callback with no arguments; add test 2016-02-19 17:25:57 -08:00
John Firebaugh
f7f89cb44a [build] make clean shouldn't delete Xcode projects
Fixes #2493
2016-02-19 17:13:50 -08:00
John Firebaugh
a27c9a4680 [build] Remove obsolete directories from make clean 2016-02-19 17:13:50 -08:00
Brad Leege
9d3cc6f647 [android] #3889 - Adding detection of Scroll / Pan for DragEnd analytic 2016-02-19 12:40:08 -06:00
Brad Leege
5ef166269a [android] #3889 - Adding Pitch Start 2016-02-19 12:40:08 -06:00
Brad Leege
6d8befe401 [android] #3889 - Adding Rotation Start. 2016-02-19 12:40:08 -06:00
Brad Leege
5e5c7ed71f [android] #3889 - Adding Pinch Start. Refactoring trackGestureEvent to accept raw x and y coordinates. 2016-02-19 12:40:08 -06:00
Brad Leege
d9216f9831 [android] #3889 - Adding Pan Start / Fling event 2016-02-19 12:40:08 -06:00
Brad Leege
e0df0971cb [android] #3889 - Adding Quick Zoom event 2016-02-19 12:40:08 -06:00
Brad Leege
92c5a05f59 [android] #3889 - Adding Double Tap and Two Finger Tap gesture tracking 2016-02-19 12:40:08 -06:00
Brad Leege
425d718e42 [android] #3889 - Building trackGestureEvent() method and using it initially for Single Tap gesture 2016-02-19 12:40:07 -06:00
Jason Wray
15b9f3171a [ios] Refactor MGLMapView's location services
- Pause location services when the app goes to sleep; address iOS 8 blue bar issue.
- Only ask for location permissions if not already granted/denied.
- Cleanup usage of `.isDormant` → `.dormant`

Partially addresses #2945, for which a full and complete fix waits until #4030.
2016-02-19 13:14:54 -05:00
John Firebaugh
e4b2ea0982 [ios, osx] Don't delete a mutex with an active lock
The lock is in place to enforce that `async` is not accessed if the request has been, cancelled. Therefore it's not necessary to hold the lock beyond setting cancelled to true, and in fact it's unsafe to so: if this is the last remaining shared reference, `delete this` will destroy the mutex. If the lock was held, it would then be orphaned.
2016-02-19 10:11:27 -08:00
Bruno de Oliveira Abinader
6792d78952 [tests] Use ENABLE_COVERAGE=1 envvar to enable coverage
This detaches coverage data collection from typical debug build.
2016-02-19 17:40:30 +02:00
Tobrun
6a2d910ccd [android] #4040 - disable resource prefix 2016-02-19 15:53:18 +01:00
Tom MacWright
d697028029 Hit missed lines in equality tests 2016-02-19 15:26:44 +01:00