Merge Sprite loading notifications

Because they are pretty much the same thing.
This commit is contained in:
Thiago Marcos P. Santos
2015-07-09 14:13:42 +03:00
parent efa7dad89c
commit f64ba78910
4 changed files with 6 additions and 10 deletions

View File

@@ -86,9 +86,10 @@ Sprite::~Sprite() {
void Sprite::emitSpriteLoadedIfComplete() {
assert(loader);
if (loader->loadedImage && loader->loadedJSON && observer) {
observer->onSpriteDataLoaded(std::move(loader->data));
std::unique_ptr<Data> data(std::move(loader->data));
loader.reset();
observer->onSpriteLoaded();
observer->onSpriteLoaded(std::move(data));
}
}

View File

@@ -27,8 +27,7 @@ public:
public:
virtual ~Observer() = default;
virtual void onSpriteDataLoaded(std::unique_ptr<Data>) = 0;
virtual void onSpriteLoaded() = 0;
virtual void onSpriteLoaded(std::unique_ptr<Data>) = 0;
virtual void onSpriteLoadingFailed(std::exception_ptr error) = 0;
};

View File

@@ -191,14 +191,11 @@ void Style::onTileLoadingFailed(std::exception_ptr error) {
emitResourceLoadingFailed(error);
}
void Style::onSpriteDataLoaded(std::unique_ptr<Sprite::Data> spriteData) {
void Style::onSpriteLoaded(std::unique_ptr<Sprite::Data> spriteData) {
// Add all sprite images to the SpriteStore object
spriteStore->setSprites(parseSprite(spriteData->image, spriteData->json));
}
void Style::onSpriteLoaded() {
shouldReparsePartialTiles = true;
emitTileDataChanged();
}

View File

@@ -89,8 +89,7 @@ private:
void onTileLoadingFailed(std::exception_ptr error) override;
// Sprite::Observer implementation.
void onSpriteDataLoaded(std::unique_ptr<Sprite::Data>) override;
void onSpriteLoaded() override;
void onSpriteLoaded(std::unique_ptr<Sprite::Data>) override;
void onSpriteLoadingFailed(std::exception_ptr error) override;
void emitTileDataChanged();