tei/MapLibreParticleLab
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed NSMutableString leak

Browse Source 
Fixed analyzer warnings in http-nsurl target, which is MRR rather than ARC.
This commit is contained in:
Minh Nguyễn
2015-05-05 11:33:39 -04:00
parent fab65e75d0
commit ec241d17ff
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
platform/darwin/http_request_nsurl.mm
View File

@@ -153,7 +153,7 @@ void HTTPRequest::start() {
@autoreleasepool {
NSMutableString *url = [[NSMutableString alloc] initWithString:@(resource.url.c_str())];
NSMutableString *url = [NSMutableString stringWithString:@(resource.url.c_str())];
if ([[NSUserDefaults standardUserDefaults] objectForKey:@"mapbox_metrics_disabled"] == nil) {
if ([url rangeOfString:@"?"].location == NSNotFound) {
[url appendString:@"?"];
@@ -163,8 +163,7 @@ void HTTPRequest::start() {
[url appendString:@"events=true"];
}
NSMutableURLRequest *req = [[NSMutableURLRequest alloc]
initWithURL:[NSURL URLWithString:url]];
NSMutableURLRequest *req = [NSMutableURLRequest requestWithURL:[NSURL URLWithString:url]];
if (existingResponse) {
if (!existingResponse->etag.empty()) {
[req addValue:@(existingResponse->etag.c_str()) forHTTPHeaderField:@"If-None-Match"];
@@ -179,7 +178,6 @@ void HTTPRequest::start() {
task = [context->session dataTaskWithRequest:req
completionHandler:^(NSData *data, NSURLResponse *res,
NSError *error) { handleResult(data, res, error); }];
[req release];
[task retain];
[task resume];
}