Add end-of-file-fixer pre-commit hook (#3176)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

.bazelignore

@@ -1,4 +1,4 @@
 bazel-bin
 bazel-out
 bazel-testlogs
-node_modules
+node_modules

.bazelrc

@@ -7,4 +7,4 @@ common --incompatible_disallow_empty_glob
 
 coverage --experimental_ui_max_stdouterr_bytes=10485760
 
-common:macos --linkopt=-L/opt/homebrew/lib
+common:macos --linkopt=-L/opt/homebrew/lib

.github/ISSUE_TEMPLATE/config.yml

@@ -6,4 +6,3 @@ contact_links:
   - name: "💬 Chat with us on Slack"
     url: https://slack.openstreetmap.us/
     about: "Join #maplibre-native on the Open Street Map Slack"
-

.github/actions/android-build-and-upload-render-test/action.yml

@@ -22,4 +22,4 @@ runs:
         if-no-files-found: error
         path: |
           ./render-test/android/RenderTestsApp-${{ inputs.flavor }}.apk
-          ./render-test/android/RenderTests-${{ inputs.flavor }}.apk
+          ./render-test/android/RenderTests-${{ inputs.flavor }}.apk

.github/actions/get-pr-number/action.yml

@@ -16,4 +16,4 @@ runs:
 
     - id: cat
       run: echo pr-number="$(cat ./pr_number)" >> $GITHUB_OUTPUT
-      shell: bash
+      shell: bash

.github/actions/save-pr-number/action.yml

@@ -13,4 +13,4 @@ runs:
         uses: actions/upload-artifact@v3
         with:
           name: pr-number
-          path: ./pr_number
+          path: ./pr_number

.github/changed-files.yml

@@ -65,4 +65,4 @@ android:
   - 'test/**'
   - 'vendor/**'
   - '.gitmodules'
-  - '!**/*.md'
+  - '!**/*.md'

.github/renovate.json

@@ -1,3 +1,3 @@
 {
   "enabledManagers": ["gradle-wrapper", "bazel"]
-}
+}

.nvmrc

@@ -1 +1 @@
-23
+23

.pre-commit-config.yaml

@@ -2,8 +2,9 @@ repos:
 -   repo: https://github.com/pre-commit/pre-commit-hooks
     rev: v5.0.0
     hooks:
-    -   id: check-yaml
-        args: [--allow-multiple-documents, --unsafe]
+    - id: check-yaml
+      args: [--allow-multiple-documents, --unsafe]
+    - id: end-of-file-fixer
 - repo: https://github.com/pre-commit/mirrors-clang-format
   rev: v19.1.4
   hooks:

LICENSES.core.md

@@ -633,4 +633,3 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 ```
 
 ---
-

benchmark/android/.gitignore

@@ -1 +1 @@
-.gradle/
+.gradle/

benchmark/android/settings.gradle

@@ -1,2 +1 @@
 include ':app'
-

benchmark/fixtures/api/style.json

@@ -6511,4 +6511,4 @@
     "maptiler:copyright": "This style was generated on MapTiler Cloud. Usage outside of MapTiler Cloud requires valid OpenMapTiles Production Package: https://openmaptiles.com/production-package/ -- please contact us.",
     "openmaptiles:version": "3.x"
   }
-}
+}

benchmark/fixtures/api/style_formatted_labels.json

@@ -6511,4 +6511,4 @@
     "maptiler:copyright": "This style was generated on MapTiler Cloud. Usage outside of MapTiler Cloud requires valid OpenMapTiles Production Package: https://openmaptiles.com/production-package/ -- please contact us.",
     "openmaptiles:version": "3.x"
   }
-}
+}

benchmark/ios/Info.plist

@@ -59,4 +59,4 @@
     <true/>
   </dict>
 </dict>
-</plist>
+</plist>

bin/CMakeLists.txt

@@ -59,4 +59,4 @@ install(TARGETS mbgl-offline mbgl-render RUNTIME DESTINATION bin)
 
 if(MLN_WITH_OPENGL)
     target_compile_definitions(mbgl-render PRIVATE "MLN_RENDER_BACKEND_OPENGL=1")
-endif()
+endif()

design-proposals/2022-09-02-kotlin.md

@@ -24,4 +24,4 @@ Full backward compatibility
   
 
 ## Rejected Alternatives
-The alternative is that we go forward with java, meaning that we effectively should port our existing kotlin code to java, which I can't find evidence of any project ever attempting.
+The alternative is that we go forward with java, meaning that we effectively should port our existing kotlin code to java, which I can't find evidence of any project ever attempting.

design-proposals/2023-06-17-android-annotations.md

@@ -278,4 +278,4 @@ One remaining task is to consider supporting an `InfoWindow`-like feature with o
 
 ## Rejected Alternatives
 
-* Moving the existing code to `maplibre-native` without further considerations leads to chaos, because it would leave users with the choice between two rather mediocre APIs – one being mediocre by design, the other because it is deprecated. Additionally, it would leave the codebase with two confusingly similar codebases. With this proposal, we can offer one new and clean API, and redirect calls to the old API to the new one.
+* Moving the existing code to `maplibre-native` without further considerations leads to chaos, because it would leave users with the choice between two rather mediocre APIs – one being mediocre by design, the other because it is deprecated. Additionally, it would leave the codebase with two confusingly similar codebases. With this proposal, we can offer one new and clean API, and redirect calls to the old API to the new one.

design-proposals/2023-11-08-complex-animatable-interactive-annotations.md

@@ -59,4 +59,3 @@ No migration plan needed unless we introduce a Phase 3 to cleanup existing platf
 Historically the gap has been somewhat filled by the different platform layers. On the iOS platform there is a MapKit style “AnnotationDelegate”, which in some cases draws directly to the mglMap core and in others will add views as subviews to the MGLMapView. On Android there is a whole proposal for updating the Annotations API (design-proposals/2023-06-17-android-annotations.md). Note: This proposal is for purely additive code and we do not plan to change any of these existing systems at this time. Those who have attempted to make complex map applications using these workarounds quickly run into performance issues and other problems like incompatibility with clustering or label collisions.
 
 If one were to attempt to create such a system using SymbolLayers, they will quickly find that they need to build out a whole system to handle touch events (usually involving querying a screen rect for map features). They will find that if they want to draw many different high resolution images they now need to deal with manually adding images to the stylesheet and the performance implications of doing so. They will also find that any attempts at animating the content can cause full layout recalculations of the map and will rarely animate as expected.
-

docs/.gitignore

@@ -1,2 +1,2 @@
 book
-*.bkp
+*.bkp

docs/mdbook/diff.css

@@ -369,4 +369,4 @@
 
 .d2h-moved-tag {
     border: 1px solid #3572b0
-}
+}

docs/mdbook/src/android/README.md

@@ -55,4 +55,4 @@ $ ./gradlew formatKotlin
 
 ## Profiling
 
-See [Tracy Profiling](/profiling/tracy-profiling.md) to understand how Tracy can be used for profiling.
+See [Tracy Profiling](/profiling/tracy-profiling.md) to understand how Tracy can be used for profiling.

docs/mdbook/src/android/android-documentation.md

@@ -46,4 +46,4 @@ Static assets are ideally uploaded to the [MapLibre Native S3 Bucket](https://ma
 
 Please open an issue with the ARN of your AWS account to get upload privileges.
 
-You can use the macro `{{ s3_url("filename.example") }}` which will use a CDN instead of linking to the S3 bucket directly.
+You can use the macro `{{ s3_url("filename.example") }}` which will use a CDN instead of linking to the S3 bucket directly.

docs/mdbook/src/android/benchmark.md

@@ -99,4 +99,4 @@ To run the benchmarks (for Android) include the following line on a PR comment:
 !benchmark android
 ```
 
-A file with the benchmark results will be added to the workflow summary, which you can compare with the previous results in the bucket.
+A file with the benchmark results will be added to the workflow summary, which you can compare with the previous results in the bucket.

docs/mdbook/src/ios/README.md

@@ -75,4 +75,4 @@ You can also build targets from the command line. For example, if you want to bu
 
 ## Swift App
 
-There is also an example app built with Swift instead of Objective-C. The target is called `MapLibreApp` and the source code lives in `platform/ios/app-swift`.
+There is also an example app built with Swift instead of Objective-C. The target is called `MapLibreApp` and the source code lives in `platform/ios/app-swift`.

docs/mdbook/src/ios/ios-documentation.md

@@ -50,4 +50,4 @@ Then the code block will be updated when you run:
 
 ```sh
 node scripts/update-ios-examples.mjs
-```
+```

docs/mdbook/src/ios/ios-tests.md

@@ -15,4 +15,4 @@ to get the data directory of the render test app. This allows you to inspect tes
 
 ## C++ Unit Tests
 
-Run the tests from the `CppUnitTests` target in Xcode to run the C++ Unit Tests on iOS.
+Run the tests from the `CppUnitTests` target in Xcode to run the C++ Unit Tests on iOS.

docs/mdbook/src/profiling/README.md

@@ -1,3 +1,3 @@
 # MapLibre Native profiling
 
-MabLibre Native integrates [Tracy profiler](https://github.com/wolfpld/tracy) which offers an easy way to understand and optimize your application's CPU and GPU performance
+MabLibre Native integrates [Tracy profiler](https://github.com/wolfpld/tracy) which offers an easy way to understand and optimize your application's CPU and GPU performance

docs/mdbook/src/rust.md

@@ -64,4 +64,4 @@ To create a new module:
           "src/mbgl/util/color.cpp",
       ],
     })
-    ```
+    ```

expression-test/expression_test_parser.hpp

@@ -95,4 +95,4 @@ std::unique_ptr<style::expression::Expression> parseExpression(const JSValue&,
                                                                TestResult&);
 std::unique_ptr<style::expression::Expression> parseExpression(const std::optional<Value>&,
                                                                std::optional<PropertySpec>&,
-                                                               TestResult&);
+                                                               TestResult&);

include/mbgl/util/bitmask_operations.hpp

@@ -29,4 +29,4 @@ constexpr Enum operator~(Enum value) {
     return Enum(~mbgl::underlying_type(value));
 }
 
-} // namespace mbgl
+} // namespace mbgl

include/mbgl/util/monotonic_timer.hpp

@@ -19,4 +19,4 @@ public:
 };
 
 } // namespace util
-} // namespace mbgl
+} // namespace mbgl

metrics/android-render-test-runner/location_indicator/dateline/metrics.json

@@ -44,4 +44,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/location_indicator/default/metrics.json

@@ -44,4 +44,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/location_indicator/no_radius_border/metrics.json

@@ -44,4 +44,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/location_indicator/no_radius_fill/metrics.json

@@ -44,4 +44,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/location_indicator/no_textures/metrics.json

@@ -44,4 +44,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/location_indicator/one_texture/metrics.json

@@ -44,4 +44,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/location_indicator/rotated/metrics.json

@@ -44,4 +44,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/location_indicator/tilted/metrics.json

@@ -44,4 +44,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/location_indicator/tilted_texture_shift/metrics.json

@@ -44,4 +44,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/location_indicator/tilted_texture_shift_bottom_left/metrics.json

@@ -44,4 +44,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/location_indicator/tilted_texture_shift_bottom_right/metrics.json

@@ -44,4 +44,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/location_indicator/tilted_texture_shift_top_left/metrics.json

@@ -44,4 +44,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/location_indicator/tilted_texture_shift_top_right/metrics.json

@@ -44,4 +44,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/location_indicator/two_textures/metrics.json

@@ -44,4 +44,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/background-color/colorSpace-lab/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/background-color/default/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/background-color/function/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/background-color/literal/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/background-opacity/color/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/background-opacity/image/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/background-opacity/overlay/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/background-pattern/@2x/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/background-pattern/literal/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/background-pattern/missing/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/background-pattern/pitch/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/background-pattern/rotated/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/background-pattern/zoomed/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/background-visibility/none/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/background-visibility/visible/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/basic-v9/z0-narrow-y/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/basic-v9/z0-wide-x/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/basic-v9/z0/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/bright-v9/z0/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-blur/blending/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-blur/default/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-blur/function/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-blur/literal-stroke/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-blur/literal/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-blur/property-function/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-blur/zoom-and-property-function/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-color/default/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-color/function/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-color/literal/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-color/property-function/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-color/zoom-and-property-function/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-geometry/linestring/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-geometry/multilinestring/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-geometry/multipoint/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-geometry/multipolygon/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-geometry/point/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-geometry/polygon/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-opacity/blending/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-opacity/default/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-opacity/function/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-opacity/literal/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-opacity/property-function/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-opacity/zoom-and-property-function/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-pitch-alignment/map-scale-map/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-pitch-alignment/map-scale-viewport/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-pitch-alignment/viewport-scale-map/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-pitch-alignment/viewport-scale-viewport/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-pitch-scale/default/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-pitch-scale/map/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-pitch-scale/viewport/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-radius/antimeridian/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-radius/default/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}

metrics/android-render-test-runner/render-tests/circle-radius/function/metrics.json

@@ -32,4 +32,4 @@
             ]
         ]
     ]
-}
+}