[core] Default fade duration is now a constant

include/mbgl/map/map.hpp

@@ -72,9 +72,6 @@ public:
     bool hasClass(const std::string&) const;
     std::vector<std::string> getClasses() const;
 
-    void setDefaultFadeDuration(const Duration&);
-    Duration getDefaultFadeDuration() const;
-
     void setStyleURL(const std::string& url);
     void setStyleJSON(const std::string& json, const std::string& base = "");
     std::string getStyleURL() const;

include/mbgl/util/constants.hpp

@@ -38,6 +38,7 @@ constexpr double MAX_ZOOM = 25.5;
 
 constexpr uint64_t DEFAULT_MAX_CACHE_SIZE = 50 * 1024 * 1024;;
 
+constexpr Duration DEFAULT_FADE_DURATION = Milliseconds(300);
 constexpr SystemDuration CLOCK_SKEW_RETRY_TIMEOUT = Seconds(30);
 
 } // namespace util

src/mbgl/map/map.cpp

@@ -540,15 +540,6 @@ std::vector<std::string> Map::getClasses() const {
     return context->invokeSync<std::vector<std::string>>(&MapContext::getClasses);
 }
 
-void Map::setDefaultFadeDuration(const Duration& duration) {
-    data->setDefaultFadeDuration(duration);
-    update(Update::Classes);
-}
-
-Duration Map::getDefaultFadeDuration() const {
-    return data->getDefaultFadeDuration();
-}
-
 void Map::setSourceTileCacheSize(size_t size) {
     context->invoke(&MapContext::setSourceTileCacheSize, size);
 }

src/mbgl/map/map_data.hpp

@@ -24,8 +24,7 @@ public:
         , contextMode(contextMode_)
         , pixelRatio(pixelRatio_)
         , annotationManager(pixelRatio)
-        , animationTime(Duration::zero())
-        , defaultFadeDuration(mode_ == MapMode::Continuous ? Milliseconds(300) : Duration::zero()) {
+        , animationTime(Duration::zero()) {
         assert(pixelRatio > 0);
     }
 
@@ -63,18 +62,6 @@ public:
         animationTime = timePoint.time_since_epoch();
     };
 
-    inline Duration getDefaultFadeDuration() const {
-        return defaultFadeDuration;
-    }
-
-    inline void setDefaultFadeDuration(const Duration& duration) {
-        if (mode == MapMode::Still) {
-            return;
-        }
-
-        defaultFadeDuration = duration;
-    }
-
     util::exclusive<AnnotationManager> getAnnotationManager() {
         return util::exclusive<AnnotationManager>(
             &annotationManager,
@@ -92,7 +79,6 @@ private:
 
     std::atomic<MapDebugOptions> debugOptions { MapDebugOptions::NoDebug };
     std::atomic<Duration> animationTime;
-    std::atomic<Duration> defaultFadeDuration;
 
 // TODO: make private
 public:

src/mbgl/renderer/painter.cpp

@@ -72,7 +72,7 @@ Painter::Painter(MapData& data_, TransformState& state_, gl::GLObjectStore& glOb
 Painter::~Painter() = default;
 
 bool Painter::needsAnimation() const {
-    return frameHistory.needsAnimation(data.getDefaultFadeDuration());
+    return frameHistory.needsAnimation(util::DEFAULT_FADE_DURATION);
 }
 
 void Painter::prepareTile(const Tile& tile) {

src/mbgl/renderer/painter_symbol.cpp

@@ -62,7 +62,7 @@ void Painter::renderSDF(SymbolBucket &bucket,
     sdfShader.u_zoom = (state.getZoom() - zoomAdjust) * 10; // current zoom level
 
     if (data.mode == MapMode::Continuous) {
-        FadeProperties f = frameHistory.getFadeProperties(data.getAnimationTime(), data.getDefaultFadeDuration());
+        FadeProperties f = frameHistory.getFadeProperties(data.getAnimationTime(), util::DEFAULT_FADE_DURATION);
         sdfShader.u_fadedist = f.fadedist * 10;
         sdfShader.u_minfadezoom = std::floor(f.minfadezoom * 10);
         sdfShader.u_maxfadezoom = std::floor(f.maxfadezoom * 10);

src/mbgl/style/style.cpp

@@ -207,10 +207,12 @@ void Style::recalculate(float z) {
 
     zoomHistory.update(z, data.getAnimationTime());
 
-    StyleCalculationParameters parameters(z,
-                                          data.getAnimationTime(),
-                                          zoomHistory,
-                                          data.getDefaultFadeDuration());
+    const StyleCalculationParameters parameters {
+        z,
+        data.getAnimationTime(),
+        zoomHistory,
+        data.mode == MapMode::Continuous ? util::DEFAULT_FADE_DURATION : Duration::zero()
+    };
 
     hasPendingTransitions = false;
     for (const auto& layer : layers) {