[node] don't dispose parent module in NodeLog destructor

This commit is contained in:
Mike Morris
2016-04-07 17:05:13 -04:00
parent 89db01fef0
commit c59b5fb5e6
3 changed files with 2 additions and 2 deletions

View File

@@ -52,7 +52,6 @@ NodeLogObserver::NodeLogObserver(v8::Local<v8::Object> target)
NodeLogObserver::~NodeLogObserver() {
queue->stop();
module.Reset();
}
bool NodeLogObserver::onRecord(mbgl::EventSeverity severity, mbgl::Event event, int64_t code, const std::string &text) {

View File

@@ -77,7 +77,7 @@ void RegisterModule(v8::Local<v8::Object> target, v8::Local<v8::Object> module)
Nan::Get(EventEmitter, Nan::New("prototype").ToLocalChecked()).ToLocalChecked());
Nan::CallAsFunction(EventEmitter, target, 0, nullptr);
mbgl::Log::setObserver(std::make_unique<node_mbgl::NodeLogObserver>(target->ToObject()));
mbgl::Log::setObserver(std::make_unique<node_mbgl::NodeLogObserver>(target));
}
NODE_MODULE(mapbox_gl_native, RegisterModule)

View File

@@ -0,0 +1 @@
var mbgl = require('../../../../lib/mapbox-gl-native');