deprecate MapboxMap#cycleDebugActive

This commit is contained in:
Łukasz Paczos
2019-12-16 19:18:43 +01:00
parent e274d6e28e
commit c4782e7a2d
5 changed files with 6 additions and 16 deletions

View File

@@ -5,6 +5,7 @@ Mapbox welcomes participation and contributions from everyone. If you'd like to
## master
### Bug fixes
- Fixed a crash caused by an unintentional minification of the `LocalGlyphRasterizer`. [#102](https://github.com/mapbox/mapbox-gl-native-android/pull/102)
- Deprecated `MapboxMap#cycleDebugOptions` and fixed an `UnsatisfiedLinkError` when accessed. [#104](https://github.com/mapbox/mapbox-gl-native-android/pull/104)
## 8.6.0-beta.1 - December 6, 2019
[Changes](https://github.com/mapbox/mapbox-gl-native/compare/android-v8.6.0-alpha.2...android-v8.6.0-beta.1) since [Mapbox Maps SDK for Android v8.6.0-alpha.2](https://github.com/mapbox/mapbox-gl-native/releases/tag/android-v8.6.0-alpha.2):

View File

@@ -775,10 +775,12 @@ public final class MapboxMap {
* any map debug options enabled or disabled.
*
* @see #isDebugActive()
* @deprecated use {@link #setDebugActive(boolean)}
*/
@Deprecated
public void cycleDebugOptions() {
nativeMapView.cycleDebugOptions();
this.debugActive = nativeMapView.getDebug();
this.debugActive = !nativeMapView.getDebug();
nativeMapView.setDebug(debugActive);
}
//

View File

@@ -209,8 +209,6 @@ interface NativeMap {
boolean getDebug();
void cycleDebugOptions();
void setReachability(boolean status);
void setApiBaseUrl(String baseUrl);

View File

@@ -583,14 +583,6 @@ final class NativeMapView implements NativeMap {
nativeSetDebug(debug);
}
@Override
public void cycleDebugOptions() {
if (checkState("cycleDebugOptions")) {
return;
}
nativeCycleDebugOptions();
}
@Override
public boolean getDebug() {
if (checkState("getDebug")) {
@@ -1263,9 +1255,6 @@ final class NativeMapView implements NativeMap {
@Keep
private native void nativeSetDebug(boolean debug);
@Keep
private native void nativeCycleDebugOptions();
@Keep
private native boolean nativeGetDebug();

View File

@@ -164,8 +164,8 @@ public class DebugModeActivity extends AppCompatActivity implements OnMapReadyCa
FloatingActionButton fabDebug = findViewById(R.id.fabDebug);
fabDebug.setOnClickListener(view -> {
if (mapboxMap != null) {
mapboxMap.setDebugActive(!mapboxMap.isDebugActive());
Timber.d("Debug FAB: isDebug Active? %s", mapboxMap.isDebugActive());
mapboxMap.cycleDebugOptions();
}
});
}