tei/MapLibreParticleLab
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[core] Remove support for setting minimum and maximum pitch

Browse Source 
Support for limiting pitch was introduced in commit c4fc89977b ([core]
Added {set,get}{Min,Max}Pitch) in 2017 but was never exposed by the
platform SDKs. Simplify the Map interface by removing this unused
feature.

v2: Add util::PITCH_MIN
This commit is contained in:
Ander Conselvan de Oliveira
2019-03-07 15:43:06 +02:00
parent dba40c64ea
commit a73cc9d8e3
8 changed files with 3 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
test/map/transform.test.cpp
View File

@@ -761,22 +761,3 @@ TEST(Transform, LatLngBounds) {
transform.moveBy(ScreenCoordinate { 500, 0 });
ASSERT_DOUBLE_EQ(transform.getLatLng().longitude(), 120.0);
}
TEST(Transform, PitchBounds) {
Transform transform;
transform.resize({ 1000, 1000 });
transform.jumpTo(CameraOptions().withCenter(LatLng()).withZoom(transform.getState().getMaxZoom()));
ASSERT_DOUBLE_EQ(transform.getState().getPitch() * util::RAD2DEG, 0.0);
ASSERT_DOUBLE_EQ(transform.getState().getMinPitch() * util::RAD2DEG, 0.0);
ASSERT_DOUBLE_EQ(transform.getState().getMaxPitch() * util::RAD2DEG, 60.0);
transform.setMinPitch(45.0 * util::DEG2RAD);
transform.jumpTo(CameraOptions().withPitch(0));
ASSERT_NEAR(transform.getState().getPitch() * util::RAD2DEG, 45.0, 1e-5);
transform.setMaxPitch(55.0 * util::DEG2RAD);
transform.jumpTo(CameraOptions().withPitch(60.0));
ASSERT_NEAR(transform.getState().getPitch() * util::RAD2DEG, 55.0, 1e-5);
}