tei/MapLibreParticleLab
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[core] Remove support for setting minimum and maximum pitch

Browse Source 
Support for limiting pitch was introduced in commit c4fc89977b ([core]
Added {set,get}{Min,Max}Pitch) in 2017 but was never exposed by the
platform SDKs. Simplify the Map interface by removing this unused
feature.

v2: Add util::PITCH_MIN
This commit is contained in:
Ander Conselvan de Oliveira
2019-03-07 15:43:06 +02:00
parent dba40c64ea
commit a73cc9d8e3
8 changed files with 3 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/mbgl/map/transform.cpp
View File

@@ -116,7 +116,7 @@ void Transform::easeTo(const CameraOptions& camera, const AnimationOptions& anim
// Constrain camera options.
zoom = util::clamp(zoom, state.getMinZoom(), state.getMaxZoom());
const double scale = state.zoomScale(zoom);
pitch = util::clamp(pitch, state.min_pitch, state.max_pitch);
pitch = util::clamp(pitch, util::PITCH_MIN, util::PITCH_MAX);
// Minimize rotation by taking the shorter path around the circle.
bearing = _normalizeAngle(bearing, state.bearing);
@@ -181,7 +181,7 @@ void Transform::flyTo(const CameraOptions &camera, const AnimationOptions &anima
// Constrain camera options.
zoom = util::clamp(zoom, state.getMinZoom(), state.getMaxZoom());
pitch = util::clamp(pitch, state.min_pitch, state.max_pitch);
pitch = util::clamp(pitch, util::PITCH_MIN, util::PITCH_MAX);
// Minimize rotation by taking the shorter path around the circle.
bearing = _normalizeAngle(bearing, state.bearing);
@@ -361,16 +361,6 @@ void Transform::setMaxZoom(const double maxZoom) {
state.setMaxZoom(maxZoom);
}
void Transform::setMinPitch(double minPitch) {
if (std::isnan(minPitch)) return;
state.setMinPitch(minPitch);
}
void Transform::setMaxPitch(double maxPitch) {
if (std::isnan(maxPitch)) return;
state.setMaxPitch(maxPitch);
}
#pragma mark - Bearing
void Transform::rotateBy(const ScreenCoordinate& first, const ScreenCoordinate& second, const AnimationOptions& animation) {