Drawable Renderer (#1570), warnings

This commit is contained in:
Tim Sylvester
2023-05-08 09:01:26 -07:00
committed by Bart Louwers
parent 041acbaf0e
commit 7e26cc9710

View File

@@ -224,13 +224,13 @@ void RenderBackgroundLayer::update(const int32_t layerIndex,
const auto& evaluated = getEvaluated<BackgroundLayerProperties>(evaluatedProperties);
// TODO: If background is solid, we can skip drawables and rely on the clear color
const auto passes = evaluated.get<style::BackgroundOpacity>() == 0.0f ? RenderPass::None
: (!unevaluated.get<style::BackgroundPattern>().isUndefined() ||
evaluated.get<style::BackgroundOpacity>() < 1.0f ||
evaluated.get<style::BackgroundColor>().a < 1.0f)
? RenderPass::Translucent
: RenderPass::Opaque |
RenderPass::Translucent; // evaluated based on opaquePassCutoff in render()
const auto drawPasses = evaluated.get<style::BackgroundOpacity>() == 0.0f ? RenderPass::None
: (!unevaluated.get<style::BackgroundPattern>().isUndefined() ||
evaluated.get<style::BackgroundOpacity>() < 1.0f ||
evaluated.get<style::BackgroundColor>().a < 1.0f)
? RenderPass::Translucent
: RenderPass::Opaque |
RenderPass::Translucent; // evaluated based on opaquePassCutoff in render()
// unevaluated.hasTransition();
// getCrossfade<BackgroundLayerProperties>(evaluatedProperties).t != 1;
@@ -308,7 +308,7 @@ void RenderBackgroundLayer::update(const int32_t layerIndex,
// We actually need to build things, so set up a builder if we haven't already
if (!builder) {
builder = context.createDrawableBuilder("background");
builder->setRenderPass(passes);
builder->setRenderPass(drawPasses);
builder->setShader(shader);
builder->addTweaker(context.createDrawableTweaker());
builder->setColor(*color);