Eliminate warnings

common.gypi

@@ -7,7 +7,7 @@
       'GCC_VERSION': 'com.apple.compilers.llvm.clang.1_0',
       'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',
       'GCC_ENABLE_CPP_RTTI':'YES',
-      'OTHER_CPLUSPLUSFLAGS': [ '-Wall', '-Wextra' ],
+      'OTHER_CPLUSPLUSFLAGS': [ '-Wall', '-Wextra', '-Wno-variadic-macros' ],
       'GCC_WARN_PEDANTIC': 'YES',
       'GCC_WARN_UNINITIALIZED_AUTOS': 'YES_AGGRESSIVE'
     },

common/glfw_view.cpp

@@ -202,7 +202,7 @@ void GLFWView::swap() {
     glfwSetWindowTitle(window, title.c_str());
 }
 
-void GLFWView::notify_map_change(mbgl::MapChange change, mbgl::timestamp delay) {
+void GLFWView::notify_map_change(mbgl::MapChange /*change*/, mbgl::timestamp /*delay*/) {
     // no-op
 }
 

include/mbgl/platform/event.hpp

@@ -68,6 +68,7 @@ constexpr EventSeverity disabledEventSeverities[] = {
 
 
 constexpr Event disabledEvents[] = {
+    Event(-1) // Avoid zero size array
 };
 
 constexpr EventPermutation disabledEventPermutations[] = {

macosx/main.mm

@@ -15,6 +15,8 @@
 
 - (void)handleGetURLEvent:(NSAppleEventDescriptor *)event
            withReplyEvent:(NSAppleEventDescriptor *)replyEvent {
+    (void)replyEvent;
+
     NSString* urlString = [[event paramDescriptorForKeyword:keyDirectObject] stringValue];
     NSURL *url = [NSURL URLWithString:urlString];
     NSMutableDictionary *params = [[NSMutableDictionary alloc] init];

src/geometry/interpolate.cpp

@@ -16,7 +16,7 @@ const std::array<std::vector<float>, 4> minScaleArrays = {{
 
 
 Anchors interpolate(const std::vector<Coordinate> &vertices, float spacing,
-                    const float minScale, float maxScale, const float tilePixelRatio,
+                    const float /*minScale*/, float maxScale, const float tilePixelRatio,
                     const int start) {
 
     maxScale = std::round(std::fmax(std::fmin(8.0f, maxScale / 2.0f), 1.0f));

src/map/map.cpp

@@ -169,7 +169,7 @@ void Map::render(uv_async_t *async) {
 void Map::terminate(uv_async_t *async) {
     // Closes all open handles on the loop. This means that the loop will automatically terminate.
     uv_loop_t *loop = static_cast<uv_loop_t *>(async->data);
-    uv_walk(loop, [](uv_handle_t *handle, void *arg) {
+    uv_walk(loop, [](uv_handle_t *handle, void */*arg*/) {
         if (!uv_is_closing(handle)) {
             uv_close(handle, NULL);
         }

src/map/raster_tile_data.cpp

@@ -29,6 +29,6 @@ void RasterTileData::render(Painter &painter, std::shared_ptr<StyleLayer> layer_
     bucket.render(painter, layer_desc, id);
 }
 
-bool RasterTileData::hasData(std::shared_ptr<StyleLayer> layer_desc) const {
+bool RasterTileData::hasData(std::shared_ptr<StyleLayer> /*layer_desc*/) const {
     return bucket.hasData();
 }

src/renderer/debug_bucket.cpp

@@ -14,7 +14,7 @@ DebugBucket::DebugBucket(DebugFontBuffer& fontBuffer)
     : fontBuffer(fontBuffer) {
 }
 
-void DebugBucket::render(Painter& painter, std::shared_ptr<StyleLayer> layer_desc, const Tile::ID& /*id*/) {
+void DebugBucket::render(Painter& painter, std::shared_ptr<StyleLayer> /*layer_desc*/, const Tile::ID& /*id*/) {
     painter.renderDebugText(*this);
 }
 

src/renderer/painter_prerender.cpp

@@ -17,7 +17,7 @@ void Painter::preparePrerender(PrerenderedTexture &texture) {
     glViewport(0, 0, texture.properties.size, texture.properties.size);
 }
 
-void Painter::finishPrerender(PrerenderedTexture &texture) {
+void Painter::finishPrerender(PrerenderedTexture &/*texture*/) {
     glEnable(GL_DEPTH_TEST);
     glEnable(GL_STENCIL_TEST);
 

src/renderer/painter_raster.cpp

@@ -5,10 +5,10 @@
 
 using namespace mbgl;
 
-void Painter::renderRaster(RasterBucket& bucket, std::shared_ptr<StyleLayer> layer_desc, const Tile::ID& /*id*/) {
+void Painter::renderRaster(RasterBucket& bucket, std::shared_ptr<StyleLayer> /*layer_desc*/, const Tile::ID& /*id*/) {
     if (pass == Translucent) return;
 
-    const RasterProperties &properties = layer_desc->getProperties<RasterProperties>();
+    // const RasterProperties &properties = layer_desc->getProperties<RasterProperties>();
 
     depthMask(false);
 

src/renderer/painter_symbol.cpp

@@ -10,7 +10,7 @@
 namespace mbgl {
 
 void Painter::renderSymbol(SymbolBucket &bucket, std::shared_ptr<StyleLayer> layer_desc,
-                           const Tile::ID &id) {
+                           const Tile::ID &/*id*/) {
     // Abort early.
     if (pass == Opaque) {
         return;

src/style/style_parser.cpp

@@ -377,7 +377,7 @@ template<> std::tuple<bool, RotateAnchorType> StyleParser::parseProperty<RotateA
     return std::tuple<bool, RotateAnchorType> { true, RotateAnchorTypeClass({ value.GetString(), value.GetStringLength() }) };
 }
 
-template<> std::tuple<bool, PropertyTransition> StyleParser::parseProperty(JSVal value, const char *property_name) {
+template<> std::tuple<bool, PropertyTransition> StyleParser::parseProperty(JSVal value, const char */*property_name*/) {
     PropertyTransition transition;
     if (value.IsObject()) {
         if (value.HasMember("duration") && value["duration"].IsNumber()) {