tei/MapLibreParticleLab
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[test,ios] Disable multiple mapsnapshotter test.

Browse Source 
8 simultaneous mapsnapshotter test periodically deadlocks in simulator.
Also, increase timeouts to decrease chance of spurious test failure.
This commit is contained in:
Chris Loer
2018-06-01 15:49:28 -07:00
committed by Chris Loer
parent 050337fb68
commit 6eee872955
1 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
platform/ios/Integration Tests/Snapshotter Tests/MGLMapSnapshotterTest.m
View File

@@ -104,12 +104,11 @@ NSString* validAccessToken() {
[self waitForExpectations:@[expectation] timeout:2.0];
}
- (void)testMultipleSnapshottersFromBackgroundQueue {
- (void)testSnapshotterFromBackgroundQueue {
if (!validAccessToken()) {
return;
}
// Crashes with only 1 snapshot
CGSize size = self.mapView.bounds.size;
CLLocationCoordinate2D coord = CLLocationCoordinate2DMake(30.0, 30.0);
@@ -145,10 +144,9 @@ NSString* validAccessToken() {
MGLTestAssertNotNil(strongself, snapshot.image);
MGLTestAssertNil(strongself, error, @"Snapshot should not error with: %@", error);
// Change this back to XCTAttachmentLifetimeDeleteOnSuccess when we're sure this
// test is passing.
// Change this to XCTAttachmentLifetimeKeepAlways to be able to look at the snapshots after running
XCTAttachment *attachment = [XCTAttachment attachmentWithImage:snapshot.image];
attachment.lifetime = XCTAttachmentLifetimeKeepAlways;
attachment.lifetime = XCTAttachmentLifetimeDeleteOnSuccess;
[strongself addAttachment:attachment];
dispatch_group_leave(group);
@@ -174,10 +172,11 @@ NSString* validAccessToken() {
});
});
[self waitForExpectations:@[expectation] timeout:10.0];
[self waitForExpectations:@[expectation] timeout:60.0];
}
- (void)testMultipleSnapshotters {
- (void)testMultipleSnapshottersPENDING {
MGL_CHECK_IF_PENDING_TEST_SHOULD_RUN();
if (!validAccessToken()) {
return;
}
@@ -217,10 +216,9 @@ NSString* validAccessToken() {
MGLTestAssertNotNil(strongself, snapshot.image);
MGLTestAssertNil(strongself, error, @"Snapshot should not error with: %@", error);
// Change this back to XCTAttachmentLifetimeDeleteOnSuccess when we're sure this
// test is passing.
// Change this to XCTAttachmentLifetimeKeepAlways to be able to look at the snapshots after running
XCTAttachment *attachment = [XCTAttachment attachmentWithImage:snapshot.image];
attachment.lifetime = XCTAttachmentLifetimeKeepAlways;
attachment.lifetime = XCTAttachmentLifetimeDeleteOnSuccess;
[strongself addAttachment:attachment];
// Dealloc the snapshotter (by having this line in the block, we
@@ -233,7 +231,7 @@ NSString* validAccessToken() {
}];
} // end for loop
[self waitForExpectations:@[expectation] timeout:20.0];
[self waitForExpectations:@[expectation] timeout:60.0];
}
@end