tei/MapLibreParticleLab
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[core] Fixed bit-shifting error in exponential backoff

Browse Source 
This change fixes a bug introduced in 4d5c6333be for #2727. 1 << 32 would exceed the size of int64_t. The static analyzer reported undefined behavior here because std::min() might or might not return 32.
This commit is contained in:
Minh Nguyễn
2015-11-11 15:24:59 -08:00
parent aae7f90e37
commit 6748b6155e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/mbgl/storage/default_file_source.cpp
View File

@@ -325,12 +325,12 @@ int64_t DefaultFileRequest::getRetryTimeout() const {
if (failedRequests <= graceRetries) {
timeout = 1;
} else {
timeout = 1 << std::min(failedRequests - graceRetries, 32);
timeout = 1 << std::min(failedRequests - graceRetries, 31);
}
} break;
case Response::Error::Reason::Connection: {
// Exponential backoff
timeout = 1 << std::min(failedRequests - 1, 32);
timeout = 1 << std::min(failedRequests - 1, 31);
} break;
default:
// Do not retry due to error.