tei/MapLibreParticleLab
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix accidental regression conditional layer evaluation (#2705)

Browse Source
This commit is contained in:
Tim Sylvester
2024-08-09 14:54:54 -07:00
committed by GitHub
parent 942f43ef80
commit 60c1d351cf
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/mbgl/renderer/render_orchestrator.cpp
View File

@@ -309,7 +309,14 @@ std::unique_ptr<RenderTree> RenderOrchestrator::createRenderTree(
const bool layerAddedOrChanged = layerDiff.added.count(id) || layerDiff.changed.count(id);
evaluationParameters.layerChanged = layerAddedOrChanged;
evaluationParameters.hasCrossfade = layer.hasCrossfade();
if (layerAddedOrChanged || zoomChanged || evaluationParameters.hasCrossfade || layer.hasTransition()) {
// Only re-evaluate on change of zoom if the style has some reference to it
using Dependency = expression::Dependency;
const bool zoomChangedAndMatters = zoomChanged && !layerAddedOrChanged &&
(layer.getStyleDependencies() & Dependency::Zoom);
if (layerAddedOrChanged || zoomChangedAndMatters || evaluationParameters.hasCrossfade ||
layer.hasTransition()) {
const auto previousMask = layer.evaluatedProperties->constantsMask();
layer.evaluate(evaluationParameters);
if (previousMask != layer.evaluatedProperties->constantsMask()) {