[tidy] Check modernize-use-override

Ref: http://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html

include/mbgl/platform/default/glfw_view.hpp

@@ -14,7 +14,7 @@
 class GLFWView : public mbgl::View {
 public:
     GLFWView(bool fullscreen = false, bool benchmark = false);
-    ~GLFWView();
+    ~GLFWView() override;
 
     float getPixelRatio() const override;
     std::array<uint16_t, 2> getSize() const override;

include/mbgl/platform/default/headless_view.hpp

@@ -31,7 +31,7 @@ class HeadlessView : public View {
 public:
     HeadlessView(float pixelRatio, uint16_t width = 256, uint16_t height = 256);
     HeadlessView(std::shared_ptr<HeadlessDisplay> display, float pixelRatio, uint16_t width = 256, uint16_t height = 256);
-    ~HeadlessView();
+    ~HeadlessView() override;
 
     float getPixelRatio() const override;
     std::array<uint16_t, 2> getSize() const override;

platform/default/online_file_source.cpp

@@ -27,7 +27,7 @@ public:
     using Callback = std::function<void (Response)>;
 
     OnlineFileRequest(Resource, Callback, OnlineFileSource::Impl&);
-    ~OnlineFileRequest();
+    ~OnlineFileRequest() override;
 
     void networkIsReachableAgain();
     void schedule(optional<Timestamp> expires);

src/mbgl/annotation/annotation_tile.hpp

@@ -16,7 +16,7 @@ public:
     AnnotationTile(const OverscaledTileID&,
                        std::string sourceID,
                        const style::UpdateParameters&);
-    ~AnnotationTile();
+    ~AnnotationTile() override;
 
     void setNecessity(Necessity) final;
 

src/mbgl/style/observer.hpp

@@ -17,7 +17,7 @@ public:
      * strictly additive; e.g. when a source is loaded, both `onSourceLoaded`
      * and `onNeedsRepaint` will be called.
      */
-    virtual void onNeedsRepaint() {}
+    void onNeedsRepaint() override {}
     virtual void onResourceError(std::exception_ptr) {}
 };
 

src/mbgl/style/source.hpp

@@ -46,7 +46,7 @@ public:
            uint16_t tileSize,
            std::unique_ptr<Tileset>&&,
            std::unique_ptr<mapbox::geojsonvt::GeoJSONVT>&&);
-    ~Source();
+    ~Source() override;
 
     bool loaded = false;
     void load(FileSource&);

src/mbgl/style/style.hpp

@@ -37,7 +37,7 @@ class Style : public GlyphStoreObserver,
               public util::noncopyable {
 public:
     Style(FileSource&, float pixelRatio);
-    ~Style();
+    ~Style() override;
 
     void setJSON(const std::string&);
 

src/mbgl/tile/geometry_tile.hpp

@@ -26,7 +26,7 @@ public:
                  style::Style&,
                  const MapMode);
 
-    ~GeometryTile();
+    ~GeometryTile() override;
 
     void setError(std::exception_ptr err);
     void setData(std::unique_ptr<GeometryTileData>);

test/src/mbgl/test/fixture_log_observer.hpp

@@ -30,10 +30,10 @@ public:
         using LogMessage = Message;
 
         Observer(FixtureLog* log = nullptr);
-        ~Observer();
+        ~Observer() override;
 
         // Log::Observer implementation
-        virtual bool onRecord(EventSeverity severity,
+        bool onRecord(EventSeverity severity,
                               Event event,
                               int64_t code,
                               const std::string& msg) override;

test/src/mbgl/test/stub_file_source.cpp

@@ -10,7 +10,7 @@ public:
         : fileSource(fileSource_) {
     }
 
-    ~StubFileRequest() {
+    ~StubFileRequest() override {
         fileSource.pending.erase(this);
     }