[tidy] Check modernize-pass-by-value

Ref: http://clang.llvm.org/extra/clang-tidy/checks/modernize-pass-by-value.html
This commit is contained in:
Bruno de Oliveira Abinader
2016-06-12 13:53:35 +03:00
parent 92f605df32
commit 4161d197fd
54 changed files with 120 additions and 135 deletions

View File

@@ -26,7 +26,7 @@ class OnlineFileRequest : public AsyncRequest {
public:
using Callback = std::function<void (Response)>;
OnlineFileRequest(const Resource&, Callback, OnlineFileSource::Impl&);
OnlineFileRequest(Resource, Callback, OnlineFileSource::Impl&);
~OnlineFileRequest();
void networkIsReachableAgain();
@@ -182,9 +182,9 @@ std::unique_ptr<AsyncRequest> OnlineFileSource::request(const Resource& resource
return std::make_unique<OnlineFileRequest>(res, callback, *impl);
}
OnlineFileRequest::OnlineFileRequest(const Resource& resource_, Callback callback_, OnlineFileSource::Impl& impl_)
OnlineFileRequest::OnlineFileRequest(Resource resource_, Callback callback_, OnlineFileSource::Impl& impl_)
: impl(impl_),
resource(resource_),
resource(std::move(resource_)),
callback(std::move(callback_)) {
impl.add(this);