tei/MapLibreParticleLab
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[core] prefer static_cast for casts to derived classes

Browse Source
This commit is contained in:
Konstantin Käfer
2019-03-20 15:55:39 +01:00
parent be3b5917c1
commit 394e2aa717
8 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/mbgl/gl/program.hpp
View File

@@ -168,7 +168,7 @@ public:
const gfx::IndexBuffer& indexBuffer,
std::size_t indexOffset,
std::size_t indexLength) override {
auto& context = reinterpret_cast<gl::Context&>(genericContext);
auto& context = static_cast<gl::Context&>(genericContext);
context.setDepthMode(depthMode);
context.setStencilMode(stencilMode);
@@ -194,7 +194,7 @@ public:
instance.textureStates.bind(context, textureBindings);
auto& vertexArray = reinterpret_cast<gl::DrawScopeResource&>(*drawScope.resource).vertexArray;
auto& vertexArray = static_cast<gl::DrawScopeResource&>(*drawScope.resource).vertexArray;
vertexArray.bind(context,
indexBuffer,
instance.attributeLocations.toBindingArray(attributeBindings));

2
src/mbgl/gl/texture.cpp
View File

@@ -9,7 +9,7 @@ namespace gl {
using namespace platform;
void bindTexture(gl::Context& context, const uint8_t unit, const gfx::TextureBinding& binding) {
auto& resource = reinterpret_cast<gl::TextureResource&>(*binding.resource);
auto& resource = static_cast<gl::TextureResource&>(*binding.resource);
if (binding.filter != resource.filter || binding.mipmap != resource.mipmap ||
binding.wrapX != resource.wrapX || binding.wrapY != resource.wrapY) {
context.activeTextureUnit = unit;

2
src/mbgl/renderer/layers/render_custom_layer.cpp
View File

@@ -58,7 +58,7 @@ void RenderCustomLayer::render(PaintParameters& paintParameters, RenderSource*)
}
// TODO: remove cast
gl::Context& glContext = reinterpret_cast<gl::Context&>(paintParameters.context);
gl::Context& glContext = static_cast<gl::Context&>(paintParameters.context);
const TransformState& state = paintParameters.state;
// Reset GL state to a known state so the CustomLayer always has a clean slate.

2
src/mbgl/renderer/layers/render_fill_extrusion_layer.cpp
View File

@@ -52,7 +52,7 @@ bool RenderFillExtrusionLayer::hasCrossfade() const {
void RenderFillExtrusionLayer::render(PaintParameters& parameters, RenderSource*) {
// TODO: remove cast
gl::Context& glContext = reinterpret_cast<gl::Context&>(parameters.context);
gl::Context& glContext = static_cast<gl::Context&>(parameters.context);
if (parameters.pass == RenderPass::Opaque) {
return;

2
src/mbgl/renderer/layers/render_fill_layer.cpp
View File

@@ -64,7 +64,7 @@ bool RenderFillLayer::hasCrossfade() const {
void RenderFillLayer::render(PaintParameters& parameters, RenderSource*) {
// TODO: remove cast
gl::Context& glContext = reinterpret_cast<gl::Context&>(parameters.context);
gl::Context& glContext = static_cast<gl::Context&>(parameters.context);
if (unevaluated.get<FillPattern>().isUndefined()) {
for (const RenderTile& tile : renderTiles) {

2
src/mbgl/renderer/layers/render_heatmap_layer.cpp
View File

@@ -53,7 +53,7 @@ void RenderHeatmapLayer::render(PaintParameters& parameters, RenderSource*) {
}
// TODO: remove cast
gl::Context& glContext = reinterpret_cast<gl::Context&>(parameters.context);
gl::Context& glContext = static_cast<gl::Context&>(parameters.context);
if (parameters.pass == RenderPass::Pass3D) {
const auto& viewportSize = parameters.staticData.backendSize;

2
src/mbgl/renderer/renderer_impl.cpp
View File

@@ -311,7 +311,7 @@ void Renderer::Impl::render(const UpdateParameters& updateParameters) {
backend.updateAssumedState();
// TODO: remove cast
gl::Context& glContext = reinterpret_cast<gl::Context&>(parameters.context);
gl::Context& glContext = static_cast<gl::Context&>(parameters.context);
if (parameters.contextMode == GLContextMode::Shared) {
glContext.setDirtyState();

4
src/mbgl/util/offscreen_texture.cpp
View File

@@ -66,7 +66,7 @@ OffscreenTexture::OffscreenTexture(gfx::Context& context,
const Size size,
const gfx::TextureChannelDataType type)
// TODO: remove cast
: impl(std::make_unique<Impl>(reinterpret_cast<gl::Context&>(context), std::move(size), type)) {
: impl(std::make_unique<Impl>(static_cast<gl::Context&>(context), std::move(size), type)) {
assert(!size.isEmpty());
}
@@ -75,7 +75,7 @@ OffscreenTexture::OffscreenTexture(gfx::Context& context,
gfx::Renderbuffer<gfx::RenderbufferPixelType::Depth>& renderbuffer,
const gfx::TextureChannelDataType type)
// TODO: remove cast
: impl(std::make_unique<Impl>(reinterpret_cast<gl::Context&>(context), std::move(size), renderbuffer, type)) {
: impl(std::make_unique<Impl>(static_cast<gl::Context&>(context), std::move(size), renderbuffer, type)) {
assert(!size.isEmpty());
}