[core][offline] Offline download does not hang on 404 error

2020-02-27 15:16:35 +02:00
parent e0c2b3e771
commit 2b1bb1dc4a
1 changed files with 7 additions and 0 deletions
--- a/platform/default/src/mbgl/storage/offline_download.cpp
+++ b/platform/default/src/mbgl/storage/offline_download.cpp
@@ -484,6 +484,13 @@ void OfflineDownload::ensureResource(Resource&& resource,
        *fileRequestsIt = onlineFileSource.request(resource, [=](Response onlineResponse) {
            if (onlineResponse.error) {
                observer->responseError(*onlineResponse.error);
+                if (onlineResponse.error->reason == Response::Error::Reason::NotFound) {
+                    // On error 404, we skip this request and go further.
+                    requests.erase(fileRequestsIt);
+                    assert(status.requiredResourceCount > 0);
+                    status.requiredResourceCount--;
+                    continueDownload();
+                }
                return;
            }