tei/MapLibreParticleLab
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[test-runner] Log all 'probeFileSize' failures

Browse Source 
If there are multiple file size probes in a test file, it is
better to report all failures instead of first failed probe.
This commit is contained in:
Alexander Shalamov
2019-11-29 15:07:42 +02:00
parent 00d133239e
commit 0c348a8acf
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
render-test/runner.cpp
View File

@@ -360,6 +360,7 @@ bool TestRunner::checkProbingResults(TestMetadata& metadata) {
// Check file size metrics.
auto checkFileSize = [](TestMetadata& metadata) -> bool {
if (metadata.metrics.fileSize.empty()) return true;
bool passed = true;
for (const auto& expected : metadata.expectedMetrics.fileSize) {
auto actual = metadata.metrics.fileSize.find(expected.first);
if (actual == metadata.metrics.fileSize.end()) {
@@ -378,14 +379,16 @@ bool TestRunner::checkProbingResults(TestMetadata& metadata) {
auto result = checkValue(expected.second.size, actual->second.size, actual->second.tolerance);
if (!std::get<bool>(result)) {
std::stringstream ss;
ss << "File size does not match at probe \"" << expected.first << "\": " << actual->second.size
<< ", expected is " << expected.second.size << ".";
ss << "File size does not match at probe \"" << expected.first << "\" for file \""
<< expected.second.path << "\": " << actual->second.size << ", expected is " << expected.second.size
<< ".";
metadata.errorMessage = ss.str();
return false;
metadata.errorMessage += metadata.errorMessage.empty() ? ss.str() : "\n" + ss.str();
passed = false;
continue;
}
}
return true;
return passed;
};
auto checkMemory = [](TestMetadata& metadata) -> bool {
if (metadata.metrics.memory.empty()) return true;