Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Bart Louwers <bart@emeel.net>
274 lines
9.9 KiB
Objective-C
274 lines
9.9 KiB
Objective-C
#import <Mapbox.h>
|
|
#import <XCTest/XCTest.h>
|
|
#import "MLNTestUtility.h"
|
|
|
|
static NSString * const MLNTestAnnotationReuseIdentifer = @"MLNTestAnnotationReuseIdentifer";
|
|
|
|
|
|
@interface MLNMapView (Tests)
|
|
@property (nonatomic) MLNCameraChangeReason cameraChangeReasonBitmask;
|
|
@end
|
|
|
|
|
|
|
|
@interface MLNCustomAnnotationView : MLNAnnotationView
|
|
|
|
@end
|
|
|
|
@implementation MLNCustomAnnotationView
|
|
|
|
- (instancetype)initWithReuseIdentifier:(NSString *)reuseIdentifier {
|
|
return [super initWithReuseIdentifier:@"reuse-id"];
|
|
}
|
|
|
|
@end
|
|
|
|
@interface MLNAnnotationView (Test)
|
|
|
|
@property (nonatomic) MLNMapView *mapView;
|
|
@property (nonatomic, readwrite) MLNAnnotationViewDragState dragState;
|
|
- (void)setDragState:(MLNAnnotationViewDragState)dragState;
|
|
|
|
@end
|
|
|
|
@interface MLNMapView (Test)
|
|
@property (nonatomic) UIView<MLNCalloutView> *calloutViewForSelectedAnnotation;
|
|
@end
|
|
|
|
@interface MLNTestAnnotation : NSObject <MLNAnnotation>
|
|
@property (nonatomic, assign) CLLocationCoordinate2D coordinate;
|
|
@end
|
|
|
|
@implementation MLNTestAnnotation
|
|
@end
|
|
|
|
@interface MLNTestCalloutView: UIView<MLNCalloutView>
|
|
@property (nonatomic) BOOL didCallDismissCalloutAnimated;
|
|
@property (nonatomic, strong) id <MLNAnnotation> representedObject;
|
|
@property (nonatomic, strong) UIView *leftAccessoryView;
|
|
@property (nonatomic, strong) UIView *rightAccessoryView;
|
|
@property (nonatomic, weak) id<MLNCalloutViewDelegate> delegate;
|
|
@end
|
|
|
|
@implementation MLNTestCalloutView
|
|
|
|
- (void)dismissCalloutAnimated:(BOOL)animated
|
|
{
|
|
_didCallDismissCalloutAnimated = YES;
|
|
}
|
|
|
|
- (void)presentCalloutFromRect:(CGRect)rect inView:(nonnull UIView *)view constrainedToRect:(CGRect)constrainedRect animated:(BOOL)animated {}
|
|
|
|
@end
|
|
|
|
@interface MLNAnnotationViewTests : XCTestCase <MLNMapViewDelegate>
|
|
@property (nonatomic) XCTestExpectation *expectation;
|
|
@property (nonatomic) MLNMapView *mapView;
|
|
@property (nonatomic, weak) MLNAnnotationView *annotationView;
|
|
@property (nonatomic) NSInteger annotationSelectedCount;
|
|
@property (nonatomic) void (^prepareAnnotationView)(MLNAnnotationView*);
|
|
@end
|
|
|
|
@implementation MLNAnnotationViewTests
|
|
|
|
- (void)setUp
|
|
{
|
|
[super setUp];
|
|
_mapView = [[MLNMapView alloc] initWithFrame:CGRectMake(0, 0, 64, 64)];
|
|
_mapView.delegate = self;
|
|
}
|
|
|
|
- (void)testAnnotationView
|
|
{
|
|
_expectation = [self expectationWithDescription:@"annotation property"];
|
|
|
|
MLNTestAnnotation *annotation = [[MLNTestAnnotation alloc] init];
|
|
[_mapView addAnnotation:annotation];
|
|
|
|
[self waitForExpectationsWithTimeout:5 handler:nil];
|
|
|
|
XCTAssert(_mapView.annotations.count == 1, @"number of annotations should be 1");
|
|
XCTAssertNotNil(_annotationView.annotation, @"annotation property should not be nil");
|
|
XCTAssertNotNil(_annotationView.mapView, @"mapView property should not be nil");
|
|
|
|
MLNTestCalloutView *testCalloutView = [[MLNTestCalloutView alloc] init];
|
|
_mapView.calloutViewForSelectedAnnotation = testCalloutView;
|
|
_annotationView.dragState = MLNAnnotationViewDragStateStarting;
|
|
XCTAssertTrue(testCalloutView.didCallDismissCalloutAnimated, @"callout view was not dismissed");
|
|
|
|
[_mapView removeAnnotation:_annotationView.annotation];
|
|
|
|
XCTAssert(_mapView.annotations.count == 0, @"number of annotations should be 0");
|
|
XCTAssertNil(_annotationView.annotation, @"annotation property should be nil");
|
|
}
|
|
|
|
- (void)testCustomAnnotationView
|
|
{
|
|
MLNCustomAnnotationView *customAnnotationView = [[MLNCustomAnnotationView alloc] initWithReuseIdentifier:@"reuse-id"];
|
|
XCTAssertNotNil(customAnnotationView);
|
|
}
|
|
|
|
- (void)testSelectingOffscreenAnnotation
|
|
{
|
|
// Partial test for https://github.com/mapbox/mapbox-gl-native/issues/9790
|
|
|
|
// This isn't quite the same as in updateAnnotationViews, but should be sufficient for this test.
|
|
MLNCoordinateBounds coordinateBounds = [_mapView convertRect:_mapView.bounds toCoordinateBoundsFromView:_mapView];
|
|
|
|
// -90 latitude is invalid. TBD.
|
|
BOOL anyOffscreen = NO;
|
|
NSInteger selectionCount = 0;
|
|
|
|
for (NSInteger latitude = -89; latitude <= 90; latitude += 10)
|
|
{
|
|
for (NSInteger longitude = -180; longitude <= 180; longitude += 10)
|
|
{
|
|
MLNTestAnnotation *annotation = [[MLNTestAnnotation alloc] init];
|
|
|
|
annotation.coordinate = CLLocationCoordinate2DMake(latitude, longitude);
|
|
[_mapView addAnnotation:annotation];
|
|
|
|
if (!(MLNCoordinateInCoordinateBounds(annotation.coordinate, coordinateBounds)))
|
|
anyOffscreen = YES;
|
|
|
|
XCTAssertNil(_mapView.selectedAnnotations.firstObject, @"There should be no selected annotation");
|
|
|
|
// First selection
|
|
[_mapView selectAnnotation:annotation animated:NO completionHandler:nil];
|
|
selectionCount++;
|
|
|
|
XCTAssert(_mapView.selectedAnnotations.count == 1, @"There should only be 1 selected annotation");
|
|
XCTAssertEqualObjects(_mapView.selectedAnnotations.firstObject, annotation, @"The annotation should be selected");
|
|
|
|
// Deselect
|
|
[_mapView deselectAnnotation:annotation animated:NO];
|
|
XCTAssert(_mapView.selectedAnnotations.count == 0, @"There should be no selected annotations");
|
|
|
|
// Second selection
|
|
_mapView.selectedAnnotations = @[annotation];
|
|
selectionCount++;
|
|
|
|
XCTAssert(_mapView.selectedAnnotations.count == 1, @"There should be 1 selected annotation");
|
|
XCTAssertEqualObjects(_mapView.selectedAnnotations.firstObject, annotation, @"The annotation should be selected");
|
|
|
|
// Deselect
|
|
[_mapView deselectAnnotation:annotation animated:NO];
|
|
XCTAssert(_mapView.selectedAnnotations.count == 0, @"There should be no selected annotations");
|
|
}
|
|
}
|
|
|
|
XCTAssert(anyOffscreen, @"At least one of these annotations should be offscreen");
|
|
XCTAssertEqual(selectionCount, self.annotationSelectedCount, @"-mapView:didSelectAnnotation: should be called for each selection");
|
|
}
|
|
|
|
- (void)testSelectingOnscreenAnnotationThatHasNotBeenAdded {
|
|
// See https://github.com/mapbox/mapbox-gl-native/issues/11476
|
|
|
|
// This bug occurs under the following conditions:
|
|
//
|
|
// - There are content insets (e.g. navigation bar) for the compare against
|
|
// CGRectZero (now CGRectNull)
|
|
// - annotationView.enabled == NO - Currently this can happen if you use
|
|
// `-initWithFrame:` rather than one of the provided initializers
|
|
//
|
|
|
|
self.prepareAnnotationView = ^(MLNAnnotationView *view) {
|
|
view.enabled = NO;
|
|
};
|
|
|
|
self.mapView.contentInset = UIEdgeInsetsMake(10.0, 10.0, 10.0, 10.0);
|
|
|
|
MLNCameraChangeReason reasonBefore = self.mapView.cameraChangeReasonBitmask;
|
|
XCTAssert(reasonBefore == MLNCameraChangeReasonNone, @"Camera should not have moved at start of test");
|
|
|
|
// Create annotation
|
|
MLNPointFeature *point = [[MLNPointFeature alloc] init];
|
|
point.title = NSStringFromSelector(_cmd);
|
|
point.coordinate = CLLocationCoordinate2DMake(0.0, 0.0);
|
|
|
|
MLNCoordinateBounds coordinateBounds = [self.mapView convertRect:self.mapView.bounds toCoordinateBoundsFromView:self.mapView];
|
|
XCTAssert(MLNCoordinateInCoordinateBounds(point.coordinate, coordinateBounds), @"The test point should be within the visible map view");
|
|
|
|
// Select on screen annotation (DO NOT ADD FIRST).
|
|
[self.mapView selectAnnotation:point animated:YES completionHandler:nil];
|
|
|
|
// Expect - the camera NOT to move.
|
|
MLNCameraChangeReason reasonAfter = self.mapView.cameraChangeReasonBitmask;
|
|
XCTAssert(reasonAfter == MLNCameraChangeReasonNone, @"Camera should not have moved");
|
|
}
|
|
|
|
- (void)checkDefaultPropertiesForAnnotationView:(MLNAnnotationView*)view {
|
|
XCTAssertNil(view.annotation);
|
|
XCTAssertNil(view.reuseIdentifier);
|
|
XCTAssertEqual(view.centerOffset.dx, 0.0);
|
|
XCTAssertEqual(view.centerOffset.dy, 0.0);
|
|
XCTAssertFalse(view.scalesWithViewingDistance);
|
|
XCTAssertFalse(view.rotatesToMatchCamera);
|
|
XCTAssertFalse(view.isSelected);
|
|
XCTAssert(view.isEnabled);
|
|
XCTAssertFalse(view.isDraggable);
|
|
XCTAssertEqual(view.dragState, MLNAnnotationViewDragStateNone);
|
|
}
|
|
|
|
- (void)testAnnotationViewInitWithFramePENDING {
|
|
MLN_CHECK_IF_PENDING_TEST_SHOULD_RUN();
|
|
CGRect frame = CGRectMake(10.0, 10.0, 100.0, 100.0);
|
|
MLNAnnotationView *view = [[MLNAnnotationView alloc] initWithFrame:frame];
|
|
[self checkDefaultPropertiesForAnnotationView:view];
|
|
}
|
|
|
|
- (void)testAnnotationViewInitWithReuseIdentifier {
|
|
MLNAnnotationView *view = [[MLNAnnotationView alloc] initWithReuseIdentifier:nil];
|
|
[self checkDefaultPropertiesForAnnotationView:view];
|
|
}
|
|
|
|
- (void)testSelectingADisabledAnnotationViewPENDING {
|
|
MLN_CHECK_IF_PENDING_TEST_SHOULD_RUN();
|
|
self.prepareAnnotationView = ^(MLNAnnotationView *view) {
|
|
view.enabled = NO;
|
|
};
|
|
|
|
// Create annotation
|
|
MLNPointFeature *point = [[MLNPointFeature alloc] init];
|
|
point.title = NSStringFromSelector(_cmd);
|
|
point.coordinate = CLLocationCoordinate2DMake(0.0, 0.0);
|
|
|
|
XCTAssert(self.mapView.selectedAnnotations.count == 0, @"There should be 0 selected annotations");
|
|
|
|
[self.mapView selectAnnotation:point animated:NO completionHandler:nil];
|
|
|
|
XCTAssert(self.mapView.selectedAnnotations.count == 0, @"There should be 0 selected annotations");
|
|
}
|
|
|
|
// MARK: - MLNMapViewDelegate -
|
|
|
|
- (MLNAnnotationView *)mapView:(MLNMapView *)mapView viewForAnnotation:(id<MLNAnnotation>)annotation
|
|
{
|
|
MLNAnnotationView *annotationView = [mapView dequeueReusableAnnotationViewWithIdentifier:MLNTestAnnotationReuseIdentifer];
|
|
|
|
if (!annotationView)
|
|
{
|
|
annotationView = [[MLNAnnotationView alloc] initWithAnnotation:annotation reuseIdentifier:MLNTestAnnotationReuseIdentifer];
|
|
}
|
|
|
|
if (self.prepareAnnotationView) {
|
|
self.prepareAnnotationView(annotationView);
|
|
}
|
|
|
|
_annotationView = annotationView;
|
|
|
|
return annotationView;
|
|
}
|
|
|
|
- (void)mapView:(MLNMapView *)mapView didAddAnnotationViews:(NSArray<MLNAnnotationView *> *)annotationViews
|
|
{
|
|
[_expectation fulfill];
|
|
}
|
|
|
|
- (void)mapView:(MLNMapView *)mapView didSelectAnnotation:(id<MLNAnnotation>)annotation
|
|
{
|
|
self.annotationSelectedCount++;
|
|
}
|
|
|
|
@end
|