Files
MapLibreParticleLab/src/mbgl/style/source.cpp
John Firebaugh afead4e749 [core] Return {Source,Layer}::getID by value
Avoid dangling references in the following sequence:

    auto& id = layer->getID();
    layer->setMaxZoom(2);
    std::cout << id;

The reference would be dangling because mutating the layer allocates a new Immutable impl, and there may be no references to the prior impl, which held the id.
2017-05-12 11:26:27 -07:00

41 lines
902 B
C++

#include <mbgl/style/source.hpp>
#include <mbgl/style/source_impl.hpp>
#include <mbgl/style/source_observer.hpp>
#include <mbgl/util/logging.hpp>
namespace mbgl {
namespace style {
static SourceObserver nullObserver;
Source::Source(Immutable<Impl> impl)
: baseImpl(std::move(impl)),
observer(&nullObserver) {
}
Source::~Source() = default;
SourceType Source::getType() const {
return baseImpl->type;
}
std::string Source::getID() const {
return baseImpl->id;
}
optional<std::string> Source::getAttribution() const {
return baseImpl->getAttribution();
}
void Source::setObserver(SourceObserver* observer_) {
observer = observer_ ? observer_ : &nullObserver;
}
void Source::dumpDebugLogs() const {
Log::Info(Event::General, "Source::id: %s", getID().c_str());
Log::Info(Event::General, "Source::loaded: %d", loaded);
}
} // namespace style
} // namespace mbgl