When we load a stale style from cache, and the user immediately starts mutating it, we should continue loading the style so that we'll get a fresh copy of the data into our cache and avoid perpetually showing the stale style.
When we load a stale style from cache, and the user immediately starts mutating it, we should continue loading the style so that we'll get a fresh copy of the data into our cache and avoid perpetually showing the stale style.
Updated coordinate bounds conversion methods to use the beyond-±180 method to indicate that the bounds extends beyond the antimeridian. Also copyedited conversion documentation.
Timing based tests are inherently flakey and prone to failure on slow CI:
> Test case 'MGLDocumentationExampleTests.testMGLMapSnapshotter()' failed on 'iPhone X' (3.375 seconds)
> Test case 'MGLDocumentationExampleTests.testMGLMapSnapshotter()' failed on 'iPhone 8' (3.413 seconds)
> Test case 'MGLDocumentationExampleTests.testMGLMapSnapshotter()' failed on 'iPhone 7' (2.944 seconds)
Fixes: object of type 'MGLPointAnnotation/MGLPolyline *' is not compatible with array element type 'MGLShape<MGLFeature> *' [-Wobjc-literal-conversion]
* [ios] Introduce mobile events dependency
This adds the mobile events dependency including the events library's namespaced header file so that the related compiled symbols are prefixed to make them specific to the maps SDK. A pre-compiled header file is added so that the namespaced header file is added in all places where it is needed (most importantly every events library file).
* [ios] Use new events library for telemetry events
This makes the following significant changes:
Refactors the MGLMapboxEvents singleton to delegate internally to an instance of MMEEventsManager that it keeps for itself. The MGLMapboxEvents public API is refactored to reflect this. Note: MGLMapboxEvents continues to handle checking for opt out
Uses that new events API in MGLMapboxEvents to send all telem events (and turnstile)
All embedded certs are removed since the new telem library uses public key info pinning
Legacy telemetry utility classes for location and networking are removed since those are implemented in the telem library
* [ios] Update submodules initialized by cmake
We no longer bring in SMCalloutView as a submodule so it is removed.
We now vendor the telemetry events library as a submodule so it is added.
* Update mapbox-mobile-events
* Update mobile events lib
* Set events options with MGL user defaults values
For options that historically could be set with user defaults in the Maps SDK, collect them and set the appropriate property values in the new events library.
Also, check the existence of two new optional configuration values MGLTelemetryAccessToken and MGLTelemetryBaseURL so that the events endpoint and access token can be configured and the access token can easily be set dynamically and apart from the access token for the maps API.
MGLTelemetryBaseURL replaces the legacy MGLTelemetryTestServerURL. This is ok because this value was never intended to be used by client applications. The new name better reflects the fact that the URL can be changed to any backend stack, not just a test server.
Because it is possible for the configuration values to be read from user defaults before the events manager is fully set up, this also adds a local cache for the baseURL and accessToken values so that they can be stored and applied once it is time to setup the the events manager.
* Update mapbox-mobile-events
mapbox-mobile-events was forced pushed to include https://github.com/mapbox/mapbox-events-ios/pull/28
* Rename MGLMapboxEvents singleton access method
Manager is not in the name of the class. Just call it an instance.
* Update mapbox-mobile-events
* Add comments about config value loading
* Guard against creating events for IB
* Refactor user defaults update handler
This updates the handling logic for user defaults to break apart config changes that require a check for pausing or resuming the events lib’s telemetry collection from config changes that can happen with no update to the pause/resume state.
It also ports the optimization from https://github.com/mapbox/mapbox-gl-native/pull/10803 so that the call to pause and resume is not performed unless the user defaults store has new values that have not yet been applied to the events library.
* Update mapbox-mobile-events
* Rename events submodule folder
* Fix incorrect events library refs
* Update mapbox-mobile-events
* Update user user agent id value
This value aligns with our schme of {source-sdk-platform} and will be used by the events library in the user agent and vendorid.
* Update mapbox-mobile-events
Pin to v3.0.0 (d522b18)
* Improve code comments
* [ios] Fixed a broken file reference to MGLTelemetryConfig.
smallest bounding box for 4 points cannot (#11226)
be created using LatLngBounds.fromLatLngs()
as the order matters in that method and that does not work for rotated map
- Round-tripping expressions through serialization and checking that outputs don't change
- Checking expression serialization against expected value from fixture
Issue #10714
- Each expression stores its operator as a string, and default serialization is [operator, serialize(child1), ...]
- Custom implementations of `serialize` for Expression types that don't follow the pattern
- expression::Value -> mbgl::Value converter
- node_expression bindings to expose `serialize`
smallest bounding box for 4 points cannot
be created using LatLngBounds.fromLatLngs()
as the order matters in that method and that does not work for rotated map
Timing based tests are inherently flakey and prone to failure on slow CI:
> Test case 'MGLDocumentationExampleTests.testMGLMapSnapshotter()' failed on 'iPhone X' (3.375 seconds)
> Test case 'MGLDocumentationExampleTests.testMGLMapSnapshotter()' failed on 'iPhone 8' (3.413 seconds)
> Test case 'MGLDocumentationExampleTests.testMGLMapSnapshotter()' failed on 'iPhone 7' (2.944 seconds)
