Commit Graph

16768 Commits

Author SHA1 Message Date
Thiago Marcos P. Santos
63116154fe [render-test] Only write metrics if they are available
Otherwise the file will have an empty tag.
2019-10-10 19:54:51 +03:00
Thiago Marcos P. Santos
629c0e1142 [render-test] Add tests for filesize probe
And make sure we run it on the bots
2019-10-10 19:54:51 +03:00
Thiago Marcos P. Santos
2e002746eb [render-test] Make clang-format happy 2019-10-10 19:54:51 +03:00
Thiago Marcos P. Santos
a9f06f3b52 [render-test] Add instruction for verifying file size
For a given absolute or relative path, measure the size of the file.

This is useful for measuring if the cache has increased as expected
after moving a camera or decreased after cleaning up.

In a more hackish manner, could be used for collecting binary size
statistics of shared libraries.
2019-10-10 19:54:51 +03:00
Thiago Marcos P. Santos
026e15fe3d [render-test] Fix rootPath parameter being ignored
It was doing nothing and always using the default root path.
2019-10-10 19:54:51 +03:00
Thiago Marcos P. Santos
2a3cc96c42 [tests] Do not run tests in parallel
Introduces too much flakeness.
2019-10-10 19:41:27 +03:00
Thiago Marcos P. Santos
5f371d5e39 [build] Check for code generation on Darwin
Sadly, it can only be done inside macOS because
of how examples are generated.
2019-10-10 19:41:27 +03:00
Thiago Marcos P. Santos
d0e6f9df44 [build] Remove redundant bots
We have something equivalent on the `next` workspace for these bots.
2019-10-10 19:41:27 +03:00
Łukasz Paczos
3e06965f33 [android] - manually write and read camera's padding array to parcel
This avoids relying on Parcel's util methods that do not handle null arrays gracefully.
2019-10-10 17:52:29 +02:00
Mikhail Pozdnyakov
e909997a31 [android][ios] Change log entries 2019-10-10 15:39:34 +03:00
Mikhail Pozdnyakov
2f973e9646 [core] Introduce Scheduler::bindOnce() and use it in ImageManager 2019-10-10 15:39:34 +03:00
Mikhail Pozdnyakov
76346944f3 [ci] Fixed duplicated render tests run on MacOS 2019-10-10 15:39:34 +03:00
Mikhail Pozdnyakov
ef8540b683 [core] Update ImageManager.OnStyleImageMissingBeforeSpriteLoaded unit test
So that it checks missing images requests coalescing.
2019-10-10 15:39:34 +03:00
Mikhail Pozdnyakov
71047ab853 [core] Disallow coalesced requests for patterns
Unlike icons, pattern changes are not caught with
style-diff meaning that the existing request could
be from the previous style and we cannot coalesce
requests for them.
2019-10-10 15:39:34 +03:00
Mikhail Pozdnyakov
76bbc42fa6 [core] Coalesce requests for the same missing image
This commit coalesces the repeated `onStyleImageMissing` calls
for the same image.

It also simplifies the image manager code.
2019-10-10 15:39:34 +03:00
Mikhail Pozdnyakov
f62e5b00c9 [core] Introduce Scheduler::makeWeakPtr() 2019-10-09 23:46:11 +03:00
Dane Springmeyer
da490c2b90 bump to v5 (#15781) 2019-10-09 13:30:17 -07:00
Nadia Barbosa
32a73a5be5 [ios] Podspec & changelog updates for v5.5.0-alpha.2 2019-10-09 13:20:04 -07:00
tobrun
7acfd3a243 [build] rework scripts to new build system 2019-10-09 19:31:40 +02:00
tobrun
83acc3ad3e [build] use next buildsystem from gl-native 2019-10-09 19:17:25 +02:00
tobrun
daf0430a24 [update] pull in latest for gl-native 2019-10-09 19:17:25 +02:00
Tobrun
2bd59ddc81 Merge pull request #6 from mapbox/tvn-add-makefile
Restore Makefile targets
2019-10-09 14:14:56 +02:00
tobrun
90b829a22e [build] restore Makefile targets 2019-10-09 13:56:35 +02:00
Mikhail Pozdnyakov
b4e0224a57 [test runner] Fix finding of expected images paths
Before this change, the found paths to the expected images
erroneously included the path to the `metrics.json` file
(if this file was present) leading to raising of an
unhandled exception.
2019-10-09 14:35:08 +03:00
tobrun
a3ef1ac2d0 [build] - initial commit 2019-10-09 13:19:56 +02:00
Dane Springmeyer
d0281e3ca4 node package improvements (#15748)
* node package improvements

* npm run test-suite does not do anything anymore
2019-10-08 16:27:04 -07:00
Julian Rex
563f9d0534 [ios] Skip metrics.sh step (#15779) 2019-10-08 17:49:45 -04:00
Peng Liu
7139abdbf5 [android] Expose pre-fetching zoom delta. (#15769)
* [android] Expose pre-fetching zoom delta.

* [android] Fix Clang format.

* [android] Add MapboxMap unit test.

* [android] Add prefetching zoom delta into MapboxMapOptions.

* [android] Deprecate setPrefetchesTiles to migrate to setPrefetchZoomDelta.

* [android] Deprecate getPrefetchesTiles() and migrate to setPrefetchZoomDelta().

* [android] Add unit test to NativeMapViewTest.

* [android] Add IntRange annotation to getPrefetchZoomDelta.
2019-10-08 16:21:46 +03:00
Juha Alanen
4eaaa9046e [tests] Share common code between test runners 2019-10-08 15:33:30 +03:00
Chloe Krawczyk
9be5ccb210 [docs] add SMCalloutView to LICENSE.md (#15774) 2019-10-07 22:39:22 -07:00
Mikhail Pozdnyakov
23cebe20fe [core] Introduce SequencedScheduler and ParallelScheduler
This commit refactors `utils::ThreadPool` into a template
`ThreadedScheduler` class and provides aux type aliases.
So that it is possible to obtain a sequenced schedule,where
all the scheduled tasks are guarantied to be executed
consequently.

The sequenced lightweight scheduler is required by both the
orchestration thread and the refactored `FileSource` implementation.
2019-10-07 16:42:40 +03:00
Juha Alanen
bd283fc1be [build] enable query tests on native test runner 2019-10-07 10:58:46 +03:00
Juha Alanen
e96c659906 [expression-test] fix result diffing 2019-10-07 10:58:46 +03:00
Juha Alanen
13801f1b80 [render-test] Add support for query tests 2019-10-07 10:58:46 +03:00
Juha Alanen
18a426d748 [render-test] Support feature-state tests where featureID is a number 2019-10-07 10:58:46 +03:00
Juha Alanen
f58a25932a [render-test] Add support for setPitch operation 2019-10-07 10:58:46 +03:00
Julian Rex
a90e5f6e97 [ios, macos] Changed exception to assert and nil return, since attribution methods can be called via user interaction (without a mechanism to try/catch) (#15764) 2019-10-05 13:06:28 -04:00
Fabian Guerra Soto
5c565a5e51 [ios] Fixes an issue that caused the ornaments ignore contentInset property. (#15584)
* [ios] Add mapView content inset tests.

* [ios] Fix an issue that caused the ornaments ignore the contentInsets.

Fixed an issue that caused ornaments ignore the contentInset. Added a new property automaticallyAdjustContentInset that has the same purpose as UIViewController. automaticallyAdjustsScrollViewInsets. This was changed due to the latter being deprecated.

* [ios] Fix automaticallyAdjustsScrollViewInsets legacy behavior.

The property automaticallyAdjustsScrollViewInsets overrode automaticallyAdjustsScrollViewInsets which caused a breaking change. This is fixed to consider the legacy property when calculating the content insets and added tests for both cases.

* [ios] Fix the contentInset value after adding padding to the camera.

Fixed an issue that caused a discrepancy between the contentInset in MGLMapView and the padding in the transformation state.

When padding is passed through methods such as setCamera it’s persisted. This fix resets the contentInsets.

* [ios] Fix pinch test.

* [ios] Update automaticallyAdjustsScrollViewInsets name and documentation.

* [ios] Update changelog.
2019-10-04 17:13:00 -07:00
Julian Rex
33a70100b8 [ios] Adds pointForCoordinate/coordinateForPoint to MGLMapSnapshotOverlay (#15746)
* [ios] Adds `pointForCoordinate:`/`coordinateForPoint:` to MGLMapSnapshotOverlay

* [ios] Adds PR #

* [ios, macos] Update file lists & mac contexts

* [macos] Fix for image scale in overlay.

* [ios] Updated change log based on PR feedback.
2019-10-04 13:51:40 -04:00
tobrun
910e34b855 [android] keep Mapbox.java when obfuscating code to allow look up from JNI 2019-10-04 17:18:37 +02:00
Julian Rex
cab756374f [ios] Fix layout of Scale bar components (#15703)
* [ios] Add failing tests for scale bar updates.

* [ios] Remove borderLayer

* [ios] Ensure bar sections have non-fractional width

* [ios] Add RTL override

* [ios] Update constraints/layout

* [ios] Invalidate scalebars size, after the parent's layout has happened (to ensure the view dimensions are correct when re-laying out the scale bar.

* [ios] Refactor layout

* [ios] Update changelog / remove commented code.

* [ios] Remove whitespace

* [ios] Stop integration tests asserting (when scale bar is hidden). Also reduces the # of calculations (since updateConstraints and layoutSubviews can be called outside of our control).

* [ios] Moves declaration of properties for testing.

* [ios] Removes redundant property attribute

* [ios] Updated change log
2019-10-04 11:15:20 -04:00
Mikhail Pozdnyakov
bef635765a [core] Decouple Scheduler interface from actor model
So that it is possible to schedule normal `std::function` and use `mapbox::base::WeakPtr`.
2019-10-04 17:42:21 +03:00
Alexander Shalamov
198e345339 [android] Check if Mapbox instance exists before creating default file source
This check is needed for mbgl-benchmark target, as it does not require Mapbox
instance, nor Android asset manager.
2019-10-04 13:18:23 +03:00
Mikhail Pozdnyakov
946b9d2281 [ios][android] Add change log entries 2019-10-04 13:16:54 +03:00
Mikhail Pozdnyakov
064c60cdca [core] Orchestration performance for styles with multiple sources
RenderOrchestrator holds a vector of ordered rendered layers,
in order to minimize calling of `getRenderLayer()`, which
could be quite expensive as it calculates hash of the layer Id.

This change improves orchestration performance in particular
for the styles that have multiple sources.

The `API_renderStill_multiple_sources` benchmark runs
approximately 70% faster with the changes applied.
2019-10-04 13:16:54 +03:00
Mikhail Pozdnyakov
ac18688824 [core][benchmark] Add API_renderStill_multiple_sources benchmark 2019-10-04 13:16:54 +03:00
Jordan Kiley
4b4e828647 [ios] Disable iOS code coverage script #15749 2019-10-03 11:07:41 -07:00
Igor Tarasov
10c14bee45 [android] - changelog for 8.5.0-alpha.1 (#15753)
* [android] Update changelog for v8.5.0-alpha.1
2019-10-03 17:00:27 +03:00
Łukasz Paczos
7475247782 [android] - remove projected meters per pixel and pixel ratio relation
The projected meters per pixel calculation is not dependent on the pixel ratio but rather the tile size, therefore, the division when fetching the value is not necessary.
2019-10-03 11:11:05 +02:00
Nadia Barbosa
daf8e1289c [ios] Podspec & changelog updates for v5.5.0-alpha.1 2019-10-02 13:38:51 -07:00