Commit Graph

499 Commits

Author SHA1 Message Date
Alexander Shalamov
c6f3cc8b60 [core] Implement image expression (#15877)
* [core] Bump gl-js version
* [core] Implement image expression
* [core] Use new image expression
* [core] Coerce image expression to / from string
* [core] Serialize evaluated image
* [core] Pass available images to layout
* [core] Pass images to evaluation context
* [core] Set available flag value based on image availability
* [core] Allow image coercion to boolean to indicate image availability
* [core] Coalesce image expression
* [core] Add image expression to next build system
* [core] Align serialization format and evaluated type with gl-js
* [core] Add images to expression evaluation method
* [core] Add support for Image expression to expression test runner
* [core] Unskip image expression tests
* [core] Update unit tests
* [core] Use image expression in annotation manager
* [core] Add string to ImageExpression conversion
* [core] Add image expression to expression dsl
* [core] Convert tokens for implicitly created Image literal
* [core] Fix clang format
* [core] Split generated style code lines that are over 120 characters
* [core] Add unit test for image expression equality
* [core] Add image property expression evaluation unit test
* [core] Unskip image expression render test
* [core] Skip 'in' expression tests
* [core] Ignore fill-pattern/update-feature-state render test
* [core] Rename Image::serialize to Image::toValue
2019-11-11 18:20:01 +02:00
Konstantin Käfer
2187980a87 [core] fix icon-text-fit
This fixes rendering by account for the 1px texture padding around icons that were stretched with icon-text-fit. We've added the 1px padding before, but didn't scale it accordingly when we are resizing the icon when it is stretched to fit the text. Adjusts the code to match the logic in GL JS.
2019-10-14 18:46:12 +02:00
Konstantin Käfer
9cac122c5c [core] map image type to string until we have a dedicated implementation 2019-10-14 18:46:12 +02:00
Dane Springmeyer
da490c2b90 bump to v5 (#15781) 2019-10-09 13:30:17 -07:00
Dane Springmeyer
d0281e3ca4 node package improvements (#15748)
* node package improvements

* npm run test-suite does not do anything anymore
2019-10-08 16:27:04 -07:00
Ansis Brammanis
dfca8fb214 [core] fix opacity interpolation for composition expressions (#15738)
port https://github.com/mapbox/mapbox-gl-js/pull/8818
2019-10-02 13:49:33 -04:00
Thiago Marcos P. Santos
c7bbd5bbef [core] Fix performance-move-const-arg 2019-09-25 18:59:07 +03:00
Juha Alanen
6b13c42314 [build] Fix clang format and tidy checks 2019-09-18 14:29:15 +03:00
Juha Alanen
7c4c091a2b [node] Add changelog entry for feature state APIs 2019-09-18 14:29:15 +03:00
Juha Alanen
693a104220 [node] enable feature state tests 2019-09-18 14:29:15 +03:00
Juha Alanen
a186e6a27d [node] Add support for feature state APIs 2019-09-18 14:29:15 +03:00
zmiao
0a219d182c [Core] Fix wrong maxzoom setting of tileSet when using URL source (#15581)
* [core] Take max/min zoom option from style if they are set

* [core] std::move input value

* [Core] Add changelogs

* [Core] Fix clang-format reported error

* [Core] fix clang-tidy reported error
2019-09-17 18:00:37 +03:00
Thiago Marcos P. Santos
c507cc4c8a [build] Disable a test that requires a debug build
Overdraw debug layer is only available on debug builds.
2019-09-17 12:28:55 +03:00
Rebecca Rice
53e56945eb [node] release v4.3.0 (#15428) 2019-09-11 21:48:34 -04:00
zmiao
81e62c8cc0 [Core] Update ChangeLog of Integer Overflow fix of pr #15560 (#15586)
*  Update ChangeLog

* Fix extra space
2019-09-09 11:52:47 +03:00
zmiao
f53143f1a1 [core] Fix Integer overflow when converting tileCoordinates to LatLon (#15560)
* [core] fix integer overflow

* [core] Add change log
2019-09-05 11:08:21 +03:00
Aleksandar Stojiljkovic
4ba1270dcc [core] DEMData: do decode on GPU (port mapbox/mapbox-gl-js#8694)
This is first part of work on porting mapbox/mapbox-gl-js#8694 - in follow up patch(es) it is required to remove CPU side copy using 2d canvas support on all supported platforms, similar to approach taken in gl.js  https://github.com/mapbox/mapbox-gl-js/pull/8694/files#diff-34dbe5f7de34dc4b9a8745dcde9bdc37R48

Decoding on CPU removed.
Padding is still done in DEMData() but, instead od doing it wwhile decoding, it is using memcpy to pad original values.

Rebase to latest mapbox-gl-js master and re-generate shaders.

Partly fixes: #15503
2019-08-30 11:18:55 +03:00
zmiao
6ef2710e5c [core] fix collisionBox alignment when Icon/text translation is enabled (#15467)
* add initial fix

* fix bug for collision circle

* refind code structure

* fix indentation

* update test

* refind code structure

* Add changelog

* Add comment for boolean
2019-08-30 08:24:03 +03:00
zmiao
482dfc501c Add changelog for fix of mixed SDF+non-SDF icon rendering in one layer (#15492)
* Add changelog for fix of mixed SDF+non-SDF icon rendering in one layer

* Add bracket for ios changelog number

* Add more brackets
2019-08-27 13:29:02 +03:00
Mikhail Pozdnyakov
f365dcece4 [render tests] gl-native baseline for debug/collision- tests 2019-08-26 13:55:15 +03:00
Mikhail Pozdnyakov
d0529e7b19 [render test] mapbox-gl-native baseline for text-pitch-alignment tests 2019-08-21 17:07:05 +03:00
Alexander Shalamov
1625aa0000 [ios][macos][android][node] Update changelog for icon-text-fit fixes 2019-08-20 12:31:02 +03:00
Alexander Shalamov
b1986ca51e [core] Unskip icon-text-fit render tests 2019-08-20 12:31:02 +03:00
Mikhail Pozdnyakov
8792e7c322 Enable text-variable-anchor/{pitched-rotated-debug|rotated-offset} render tests 2019-08-16 16:25:59 +03:00
zmiao
0f34eb7b25 Indroduce clusterProperty option for aggregation (#15287)
* indroduce clusterProperty option for aggregation

* remove unnecessary codes

* update geojson_option conversion

* fix reviewing findings
2019-08-16 15:03:48 +03:00
Alexander Shalamov
1cb30268d7 [core] Ignore updated icon-text-fit render tests 2019-08-15 18:25:10 +03:00
Alexander Shalamov
148d65bced [core][node] Serialize formatted expression's text-color option
This enables proper round-tripping for serialized format expression.
2019-08-15 18:25:10 +03:00
Alexander Shalamov
b330375aeb [core] Unskip text-rotate/with-offset fixed by #14932 2019-08-13 16:55:33 +03:00
Mikhail Pozdnyakov
0c0bee52cb Enable number format expression tests 2019-08-13 15:17:09 +03:00
Alexander Shalamov
75874cb546 [macos][ios][android][node] Add changelog entry for text-writing-mode layout property 2019-08-13 13:32:56 +03:00
Aleksandar Stojiljkovic
3852129d59 Enable render tests flaky on node-gcc8
We don't use node-gcc8 bot to run render tests and no need to have the tests ignored.
2019-08-07 10:39:04 +03:00
Aleksandar Stojiljkovic
8103a2b028 [core] Enable opaque pass for background layer. fix heatmap+background test.
Follow the approach from mapbox-gl-js for enabling opaque pass for background layer (same as for fill layer).

Fix combinations/heatmap-translucent--background-opaque render test.
2019-08-05 18:56:07 +03:00
Thiago Marcos P. Santos
1aa4776dc1 [tests] Bump GL JS to run render test for #15139
https://github.com/mapbox/mapbox-gl-js/pull/8510
2019-07-19 15:17:00 +02:00
Josh Erb
cdd47c0358 [node] v4.2.0 release 2019-07-15 10:13:47 -04:00
Aleksandar Stojiljkovic
4d84e52ce2 Enable ignored but passing run-time styling tests (#6745) 2019-07-09 17:53:34 +02:00
Aleksandar Stojiljkovic
2c5528e691 Fix layers rendering after fill-extrusion
This fixes following issues:
* Fix some false passing combinations/fill-extrusion-translucent--XXXX tests
* Fix and enable other, failing but ignored, combinations/fill-extrusion-translucent--XXXX tests
* Fix rendering of layers that are on top of fill-extrusion layers

state.getProjMatrix(nearClippedProjMatrix, 100) caused that tests with size 64x64 were not
rendering fill extrusions: far plane calculated as 96.9 and near plane set to 100 was the cause.
near plane is changed from hardcoded 100 to depend on state.getCameraToCenterDistance() - producing
similar value but one that follows max zoom.

This caused that e.g. combinations/fill-extrusion-translucent--fill-opaque was falsely passing as
only fill-opaque layer got rendered.

combinations/fill-extrusion-translucent--XXXX tests expose regression https://github.com/mapbox/mapbox-gl-native/issues/14844#issuecomment-503600034 in #14844, #14779.

Fix (opaquePassCutoff, is3D) is ported from https://github.com/mapbox/mapbox-gl-js/pull/7821

Fixes: #14844, #14779, #15039
2019-07-09 15:13:38 +02:00
Bruno de Oliveira Abinader
16f1854a9c [node] Parse 'sdf' option when adding an image 2019-07-04 11:45:10 +03:00
Juha Alanen
0ca8ea6f16 [core] Add number-format expression 2019-06-27 15:51:22 +03:00
Blake Thompson
a16c67d953 Fixes problems associated with node 10 and NAN (#14847)
* Fixes problems associated with node 10 and NAN

* Follow up removal of unnecessary linking to map object

* Remove header left over from debugging
2019-06-26 13:38:06 -05:00
Bruno de Oliveira Abinader
3b0e5a59a2 [core] Implement C++ render test runner 2019-06-25 20:10:21 +03:00
Tobrun
86b9c06c74 [node] - fix README type, granualar to granular (#14933) 2019-06-17 12:16:19 +02:00
Jason Wray
fc802daa62 [core] Ignore more flaky node render tests 2019-06-07 12:39:48 -07:00
Jason Wray
012e3931bf [core] Ignore flaky fill-pattern render tests 2019-06-04 10:43:44 -07:00
Juha Alanen
f9796d2a28 [core] Fix symbol rendering under opaque fill layers 2019-06-04 16:35:53 +03:00
Konstantin Käfer
7f9274035b [core] refactor program object creation 2019-05-28 16:11:05 +02:00
Thiago Marcos P. Santos
d60df973a6 [tests] Removed passing tests from the ignore list 2019-05-23 18:05:54 +03:00
Ander Conselvan de Oliveira
d502b72449 [core] Pass legacy/categorical/*-default expression tests
Handle categorical function default value properly in conversion to
expreexpression so related tests pass.
2019-05-21 12:14:22 +03:00
Ander Conselvan de Oliveira
1e620d3bd8 [core] Fix legacy/{interval,exponential}/*-default expression tests
Consider the function default value in interval and exponential
functions conversion.
2019-05-21 12:14:22 +03:00
Ander Conselvan de Oliveira
343df18954 [core] Fix some of the legacy interval function expression tests
The tests for conversion of legacy interval functions to expressions
expects that the first stop in the "step" expression be omitted.
2019-05-21 12:14:22 +03:00
Ander Conselvan de Oliveira
33cfd080c2 [core] Fix most identity function with default legacy expression tests
Add handling of default value to the conversion of legacy identity
functions. The color and enum tests still don't pass though.
2019-05-21 12:14:22 +03:00