Commit Graph

9 Commits

Author SHA1 Message Date
Aleksandar Stojiljkovic
ae38a22dc1 [core] Fix collision with content insets
Viewport center offset usage was wrongly submitted in #14664. It was part of alternative approach that used enlarged viewport. Existing and added tests were not sufficient to spot the regression, since the collision check padding is usually larger than the center offset x and y. Annotation picking has tolerance of only 10 pixels but no annotation integration test was using content insets.

Usage of offset is not needed because `posMatrix` in e.g. `CollisionIndex::projectPoint(const mat4& posMatrix, const Point<float>& point)` already incorporates center offset (projection matrix) and the code in current master was just offsetting all by the value.

Modified [ios] MGLAnnotationViewIntegrationTests.testSelectingAnnotationWithCenterOffset to use different insets. It verifies the fix.

Fixes [iOS] Annotations are not selectable (added via iosapp menu) #15106:

In case of #15106, view's original content insets is {top:88, bottom:34}, causing that center offset is {x:0, y:27} and selection with tolerance of 10 wouldn't select annotation.
After tapping the view, so that the header gets removed, view's content insets get changed to {top:44, bottom:34}, center offset is {x:0, y:5} and annotation selection would work, as described in #15106.

Fixes: #15106
2019-07-17 16:13:33 -07:00
Jason Wray
8a9567e072 [ios, macos] Deprecate methods in favor of new completion handler versions 2019-06-26 12:18:22 -07:00
Minh Nguyễn
f7f74a6deb [ios, macos] Added completion handlers to animated MGLMapView methods 2019-06-21 17:45:36 -07:00
Julian Rex
c40b7279a2 [ios] Fix failing annotation selection integration tests (#14976) 2019-06-21 20:34:33 -04:00
Julian Rex
c7d53676d0 [ios, core] Updates project for iOS SDK 12.2 / Always use vendored optional (#14241) 2019-03-27 09:58:41 -04:00
Julian Rex
b460efdf00 [ios] Partially offscreen annotations (without callouts) are no longer moved on-screen (#13727) 2019-01-22 17:45:06 -05:00
Nadia Barbosa
7b243392e3 [ios] Add delegate method to specify the user location annotation’s position
Update method name

More API drafting

Add deprecation flag

Add Swift delegate integration test

Update method name and documentation

Update deprecation notices

Update method name

Offset anchor point relative to contentFrame

Update docs

Only run through switch statement if delegate is unimplemented

Account for content inset + refactor logic

Adjust edgePaddingForFollowing

Fix Swift delegate integration test

Set up integration test

Set up test location manager

.

Remove unused file reference from test

Return CGPoint value from delegate method within integration test setup

Test anchor points

Make updateUserLocationAnnotationView public

Refactor test

Update test location manager

Changelog entry

Doc fixes
2018-10-02 18:28:53 -04:00
Jason Wray
737ebed7d5 [ios, tests] Bump most waitForExpectationsWithTimeout's to 5s
[skip firebase]

Bump MGLOfflineStorageTests timeouts to 5 seconds
2018-09-20 14:57:07 -07:00
Julian Rex
3710ef8810 [iOS] Update annotation view touch handling (with offsets) (#12234) 2018-07-09 10:01:11 -04:00