Commit Graph

39 Commits

Author SHA1 Message Date
zmiao
7424c4eecb Bump GL-JS
Backport GL-JS fix 'Hide glyphs behind the camera'(https://github.com/mapbox/mapbox-gl-js/pull/9229)
2020-02-11 11:05:18 +02:00
Alexander Shalamov
0475c89140 [core] Update baselines 2020-02-11 10:40:30 +02:00
Mikhail Pozdnyakov
1f5c6beb64 [tile mode] Improvements in symbol placement on tile borders
This change fixes the following problems:
1) Before this change, when multiple symbols were grouped close to the
tile borders, different tiles could place different symbols, because each
tile arbitrary assigned feature ids, and these ids defined the placement
order being applied. This caused artifacts at the tile boundaries.

With this change, in tile mode the placement order of two symbols crossing
a tile border is defined by their anchor `y` values. It means that the
symbols are being placed the same order across all the tiles.

2) Before this change, the engine did not place with priority the symbols
crossing the borders between two neighboring tiles. Now it does, and it
improves a lot symbol placement stability in the tile map mode.
2020-02-03 21:26:35 +02:00
Thiago Marcos P. Santos
0de6ffc383 [build] Cleanup CircleCI configuration
- Remove the legacy build jobs
- Remove the next- namespace.
2020-01-28 00:44:07 +02:00
Mikhail Pozdnyakov
951b90c778 [tile mode] Fix variable symbols placement
This commit allows the variable symbols to cross the tile border only
if their anchor is the first anchor from the `text-variable-anchor` list.
2020-01-27 17:51:07 +02:00
Alexander Shalamov
7e88e04d60 [metrics] Upbdate baselines for test app binary size 2020-01-27 14:25:37 +03:00
zmiao
429292fb98 [test-runner] Add iOS RenderTestRunner test metrics (#16139)
* [test-runner] Add iOS RenderTestRunner test metrics

* [test-runner] Add ios probe metrics
2020-01-24 15:45:47 +02:00
zmiao
1ade6c7784 [test-runner] Enable IOS RenderTestRunner and run it on Firebase (#16111)
* [test-runner] Setup iOS RenderTestRunner

* [test-runner] Make app runnable on firebase

* Add iOS platform dependent expectation and ignores; Run prepare script via cmake

* Make RenderTestRunner report test status
2020-01-21 23:23:35 +02:00
Alexander Shalamov
96f953c5b2 [test-runner] Add stretchable icons resources to cache 2020-01-15 15:02:11 +02:00
Alexander Shalamov
adda95c510 [metrics] Baselines for stretchable icons feature 2020-01-15 15:02:11 +02:00
Konstantin Käfer
5a1e4c6b81 [core] implement stretchable icons for icon-text-fit 2020-01-15 15:02:11 +02:00
Alexander Shalamov
879c44f661 [core] Modularize FileSource codebase (#15768)
* [core] Introduce FileSourceManager and use it for default platform impl

  - Add `FileSourceManager` interface that provides access to `FileSource`
    instances and means of registering / unregistering `FileSource` factories
  - Split `DefaultFileSource` into smaller parts
  - Add `DatabaseFileSource` interface and it's default implementation
  - Remove inter-dependencies between concrete `FileSource` classes

* [build] Add files to next build system

* [core] Add generic property setters / getters

* [core] Remove setOnlineStatus from OnlineFileSource interface

* [core] Hide threading implementation details from DatabaseFileSource interface

* [core] Make DB file source methods virtual

* [core] Add documentation for DatabaseFileSource and rename one method

* [core] Use simple callback instead of ActorRef

* [core] Remove ActorRef from OnlineFileSource public header

* [core] Add callback to FileSource::forward async API

* [core] Pass OfflineRegionDefinition by value

* [core] Update tests to use modular file sources

* [core] Update unit tests

* [core] Update unit tests after rebase

* [core] Backport low prio fix for cached requests

* [core] Backport pack database

* [core] Return removed factory from unRegisterFileSourceFactory

* [core] Rename shadowed args in onlinefilesource

* [core] Remove simple std::function callback aliases

* [core] Expose online file source property keys in public header file

* [test-runner] Add proxy file source test runner

* [cache] Update mbgl-cache utility to use new file source

* [metrics] Rebaseline binary size metrics

* [offline] Update offline utility

* [core] Update changelog
2020-01-13 10:57:23 +02:00
Thiago Marcos P. Santos
87013ad6e1 [metrics] Add new baselines
More accurate now since everything goes through the FileSource.
2020-01-08 13:07:12 +02:00
Thiago Marcos P. Santos
f306957a6d [metrics] Add 2 tests to the ignore list
Need further investigation on why these tests are failing
after we started to use the cache database.
2020-01-08 13:07:12 +02:00
Thiago Marcos P. Santos
13c5505572 [metrics] Use the cache database instead of file paths for fixtures
Now that we use a cache, we no longer need "asset_path" and
"vendor_path".
2020-01-08 13:07:12 +02:00
Mikhail Pozdnyakov
c46f0baa57 Update change log and binary size metrics 2020-01-08 12:43:26 +02:00
Mikhail Pozdnyakov
a46b1a4e4f [test] Update render test expectations 2020-01-08 12:43:26 +02:00
Mikhail Pozdnyakov
205f0e2f72 [tests] Update all-anchors-tile-map-mode expectations 2019-12-18 13:48:52 +02:00
Alexander Shalamov
00866c348e [metrics] Add baselines for a new test 2019-12-17 15:46:10 +02:00
Ansis Brammanis
aa543e43e5 [core] Fix really overscaled lines #16018 2019-12-17 15:46:10 +02:00
Alexander Shalamov
d883b740a2 [metrics] Add new baselines 2019-12-17 14:25:19 +02:00
Alexander Shalamov
ffb4998d28 [core] Unskip render tests 2019-12-17 14:25:19 +02:00
Thiago Marcos P. Santos
4016ad0f67 [metrics] Remove **/token from .gitignore
This explains why these tests were not being rebaselined...
2019-12-17 11:46:04 +03:00
Thiago Marcos P. Santos
e298435206 [metrics] Add new baselines for Linux Clang8 and macOS 2019-12-16 22:52:01 +02:00
Thiago Marcos P. Santos
893363f382 [metrics] Rebaseline Linux GCC8 metrics
Sames as for Android, remove ignored and probes not in use.
2019-12-16 22:52:01 +02:00
Thiago Marcos P. Santos
ef9444debd [metrics] Rebaseline Android tests
This was done using the new baseline bot :-)

- Removed metrics from ignored tests.
- Removed memory metrics for render tests, not in use.
2019-12-16 22:52:01 +02:00
Thiago Marcos P. Santos
b7e26d1ff2 [metrics] Delete test that doesn't make sense
This test is ignored because we expect it to "ignore but fail".

But it will generate a fatal error because it doesn't have the
metrics file, thus should have been skipped instead.
2019-12-16 22:52:01 +02:00
Thiago Marcos P. Santos
8869d09b25 [build] Collect and publish new baselines
Also fail the bot in case there are new baselines.
2019-12-16 22:52:01 +02:00
Thiago Marcos P. Santos
970cabe0eb [build] Reorganize the render tests
Move everything that might collect metrics to the metrics/ directory,
the only test manifests inside the render-test/ directory are the
unit tests of the probes.
2019-12-16 22:52:01 +02:00
zmiao
f848f07ad9 [metrics] Run Android RenderTestRunner bot in rebaseline mode (#16036) 2019-12-11 11:50:27 +02:00
Alexander Shalamov
7eee124677 [metrics] Create gcc8-release metrics configuration 2019-12-09 17:53:34 +02:00
Thiago Marcos P. Santos
71054c8b60 [glfw] Add static render test creator
Press F1 to create a render test for the current view.

The test will be created at the base folder (current if nothing is
provided) + /NNNN (the next free entry).
2019-12-09 16:09:16 +02:00
Alexander Shalamov
1ad1358c8e [metrics] Rebaseline linux-gcc8 mbgl-offline filesize metric 2019-12-02 17:11:49 +02:00
Alexander Shalamov
154d95a626 [metrics] Rebaseline filesize metric for linux-clang8 2019-12-02 17:11:49 +02:00
Thiago Marcos P. Santos
af0d46c367 [android] Use icf=all
Chromium is using it for a while on ARM.

https://codereview.chromium.org/1153143004/patch/20001/30002
2019-11-29 13:42:18 +02:00
Thiago Marcos P. Santos
e3d1daaf66 [metrics] Measure compressed size for Android
Because what metters is the size we add to the APK.
2019-11-28 19:18:17 +02:00
Thiago Marcos P. Santos
316f1d0ad1 [metrics] Add new baselines. 2019-11-28 12:34:22 +02:00
Thiago Marcos P. Santos
d13562252d [metrics] Isolate binary size metrics
Will give us a better view of what changed and by how much. Otherwise
the test stops at the first failure.
2019-11-28 12:34:22 +02:00
Thiago Marcos P. Santos
8d163c159f [metrics] Add binary size metrics
This test will check the size of the tools and shared libraries
built from previous bots in a single run.

We will have +/- 1% acceptable variance before the test fails.
2019-11-27 18:32:58 +02:00