Commit Graph

84 Commits

Author SHA1 Message Date
Gali Nelle
fea8a83e7f Introduce a mean to add render features in layers with no sources
This change also uses the support in the LocationIndicator layer, to
return a point feature when queried in correspondence of the location
indicator.
2020-04-17 22:26:32 +03:00
Thiago Marcos P. Santos
b190e12f5b [metrics] Ignore location indicator on iOS until we move to gfx::
After that, it will be more portable.
2020-04-17 17:09:16 +03:00
Thiago Marcos P. Santos
7f0c13967d [baselines] Update binary size baselines
New image, new libraries we link against.
2020-04-16 19:31:23 +03:00
Gali Nelle
545a09fcb3 Fix LocationIndicator not updating image sizes when image manager content changes 2020-04-16 11:56:02 +03:00
Thiago Marcos P. Santos
4da54d61cc [build] Ignore location indicator on iOS until we port to ::gfx
Remove the ignore after https://github.com/mapbox/mapbox-gl-native/issues/16401 is done.
2020-04-15 20:37:10 +03:00
Juha Alanen
4a8dea7527 [metrics] Add baselines for benchmark tests 2020-04-15 19:11:28 +03:00
Alexander Shalamov
81e1f89c8c Update baselines for macos bot 2020-04-15 10:42:11 -04:00
Mikhail Pozdnyakov
cf2bccdcc2 Update baselines 2020-04-14 22:30:40 +03:00
Andrew Hay Kurtz
0c95acf103 Enable 'circle-sort-key' layout property 2020-04-14 22:30:40 +03:00
Gali Nelle
209857f8ac Fix LocationIndicator Layer
This changes image size properties to be scales instead of pixel sizes.
The commit also adds fixes for handling image updates with the same ID,
adds tests for expressions in paint properties, as well as tests for using images
with pixel ratio greater than 1.
Finally it moves image-tilt-displacement and perspective-compensation properties
from layout to paint properties, and includes other minor cleanups.
2020-04-10 00:15:43 +03:00
Gali Nelle
fe9ba477a8 Update baselines after addition of Location Indicator layer 2020-04-08 14:00:26 +03:00
Gali Nelle
9a55c282fe Add LocationIndicatorLayer
New key is "G" in mbgl-glfw, cycling between no puck, centered
in the viewport and positioned in Tokyo.
2020-04-08 14:00:26 +03:00
Mikhail Pozdnyakov
39cdbb63c6 Update render tests expectations 2020-04-08 11:19:37 +03:00
zmiao
bf4c7340f3 [build] Fix undefined behavour sanitizer (#16375)
* [build] Fix integer overflow runtime error for core part

Temporarily remove circle ci UBSAN build precondition

* [build] Enable all of the ubsans

[build] Check runtime error

[build] Update UBSAN_OPTION

* [build] Add UBSAN blacklist

[build] Ignore system libraries

[build] Ignore vendor library

* [build] Fix implicit conversion runtime error in core

* [build] Fix division by zero runtime error

* [build] Add unfixed error to ubsan blacklist

* [build] Make UBSAN halt on error

Revert "Temporary remove build precondition"

* [build] Fix division by zero error

* [build] Make UBSAN officially work without FIXME prefix

* [build] Fix implicit conversion from int64_t to uint64_t

* [build] Rename style test json file name

* Address review findings
2020-04-07 16:30:30 +03:00
Igor Tarasov
338cfd1b33 [android] [build] [ci] Move Android JNI bindings code to mapbox-gl-native-android repo. (#16356) 2020-04-02 18:36:55 +03:00
Kevin Li
3f45b0a24b [android] Add jni binding for styleable snapshotter (#16286)
* [android] Add jni binding for styleable snapshotter

* Remove Map parameter from factories

- remove unused map from factory interfaces. Map is only needed for repaint.

* implement addlayer function

* Implement addsource function for snapshotter

* Implement addImages function

* format codes

* Apply baseline

* Update CHANGELOG.md

* Update map_snapshotter.cpp

* Destroy snapshotter on the thread it was created

* Activate file sources in start

* Use custom deleter for snapshotter

* format codes

* Release snapshotter pointer to deleting lambda

* Clang format

* Update CHANGELOG.md

* Fix review comments

* FIx review comments

Co-authored-by: Alexander Shalamov <alexander.shalamov@mapbox.com>
2020-03-24 14:33:54 +08:00
Mikhail Pozdnyakov
2a8e89d355 Update metrics 2020-03-20 11:43:59 +02:00
zmiao
f3cf855894 Update metrics 2020-03-19 14:40:49 +02:00
Mikhail Pozdnyakov
0f5e5311fa Update metrics 2020-03-18 20:14:15 +02:00
Mikhail Pozdnyakov
915c412c17 Update metrics 2020-03-12 23:35:55 +02:00
Mikhail Pozdnyakov
0bf8fdae9c [core] Collision index uses doubled padding with the tilted view 2020-03-12 23:35:55 +02:00
Mikhail Pozdnyakov
04d840de53 Update baselines 2020-03-12 15:25:28 +02:00
Mikhail Pozdnyakov
5577c37495 [tests] Enable left-top-right-bottom-offset-tile-map-mode test
Rebase its results after 3ca26ed2a6
2020-03-12 15:25:28 +02:00
Thiago Marcos P. Santos
639434b3ef [metrics] Updated baselines 2020-03-11 21:53:12 +02:00
Mikhail Pozdnyakov
901a960487 Update baselines 2020-03-11 16:51:45 +02:00
Alexander Shalamov
33b4fea105 [core] Update baselines 2020-03-07 10:14:18 +02:00
Mikhail Pozdnyakov
35fc402d34 [render tests] Temporarily ignore tile-mode/streets-v11
Due to flaky metrics results
2020-03-06 23:46:52 +02:00
Mikhail Pozdnyakov
bd1fcfd314 [render tests] Add resources for tile-mode/streets-v11 2020-03-06 23:46:52 +02:00
Mikhail Pozdnyakov
b5eed1cd19 Bump mapbox-gl-js
so that it includes `tile-mode/streets-v11` test
2020-03-06 23:46:52 +02:00
Juha Alanen
987f214273 [build] Collect code coverage from macOS builds
Collect coverage from development builds and add a nightly build
to collect metrics.
2020-03-06 13:52:00 +02:00
Alexander Shalamov
55ea01252d [core] Update binary size metrics for test apps 2020-03-05 17:43:37 +02:00
Juha Alanen
ffe95ec7d3 [test] Add test manifest for the nightly build
Use the same test manifest for the development and nightly
coverage CI builds. Add manifest for the nightly build by
creating a symbolic link to the existing manifest.
2020-03-03 13:30:53 +02:00
Minh Nguyễn
8229bd1090 Updated binary size baselines 2020-02-27 17:14:20 -08:00
Alexander Shalamov
616fb48fd1 [core] Update baselines for gl-native tools 2020-02-26 18:15:23 +02:00
zmiao
385fcd52a0 [test-runner] Add new metrics 2020-02-21 21:39:48 +02:00
Kevin Li
02274e7601 [core] Implement 'in' expression. (#16162)
* Implement in.cpp

* Fix review comments.

* Add expression_equality test for 'in'

* Fix review comments.

* [core] Update changelog.

* [core] Update mapbox-gl-js

* [core] Ignore render-tests/debug/padding

* [core] Update baseline.
2020-02-15 17:36:57 +08:00
Alexander Shalamov
9e14572762 [core] Update baselines 2020-02-14 17:34:00 +02:00
Karim Naaji
f3f0aefead Apply new baselines 2020-02-14 12:56:54 +02:00
Karim Naaji
88da1ad6c7 Whitelist render-tests/line-dasharray/zero-length-gap 2020-02-14 12:56:54 +02:00
zmiao
8e0c9671ba [metrics] Add new metric baselines 2020-02-12 17:35:18 +02:00
zmiao
759dfe8bf6 [core] Support [within expression] with layout property 2020-02-12 17:35:18 +02:00
zmiao
4579e1d6c4 Add metric baselines for within expression/render tests 2020-02-12 12:24:05 +02:00
zmiao
f4250afd24 Update baselines 2020-02-12 12:24:05 +02:00
Mikhail Pozdnyakov
98f99e0743 Update metrics 2020-02-11 14:34:46 +02:00
zmiao
146e0ac8ed Add new metric baselines 2020-02-11 11:05:18 +02:00
zmiao
7424c4eecb Bump GL-JS
Backport GL-JS fix 'Hide glyphs behind the camera'(https://github.com/mapbox/mapbox-gl-js/pull/9229)
2020-02-11 11:05:18 +02:00
Alexander Shalamov
0475c89140 [core] Update baselines 2020-02-11 10:40:30 +02:00
Mikhail Pozdnyakov
1f5c6beb64 [tile mode] Improvements in symbol placement on tile borders
This change fixes the following problems:
1) Before this change, when multiple symbols were grouped close to the
tile borders, different tiles could place different symbols, because each
tile arbitrary assigned feature ids, and these ids defined the placement
order being applied. This caused artifacts at the tile boundaries.

With this change, in tile mode the placement order of two symbols crossing
a tile border is defined by their anchor `y` values. It means that the
symbols are being placed the same order across all the tiles.

2) Before this change, the engine did not place with priority the symbols
crossing the borders between two neighboring tiles. Now it does, and it
improves a lot symbol placement stability in the tile map mode.
2020-02-03 21:26:35 +02:00
Thiago Marcos P. Santos
0de6ffc383 [build] Cleanup CircleCI configuration
- Remove the legacy build jobs
- Remove the next- namespace.
2020-01-28 00:44:07 +02:00
Mikhail Pozdnyakov
951b90c778 [tile mode] Fix variable symbols placement
This commit allows the variable symbols to cross the tile border only
if their anchor is the first anchor from the `text-variable-anchor` list.
2020-01-27 17:51:07 +02:00