From fb2338cecab3a53c3011cbc541861b5259d76aea Mon Sep 17 00:00:00 2001 From: Tobrun Date: Tue, 11 Oct 2016 15:53:16 +0200 Subject: [PATCH] [android] - close response body to avoid connection leak (#6650) --- .../com/mapbox/mapboxsdk/telemetry/MapboxEventManager.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/telemetry/MapboxEventManager.java b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/telemetry/MapboxEventManager.java index 67eb51fd8..7d2229260 100644 --- a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/telemetry/MapboxEventManager.java +++ b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/telemetry/MapboxEventManager.java @@ -634,6 +634,8 @@ public class MapboxEventManager { return null; } + Response response = null; + try { // Send data // ========= @@ -742,13 +744,16 @@ public class MapboxEventManager { .header("User-Agent", userAgent) .post(body) .build(); - Response response = client.newCall(request).execute(); + response = client.newCall(request).execute(); Log.d(TAG, "response code = " + response.code() + " for events " + events.size()); } catch (Exception e) { Log.e(TAG, "FlushTheEventsTask borked: " + e); e.printStackTrace(); } finally { + if (response != null && response.body() != null) { + response.body().close(); + } // Reset Events // ============ events.removeAllElements();