tei/MapLibreParticleLab
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pointer ⇢ reference

Browse Source
This commit is contained in:
John Firebaugh
2015-04-13 14:37:57 -07:00
parent 9a0005fdea
commit f4adef1889
8 changed files with 15 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/mbgl/storage/asset_request.hpp
View File

@@ -7,7 +7,7 @@ namespace mbgl {
class AssetRequest : public SharedRequestBase {
public:
AssetRequest(DefaultFileSource::Impl *source, const Resource &resource);
AssetRequest(DefaultFileSource::Impl &source, const Resource &resource);
void start(uv_loop_t *loop, std::shared_ptr<const Response> response = nullptr);
void cancel();

4
src/mbgl/storage/default_file_source.cpp
View File

@@ -89,9 +89,9 @@ void DefaultFileSource::Impl::add(Request* req, uv_loop_t* loop) {
if (!sharedRequest) {
// There is no request for this URL yet. Create a new one and start it.
if (algo::starts_with(resource.url, "asset://")) {
sharedRequest = new AssetRequest(this, resource);
sharedRequest = new AssetRequest(*this, resource);
} else {
sharedRequest = new HTTPRequest(this, resource);
sharedRequest = new HTTPRequest(*this, resource);
}
const bool inserted = pending.emplace(resource, sharedRequest).second;

2
src/mbgl/storage/http_request.hpp
View File

@@ -7,7 +7,7 @@ namespace mbgl {
class HTTPRequest : public SharedRequestBase {
public:
HTTPRequest(DefaultFileSource::Impl *source, const Resource &resource);
HTTPRequest(DefaultFileSource::Impl &source, const Resource &resource);
void start(uv_loop_t *loop, std::shared_ptr<const Response> response = nullptr);
void cancel();

14
src/mbgl/storage/shared_request_base.hpp
View File

@@ -26,7 +26,7 @@ protected:
MBGL_STORE_THREAD(tid)
public:
SharedRequestBase(DefaultFileSource::Impl *source_, const Resource &resource_)
SharedRequestBase(DefaultFileSource::Impl &source_, const Resource &resource_)
: resource(resource_), source(source_) {}
virtual void start(uv_loop_t *loop, std::shared_ptr<const Response> response = nullptr) = 0;
@@ -35,9 +35,7 @@ public:
void notify(std::shared_ptr<const Response> response, FileCache::Hint hint) {
MBGL_VERIFY_THREAD(tid);
if (source) {
source->notify(this, observers, response, hint);
}
source.notify(this, observers, response, hint);
}
void subscribe(Request *request) {
@@ -53,10 +51,8 @@ public:
if (abandoned()) {
// There are no observers anymore. We are initiating cancelation.
if (source) {
// First, remove this SharedRequestBase from the source.
source->notify(this, observers, nullptr, FileCache::Hint::No);
}
// First, remove this SharedRequestBase from the source.
source.notify(this, observers, nullptr, FileCache::Hint::No);
// Then, initiate cancelation of this request
cancel();
@@ -95,7 +91,7 @@ public:
const Resource resource;
protected:
DefaultFileSource::Impl *source = nullptr;
DefaultFileSource::Impl &source;
private:
std::set<Request *> observers;