Clarify padding order in the Java API (#2990)

This commit is contained in:
Ian Wagner
2024-11-08 09:48:30 +09:00
committed by GitHub
parent cad43feb12
commit ed353f24bf
3 changed files with 5 additions and 2 deletions

View File

@@ -1546,7 +1546,7 @@ public final class MapLibreMap {
* Get a camera position that fits a provided bounds and padding and the current camera tilt and bearing.
*
* @param latLngBounds the bounds to set the map with
* @param padding the padding to apply to the bounds
* @param padding the padding to apply to the bounds (in left, top, right, bottom order)
* @return the camera position that fits the bounds and padding
*/
@Nullable
@@ -1579,7 +1579,7 @@ public final class MapLibreMap {
* Get a camera position that fits a provided bounds, padding, bearing and tilt.
*
* @param latLngBounds the bounds to set the map with
* @param padding the padding to apply to the bounds
* @param padding the padding to apply to the bounds (in left, top, right, bottom order)
* @param bearing the bearing to transform the camera position with
* @param tilt to transform the camera position with
* @return the camera position that fits the bounds, bearing and tilt

View File

@@ -55,6 +55,7 @@ interface NativeMap {
@NonNull
CameraPosition getCameraPosition();
// Note for implementors: the ordering of the padding is left, top, right, bottom
CameraPosition getCameraForLatLngBounds(@NonNull LatLngBounds bounds, int[] padding, double bearing, double pitch);
CameraPosition getCameraForGeometry(@NonNull Geometry geometry, int[] padding, double bearing, double pitch);

View File

@@ -284,6 +284,8 @@ final class NativeMapView implements NativeMap {
if (checkState("getCameraForLatLngBounds")) {
return null;
}
// Note that we have to juggle things a bit to match the ordering of arguments
// to match the NativeMapView C++ interface.
return nativeGetCameraForLatLngBounds(
bounds,
padding[1] / pixelRatio,