diff --git a/bin/render.cpp b/bin/render.cpp index 70571f7f7..a43bf32dd 100644 --- a/bin/render.cpp +++ b/bin/render.cpp @@ -86,7 +86,7 @@ int main(int argc, char *argv[]) { HeadlessView view(pixelRatio, width, height); Map map(view, fileSource, MapMode::Still); - map.setStyleJSON(style, "."); + map.setStyleJSON(style); map.setClasses(classes); map.setLatLngZoom({ lat, lon }, zoom); diff --git a/include/mbgl/map/map.hpp b/include/mbgl/map/map.hpp index b44b53ff9..f805680b7 100644 --- a/include/mbgl/map/map.hpp +++ b/include/mbgl/map/map.hpp @@ -57,8 +57,8 @@ public: bool hasClass(const std::string&) const; std::vector getClasses() const; - void setStyleURL(const std::string& url); - void setStyleJSON(const std::string& json, const std::string& base = ""); + void setStyleURL(const std::string&); + void setStyleJSON(const std::string&); std::string getStyleURL() const; std::string getStyleJSON() const; diff --git a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/NativeMapView.java b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/NativeMapView.java index 8380d33d1..6c092ee0c 100755 --- a/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/NativeMapView.java +++ b/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/NativeMapView.java @@ -194,11 +194,7 @@ final class NativeMapView { } public void setStyleJson(String newStyleJson) { - setStyleJson(newStyleJson, ""); - } - - public void setStyleJson(String newStyleJson, String base) { - nativeSetStyleJson(mNativeMapViewPtr, newStyleJson, base); + nativeSetStyleJson(mNativeMapViewPtr, newStyleJson); } public String getStyleJson() { @@ -528,8 +524,7 @@ final class NativeMapView { private native void nativeSetStyleUrl(long nativeMapViewPtr, String url); - private native void nativeSetStyleJson(long nativeMapViewPtr, - String newStyleJson, String base); + private native void nativeSetStyleJson(long nativeMapViewPtr, String newStyleJson); private native String nativeGetStyleJson(long nativeMapViewPtr); diff --git a/platform/android/src/jni.cpp b/platform/android/src/jni.cpp index 5c0f7b153..e79689d7a 100755 --- a/platform/android/src/jni.cpp +++ b/platform/android/src/jni.cpp @@ -427,13 +427,11 @@ void nativeSetStyleUrl(JNIEnv *env, jni::jobject* obj, jlong nativeMapViewPtr, j nativeMapView->getMap().setStyleURL(std_string_from_jstring(env, url)); } -void nativeSetStyleJson(JNIEnv *env, jni::jobject* obj, jlong nativeMapViewPtr, - jni::jstring* newStyleJson, jni::jstring* base) { +void nativeSetStyleJson(JNIEnv *env, jni::jobject* obj, jlong nativeMapViewPtr, jni::jstring* newStyleJson) { mbgl::Log::Debug(mbgl::Event::JNI, "nativeSetStyleJSON"); assert(nativeMapViewPtr != 0); NativeMapView *nativeMapView = reinterpret_cast(nativeMapViewPtr); - nativeMapView->getMap().setStyleJSON(std_string_from_jstring(env, newStyleJson), - std_string_from_jstring(env, base)); + nativeMapView->getMap().setStyleJSON(std_string_from_jstring(env, newStyleJson)); } jni::jstring* nativeGetStyleJson(JNIEnv *env, jni::jobject* obj, jlong nativeMapViewPtr) { @@ -1686,7 +1684,7 @@ extern "C" JNIEXPORT jint JNI_OnLoad(JavaVM *vm, void *reserved) { MAKE_NATIVE_METHOD(nativeSetClasses, "(JLjava/util/List;)V"), MAKE_NATIVE_METHOD(nativeGetClasses, "(J)Ljava/util/List;"), MAKE_NATIVE_METHOD(nativeSetStyleUrl, "(JLjava/lang/String;)V"), - MAKE_NATIVE_METHOD(nativeSetStyleJson, "(JLjava/lang/String;Ljava/lang/String;)V"), + MAKE_NATIVE_METHOD(nativeSetStyleJson, "(JLjava/lang/String;)V"), MAKE_NATIVE_METHOD(nativeGetStyleJson, "(J)Ljava/lang/String;"), MAKE_NATIVE_METHOD(nativeSetAccessToken, "(JLjava/lang/String;)V"), MAKE_NATIVE_METHOD(nativeGetAccessToken, "(J)Ljava/lang/String;"), diff --git a/platform/node/src/node_map.cpp b/platform/node/src/node_map.cpp index e56f31b0e..165e27b66 100644 --- a/platform/node/src/node_map.cpp +++ b/platform/node/src/node_map.cpp @@ -188,7 +188,7 @@ NAN_METHOD(NodeMap::Load) { } try { - nodeMap->map->setStyleJSON(style, "."); + nodeMap->map->setStyleJSON(style); } catch (const std::exception &ex) { return Nan::ThrowError(ex.what()); } diff --git a/src/mbgl/map/map.cpp b/src/mbgl/map/map.cpp index ec961a648..d5f5574d5 100644 --- a/src/mbgl/map/map.cpp +++ b/src/mbgl/map/map.cpp @@ -43,7 +43,7 @@ public: void update(); void render(); - void loadStyleJSON(const std::string& json, const std::string& base); + void loadStyleJSON(const std::string&); View& view; FileSource& fileSource; @@ -297,13 +297,7 @@ void Map::setStyleURL(const std::string& url) { impl->style = std::make_unique