diff --git a/cmake/core-files.cmake b/cmake/core-files.cmake index f066f28e1..d9a475785 100644 --- a/cmake/core-files.cmake +++ b/cmake/core-files.cmake @@ -160,7 +160,6 @@ set(MBGL_CORE_FILES src/mbgl/renderer/bucket.hpp src/mbgl/renderer/bucket_parameters.cpp src/mbgl/renderer/bucket_parameters.hpp - src/mbgl/renderer/cascade_parameters.hpp src/mbgl/renderer/cross_faded_property_evaluator.cpp src/mbgl/renderer/cross_faded_property_evaluator.hpp src/mbgl/renderer/data_driven_property_evaluator.hpp @@ -192,6 +191,7 @@ set(MBGL_CORE_FILES src/mbgl/renderer/tile_parameters.hpp src/mbgl/renderer/tile_pyramid.cpp src/mbgl/renderer/tile_pyramid.hpp + src/mbgl/renderer/transition_parameters.hpp src/mbgl/renderer/update_parameters.hpp # renderer/buckets diff --git a/src/mbgl/renderer/layers/render_background_layer.cpp b/src/mbgl/renderer/layers/render_background_layer.cpp index 50ec91d33..83ec7bf2d 100644 --- a/src/mbgl/renderer/layers/render_background_layer.cpp +++ b/src/mbgl/renderer/layers/render_background_layer.cpp @@ -18,8 +18,8 @@ std::unique_ptr RenderBackgroundLayer::createBucket(const BucketParamete return nullptr; } -void RenderBackgroundLayer::cascade(const CascadeParameters ¶meters) { - unevaluated = impl().paint.cascade(parameters, std::move(unevaluated)); +void RenderBackgroundLayer::transition(const TransitionParameters ¶meters) { + unevaluated = impl().paint.transition(parameters, std::move(unevaluated)); } void RenderBackgroundLayer::evaluate(const PropertyEvaluationParameters ¶meters) { diff --git a/src/mbgl/renderer/layers/render_background_layer.hpp b/src/mbgl/renderer/layers/render_background_layer.hpp index c2dfc2736..0fba3d2bb 100644 --- a/src/mbgl/renderer/layers/render_background_layer.hpp +++ b/src/mbgl/renderer/layers/render_background_layer.hpp @@ -11,7 +11,7 @@ public: RenderBackgroundLayer(Immutable); ~RenderBackgroundLayer() final = default; - void cascade(const CascadeParameters&) override; + void transition(const TransitionParameters&) override; void evaluate(const PropertyEvaluationParameters&) override; bool hasTransition() const override; diff --git a/src/mbgl/renderer/layers/render_circle_layer.cpp b/src/mbgl/renderer/layers/render_circle_layer.cpp index b7a2749e1..a8595ce61 100644 --- a/src/mbgl/renderer/layers/render_circle_layer.cpp +++ b/src/mbgl/renderer/layers/render_circle_layer.cpp @@ -19,8 +19,8 @@ std::unique_ptr RenderCircleLayer::createBucket(const BucketParameters& return std::make_unique(parameters, layers); } -void RenderCircleLayer::cascade(const CascadeParameters& parameters) { - unevaluated = impl().paint.cascade(parameters, std::move(unevaluated)); +void RenderCircleLayer::transition(const TransitionParameters& parameters) { + unevaluated = impl().paint.transition(parameters, std::move(unevaluated)); } void RenderCircleLayer::evaluate(const PropertyEvaluationParameters& parameters) { diff --git a/src/mbgl/renderer/layers/render_circle_layer.hpp b/src/mbgl/renderer/layers/render_circle_layer.hpp index 64322487f..4ae7399ad 100644 --- a/src/mbgl/renderer/layers/render_circle_layer.hpp +++ b/src/mbgl/renderer/layers/render_circle_layer.hpp @@ -11,7 +11,7 @@ public: RenderCircleLayer(Immutable); ~RenderCircleLayer() final = default; - void cascade(const CascadeParameters&) override; + void transition(const TransitionParameters&) override; void evaluate(const PropertyEvaluationParameters&) override; bool hasTransition() const override; diff --git a/src/mbgl/renderer/layers/render_custom_layer.hpp b/src/mbgl/renderer/layers/render_custom_layer.hpp index d44843309..2f7c2d323 100644 --- a/src/mbgl/renderer/layers/render_custom_layer.hpp +++ b/src/mbgl/renderer/layers/render_custom_layer.hpp @@ -10,7 +10,7 @@ public: RenderCustomLayer(Immutable); ~RenderCustomLayer() final = default; - void cascade(const CascadeParameters&) final {} + void transition(const TransitionParameters&) final {} void evaluate(const PropertyEvaluationParameters&) override; bool hasTransition() const override; diff --git a/src/mbgl/renderer/layers/render_fill_extrusion_layer.cpp b/src/mbgl/renderer/layers/render_fill_extrusion_layer.cpp index fa0b27cf9..551fcc5fc 100644 --- a/src/mbgl/renderer/layers/render_fill_extrusion_layer.cpp +++ b/src/mbgl/renderer/layers/render_fill_extrusion_layer.cpp @@ -19,8 +19,8 @@ std::unique_ptr RenderFillExtrusionLayer::createBucket(const BucketParam return std::make_unique(parameters, layers); } -void RenderFillExtrusionLayer::cascade(const CascadeParameters& parameters) { - unevaluated = impl().paint.cascade(parameters, std::move(unevaluated)); +void RenderFillExtrusionLayer::transition(const TransitionParameters& parameters) { + unevaluated = impl().paint.transition(parameters, std::move(unevaluated)); } void RenderFillExtrusionLayer::evaluate(const PropertyEvaluationParameters& parameters) { diff --git a/src/mbgl/renderer/layers/render_fill_extrusion_layer.hpp b/src/mbgl/renderer/layers/render_fill_extrusion_layer.hpp index 8bacd3e93..1a55b5683 100644 --- a/src/mbgl/renderer/layers/render_fill_extrusion_layer.hpp +++ b/src/mbgl/renderer/layers/render_fill_extrusion_layer.hpp @@ -11,7 +11,7 @@ public: RenderFillExtrusionLayer(Immutable); ~RenderFillExtrusionLayer() final = default; - void cascade(const CascadeParameters&) override; + void transition(const TransitionParameters&) override; void evaluate(const PropertyEvaluationParameters&) override; bool hasTransition() const override; diff --git a/src/mbgl/renderer/layers/render_fill_layer.cpp b/src/mbgl/renderer/layers/render_fill_layer.cpp index e030f5b38..a36e1688a 100644 --- a/src/mbgl/renderer/layers/render_fill_layer.cpp +++ b/src/mbgl/renderer/layers/render_fill_layer.cpp @@ -19,8 +19,8 @@ std::unique_ptr RenderFillLayer::createBucket(const BucketParameters& pa return std::make_unique(parameters, layers); } -void RenderFillLayer::cascade(const CascadeParameters& parameters) { - unevaluated = impl().paint.cascade(parameters, std::move(unevaluated)); +void RenderFillLayer::transition(const TransitionParameters& parameters) { + unevaluated = impl().paint.transition(parameters, std::move(unevaluated)); } void RenderFillLayer::evaluate(const PropertyEvaluationParameters& parameters) { diff --git a/src/mbgl/renderer/layers/render_fill_layer.hpp b/src/mbgl/renderer/layers/render_fill_layer.hpp index 238cb06aa..1960fb653 100644 --- a/src/mbgl/renderer/layers/render_fill_layer.hpp +++ b/src/mbgl/renderer/layers/render_fill_layer.hpp @@ -11,7 +11,7 @@ public: RenderFillLayer(Immutable); ~RenderFillLayer() final = default; - void cascade(const CascadeParameters&) override; + void transition(const TransitionParameters&) override; void evaluate(const PropertyEvaluationParameters&) override; bool hasTransition() const override; diff --git a/src/mbgl/renderer/layers/render_line_layer.cpp b/src/mbgl/renderer/layers/render_line_layer.cpp index 29067b6bf..076ee77af 100644 --- a/src/mbgl/renderer/layers/render_line_layer.cpp +++ b/src/mbgl/renderer/layers/render_line_layer.cpp @@ -19,8 +19,8 @@ std::unique_ptr RenderLineLayer::createBucket(const BucketParameters& pa return std::make_unique(parameters, layers, impl().layout); } -void RenderLineLayer::cascade(const CascadeParameters& parameters) { - unevaluated = impl().paint.cascade(parameters, std::move(unevaluated)); +void RenderLineLayer::transition(const TransitionParameters& parameters) { + unevaluated = impl().paint.transition(parameters, std::move(unevaluated)); } void RenderLineLayer::evaluate(const PropertyEvaluationParameters& parameters) { diff --git a/src/mbgl/renderer/layers/render_line_layer.hpp b/src/mbgl/renderer/layers/render_line_layer.hpp index 23a78a367..04ba74553 100644 --- a/src/mbgl/renderer/layers/render_line_layer.hpp +++ b/src/mbgl/renderer/layers/render_line_layer.hpp @@ -11,7 +11,7 @@ public: RenderLineLayer(Immutable); ~RenderLineLayer() final = default; - void cascade(const CascadeParameters&) override; + void transition(const TransitionParameters&) override; void evaluate(const PropertyEvaluationParameters&) override; bool hasTransition() const override; diff --git a/src/mbgl/renderer/layers/render_raster_layer.cpp b/src/mbgl/renderer/layers/render_raster_layer.cpp index b23587689..feb3a4aca 100644 --- a/src/mbgl/renderer/layers/render_raster_layer.cpp +++ b/src/mbgl/renderer/layers/render_raster_layer.cpp @@ -17,8 +17,8 @@ std::unique_ptr RenderRasterLayer::createBucket(const BucketParameters&, return nullptr; } -void RenderRasterLayer::cascade(const CascadeParameters& parameters) { - unevaluated = impl().paint.cascade(parameters, std::move(unevaluated)); +void RenderRasterLayer::transition(const TransitionParameters& parameters) { + unevaluated = impl().paint.transition(parameters, std::move(unevaluated)); } void RenderRasterLayer::evaluate(const PropertyEvaluationParameters& parameters) { diff --git a/src/mbgl/renderer/layers/render_raster_layer.hpp b/src/mbgl/renderer/layers/render_raster_layer.hpp index 8cf62fa0d..eecb0cd02 100644 --- a/src/mbgl/renderer/layers/render_raster_layer.hpp +++ b/src/mbgl/renderer/layers/render_raster_layer.hpp @@ -11,7 +11,7 @@ public: RenderRasterLayer(Immutable); ~RenderRasterLayer() final = default; - void cascade(const CascadeParameters&) override; + void transition(const TransitionParameters&) override; void evaluate(const PropertyEvaluationParameters&) override; bool hasTransition() const override; diff --git a/src/mbgl/renderer/layers/render_symbol_layer.cpp b/src/mbgl/renderer/layers/render_symbol_layer.cpp index af8917a75..0054d9f87 100644 --- a/src/mbgl/renderer/layers/render_symbol_layer.cpp +++ b/src/mbgl/renderer/layers/render_symbol_layer.cpp @@ -33,8 +33,8 @@ std::unique_ptr RenderSymbolLayer::createLayout(const BucketParame glyphDependencies); } -void RenderSymbolLayer::cascade(const CascadeParameters& parameters) { - unevaluated = impl().paint.cascade(parameters, std::move(unevaluated)); +void RenderSymbolLayer::transition(const TransitionParameters& parameters) { + unevaluated = impl().paint.transition(parameters, std::move(unevaluated)); } void RenderSymbolLayer::evaluate(const PropertyEvaluationParameters& parameters) { diff --git a/src/mbgl/renderer/layers/render_symbol_layer.hpp b/src/mbgl/renderer/layers/render_symbol_layer.hpp index 4308761ee..42205496d 100644 --- a/src/mbgl/renderer/layers/render_symbol_layer.hpp +++ b/src/mbgl/renderer/layers/render_symbol_layer.hpp @@ -64,7 +64,7 @@ public: RenderSymbolLayer(Immutable); ~RenderSymbolLayer() final = default; - void cascade(const CascadeParameters&) override; + void transition(const TransitionParameters&) override; void evaluate(const PropertyEvaluationParameters&) override; bool hasTransition() const override; diff --git a/src/mbgl/renderer/render_layer.hpp b/src/mbgl/renderer/render_layer.hpp index e6a2d26fd..263e0039f 100644 --- a/src/mbgl/renderer/render_layer.hpp +++ b/src/mbgl/renderer/render_layer.hpp @@ -12,7 +12,7 @@ namespace mbgl { class Bucket; class BucketParameters; -class CascadeParameters; +class TransitionParameters; class PropertyEvaluationParameters; class RenderLayer { @@ -26,10 +26,10 @@ public: virtual ~RenderLayer() = default; - // Partially evaluate paint properties based on a set of classes. - virtual void cascade(const CascadeParameters&) = 0; + // Begin transitions for any properties that have changed since the last frame. + virtual void transition(const TransitionParameters&) = 0; - // Fully evaluate cascaded paint properties based on a zoom level. + // Fully evaluate possibly-transitioning paint properties based on a zoom level. virtual void evaluate(const PropertyEvaluationParameters&) = 0; // Returns true if any paint properties have active transitions. diff --git a/src/mbgl/renderer/render_light.cpp b/src/mbgl/renderer/render_light.cpp index 23b7ecb9b..f1b5c28d3 100644 --- a/src/mbgl/renderer/render_light.cpp +++ b/src/mbgl/renderer/render_light.cpp @@ -6,8 +6,8 @@ RenderLight::RenderLight(Immutable impl_) : impl(std::move(impl_)) { } -void RenderLight::transition(const CascadeParameters& parameters) { - transitioning = impl->properties.cascade(parameters, std::move(transitioning)); +void RenderLight::transition(const TransitionParameters& parameters) { + transitioning = impl->properties.transition(parameters, std::move(transitioning)); } void RenderLight::evaluate(const PropertyEvaluationParameters& parameters) { diff --git a/src/mbgl/renderer/render_light.hpp b/src/mbgl/renderer/render_light.hpp index ce83616bb..f13f92531 100644 --- a/src/mbgl/renderer/render_light.hpp +++ b/src/mbgl/renderer/render_light.hpp @@ -5,7 +5,7 @@ namespace mbgl { -class CascadeParameters; +class TransitionParameters; class PropertyEvaluationParameters; using TransitioningLight = style::LightProperties::Unevaluated; @@ -15,7 +15,7 @@ class RenderLight { public: RenderLight(Immutable); - void transition(const CascadeParameters&); + void transition(const TransitionParameters&); void evaluate(const PropertyEvaluationParameters&); bool hasTransition() const; diff --git a/src/mbgl/renderer/cascade_parameters.hpp b/src/mbgl/renderer/transition_parameters.hpp similarity index 91% rename from src/mbgl/renderer/cascade_parameters.hpp rename to src/mbgl/renderer/transition_parameters.hpp index 4096cc5a6..573845fa2 100644 --- a/src/mbgl/renderer/cascade_parameters.hpp +++ b/src/mbgl/renderer/transition_parameters.hpp @@ -8,7 +8,7 @@ namespace mbgl { -class CascadeParameters { +class TransitionParameters { public: std::vector classes; TimePoint now; diff --git a/src/mbgl/style/layers/background_layer.cpp b/src/mbgl/style/layers/background_layer.cpp index 1c5b6c3a6..6c9be9652 100644 --- a/src/mbgl/style/layers/background_layer.cpp +++ b/src/mbgl/style/layers/background_layer.cpp @@ -28,7 +28,7 @@ Mutable BackgroundLayer::mutableImpl() const { std::unique_ptr BackgroundLayer::cloneRef(const std::string& id_) const { auto impl_ = mutableImpl(); impl_->id = id_; - impl_->paint = BackgroundPaintProperties::Cascading(); + impl_->paint = BackgroundPaintProperties::Transitionable(); return std::make_unique(std::move(impl_)); } diff --git a/src/mbgl/style/layers/background_layer_impl.hpp b/src/mbgl/style/layers/background_layer_impl.hpp index b50fccf00..4f1466265 100644 --- a/src/mbgl/style/layers/background_layer_impl.hpp +++ b/src/mbgl/style/layers/background_layer_impl.hpp @@ -13,7 +13,7 @@ public: void stringifyLayout(rapidjson::Writer&) const override; - BackgroundPaintProperties::Cascading paint; + BackgroundPaintProperties::Transitionable paint; }; } // namespace style diff --git a/src/mbgl/style/layers/circle_layer.cpp b/src/mbgl/style/layers/circle_layer.cpp index e874f00ff..1f64aa7ca 100644 --- a/src/mbgl/style/layers/circle_layer.cpp +++ b/src/mbgl/style/layers/circle_layer.cpp @@ -28,7 +28,7 @@ Mutable CircleLayer::mutableImpl() const { std::unique_ptr CircleLayer::cloneRef(const std::string& id_) const { auto impl_ = mutableImpl(); impl_->id = id_; - impl_->paint = CirclePaintProperties::Cascading(); + impl_->paint = CirclePaintProperties::Transitionable(); return std::make_unique(std::move(impl_)); } diff --git a/src/mbgl/style/layers/circle_layer_impl.hpp b/src/mbgl/style/layers/circle_layer_impl.hpp index 0263ace62..79ef879ab 100644 --- a/src/mbgl/style/layers/circle_layer_impl.hpp +++ b/src/mbgl/style/layers/circle_layer_impl.hpp @@ -13,7 +13,7 @@ public: void stringifyLayout(rapidjson::Writer&) const override; - CirclePaintProperties::Cascading paint; + CirclePaintProperties::Transitionable paint; }; } // namespace style diff --git a/src/mbgl/style/layers/fill_extrusion_layer.cpp b/src/mbgl/style/layers/fill_extrusion_layer.cpp index cff0c59df..37ae79850 100644 --- a/src/mbgl/style/layers/fill_extrusion_layer.cpp +++ b/src/mbgl/style/layers/fill_extrusion_layer.cpp @@ -28,7 +28,7 @@ Mutable FillExtrusionLayer::mutableImpl() const { std::unique_ptr FillExtrusionLayer::cloneRef(const std::string& id_) const { auto impl_ = mutableImpl(); impl_->id = id_; - impl_->paint = FillExtrusionPaintProperties::Cascading(); + impl_->paint = FillExtrusionPaintProperties::Transitionable(); return std::make_unique(std::move(impl_)); } diff --git a/src/mbgl/style/layers/fill_extrusion_layer_impl.hpp b/src/mbgl/style/layers/fill_extrusion_layer_impl.hpp index 4eadf56ed..73c65469d 100644 --- a/src/mbgl/style/layers/fill_extrusion_layer_impl.hpp +++ b/src/mbgl/style/layers/fill_extrusion_layer_impl.hpp @@ -13,7 +13,7 @@ public: void stringifyLayout(rapidjson::Writer&) const override; - FillExtrusionPaintProperties::Cascading paint; + FillExtrusionPaintProperties::Transitionable paint; }; } // namespace style diff --git a/src/mbgl/style/layers/fill_layer.cpp b/src/mbgl/style/layers/fill_layer.cpp index d38b02774..5e3df1d54 100644 --- a/src/mbgl/style/layers/fill_layer.cpp +++ b/src/mbgl/style/layers/fill_layer.cpp @@ -28,7 +28,7 @@ Mutable FillLayer::mutableImpl() const { std::unique_ptr FillLayer::cloneRef(const std::string& id_) const { auto impl_ = mutableImpl(); impl_->id = id_; - impl_->paint = FillPaintProperties::Cascading(); + impl_->paint = FillPaintProperties::Transitionable(); return std::make_unique(std::move(impl_)); } diff --git a/src/mbgl/style/layers/fill_layer_impl.hpp b/src/mbgl/style/layers/fill_layer_impl.hpp index 1d64fe8fa..72ea8ab35 100644 --- a/src/mbgl/style/layers/fill_layer_impl.hpp +++ b/src/mbgl/style/layers/fill_layer_impl.hpp @@ -13,7 +13,7 @@ public: void stringifyLayout(rapidjson::Writer&) const override; - FillPaintProperties::Cascading paint; + FillPaintProperties::Transitionable paint; }; } // namespace style diff --git a/src/mbgl/style/layers/layer.cpp.ejs b/src/mbgl/style/layers/layer.cpp.ejs index 738165e66..4f747792c 100644 --- a/src/mbgl/style/layers/layer.cpp.ejs +++ b/src/mbgl/style/layers/layer.cpp.ejs @@ -39,7 +39,7 @@ Mutable<<%- camelize(type) %>Layer::Impl> <%- camelize(type) %>Layer::mutableImp std::unique_ptr <%- camelize(type) %>Layer::cloneRef(const std::string& id_) const { auto impl_ = mutableImpl(); impl_->id = id_; - impl_->paint = <%- camelize(type) %>PaintProperties::Cascading(); + impl_->paint = <%- camelize(type) %>PaintProperties::Transitionable(); return std::make_unique<<%- camelize(type) %>Layer>(std::move(impl_)); } diff --git a/src/mbgl/style/layers/line_layer.cpp b/src/mbgl/style/layers/line_layer.cpp index c8684ec6f..286289b28 100644 --- a/src/mbgl/style/layers/line_layer.cpp +++ b/src/mbgl/style/layers/line_layer.cpp @@ -28,7 +28,7 @@ Mutable LineLayer::mutableImpl() const { std::unique_ptr LineLayer::cloneRef(const std::string& id_) const { auto impl_ = mutableImpl(); impl_->id = id_; - impl_->paint = LinePaintProperties::Cascading(); + impl_->paint = LinePaintProperties::Transitionable(); return std::make_unique(std::move(impl_)); } diff --git a/src/mbgl/style/layers/line_layer_impl.hpp b/src/mbgl/style/layers/line_layer_impl.hpp index 2eab19a61..333821dc1 100644 --- a/src/mbgl/style/layers/line_layer_impl.hpp +++ b/src/mbgl/style/layers/line_layer_impl.hpp @@ -14,7 +14,7 @@ public: void stringifyLayout(rapidjson::Writer&) const override; LineLayoutProperties::Unevaluated layout; - LinePaintProperties::Cascading paint; + LinePaintProperties::Transitionable paint; }; } // namespace style diff --git a/src/mbgl/style/layers/raster_layer.cpp b/src/mbgl/style/layers/raster_layer.cpp index a17e34dd8..fc28672ab 100644 --- a/src/mbgl/style/layers/raster_layer.cpp +++ b/src/mbgl/style/layers/raster_layer.cpp @@ -28,7 +28,7 @@ Mutable RasterLayer::mutableImpl() const { std::unique_ptr RasterLayer::cloneRef(const std::string& id_) const { auto impl_ = mutableImpl(); impl_->id = id_; - impl_->paint = RasterPaintProperties::Cascading(); + impl_->paint = RasterPaintProperties::Transitionable(); return std::make_unique(std::move(impl_)); } diff --git a/src/mbgl/style/layers/raster_layer_impl.hpp b/src/mbgl/style/layers/raster_layer_impl.hpp index 13e5b3f4c..2178fd69d 100644 --- a/src/mbgl/style/layers/raster_layer_impl.hpp +++ b/src/mbgl/style/layers/raster_layer_impl.hpp @@ -13,7 +13,7 @@ public: void stringifyLayout(rapidjson::Writer&) const override; - RasterPaintProperties::Cascading paint; + RasterPaintProperties::Transitionable paint; }; } // namespace style diff --git a/src/mbgl/style/layers/symbol_layer.cpp b/src/mbgl/style/layers/symbol_layer.cpp index 4a3ad2ffc..d21014dda 100644 --- a/src/mbgl/style/layers/symbol_layer.cpp +++ b/src/mbgl/style/layers/symbol_layer.cpp @@ -28,7 +28,7 @@ Mutable SymbolLayer::mutableImpl() const { std::unique_ptr SymbolLayer::cloneRef(const std::string& id_) const { auto impl_ = mutableImpl(); impl_->id = id_; - impl_->paint = SymbolPaintProperties::Cascading(); + impl_->paint = SymbolPaintProperties::Transitionable(); return std::make_unique(std::move(impl_)); } diff --git a/src/mbgl/style/layers/symbol_layer_impl.hpp b/src/mbgl/style/layers/symbol_layer_impl.hpp index 28760e1f7..7b9415436 100644 --- a/src/mbgl/style/layers/symbol_layer_impl.hpp +++ b/src/mbgl/style/layers/symbol_layer_impl.hpp @@ -14,7 +14,7 @@ public: void stringifyLayout(rapidjson::Writer&) const override; SymbolLayoutProperties::Unevaluated layout; - SymbolPaintProperties::Cascading paint; + SymbolPaintProperties::Transitionable paint; }; } // namespace style diff --git a/src/mbgl/style/layout_property.hpp b/src/mbgl/style/layout_property.hpp index 82a19e6a8..8c59295ad 100644 --- a/src/mbgl/style/layout_property.hpp +++ b/src/mbgl/style/layout_property.hpp @@ -11,7 +11,7 @@ namespace style { template class LayoutProperty { public: - using CascadingType = std::nullptr_t; + using TransitionableType = std::nullptr_t; using UnevaluatedType = PropertyValue; using EvaluatorType = PropertyEvaluator; using PossiblyEvaluatedType = T; @@ -22,7 +22,7 @@ public: template class DataDrivenLayoutProperty { public: - using CascadingType = std::nullptr_t; + using TransitionableType = std::nullptr_t; using UnevaluatedType = DataDrivenPropertyValue; using EvaluatorType = DataDrivenPropertyEvaluator; using PossiblyEvaluatedType = PossiblyEvaluatedPropertyValue; diff --git a/src/mbgl/style/light.cpp b/src/mbgl/style/light.cpp index 651a323da..352dc4d94 100644 --- a/src/mbgl/style/light.cpp +++ b/src/mbgl/style/light.cpp @@ -39,15 +39,15 @@ void Light::setAnchor(PropertyValue property) { observer->onLightChanged(*this); } -void Light::setAnchorTransition(const TransitionOptions& transition) { +void Light::setAnchorTransition(const TransitionOptions& options) { auto impl_ = mutableImpl(); - impl_->properties.template get().transition = transition; + impl_->properties.template get().options = options; impl = std::move(impl_); observer->onLightChanged(*this); } TransitionOptions Light::getAnchorTransition() const { - return impl->properties.template get().transition; + return impl->properties.template get().options; } Position Light::getDefaultPosition() { @@ -65,15 +65,15 @@ void Light::setPosition(PropertyValue property) { observer->onLightChanged(*this); } -void Light::setPositionTransition(const TransitionOptions& transition) { +void Light::setPositionTransition(const TransitionOptions& options) { auto impl_ = mutableImpl(); - impl_->properties.template get().transition = transition; + impl_->properties.template get().options = options; impl = std::move(impl_); observer->onLightChanged(*this); } TransitionOptions Light::getPositionTransition() const { - return impl->properties.template get().transition; + return impl->properties.template get().options; } Color Light::getDefaultColor() { @@ -91,15 +91,15 @@ void Light::setColor(PropertyValue property) { observer->onLightChanged(*this); } -void Light::setColorTransition(const TransitionOptions& transition) { +void Light::setColorTransition(const TransitionOptions& options) { auto impl_ = mutableImpl(); - impl_->properties.template get().transition = transition; + impl_->properties.template get().options = options; impl = std::move(impl_); observer->onLightChanged(*this); } TransitionOptions Light::getColorTransition() const { - return impl->properties.template get().transition; + return impl->properties.template get().options; } float Light::getDefaultIntensity() { @@ -117,15 +117,15 @@ void Light::setIntensity(PropertyValue property) { observer->onLightChanged(*this); } -void Light::setIntensityTransition(const TransitionOptions& transition) { +void Light::setIntensityTransition(const TransitionOptions& options) { auto impl_ = mutableImpl(); - impl_->properties.template get().transition = transition; + impl_->properties.template get().options = options; impl = std::move(impl_); observer->onLightChanged(*this); } TransitionOptions Light::getIntensityTransition() const { - return impl->properties.template get().transition; + return impl->properties.template get().options; } diff --git a/src/mbgl/style/light.cpp.ejs b/src/mbgl/style/light.cpp.ejs index e933e40b9..45241c60f 100644 --- a/src/mbgl/style/light.cpp.ejs +++ b/src/mbgl/style/light.cpp.ejs @@ -43,15 +43,15 @@ void Light::set<%- camelize(property.name) %>(<%- propertyValueType(property) %> observer->onLightChanged(*this); } -void Light::set<%- camelize(property.name) %>Transition(const TransitionOptions& transition) { +void Light::set<%- camelize(property.name) %>Transition(const TransitionOptions& options) { auto impl_ = mutableImpl(); - impl_->properties.template get>().transition = transition; + impl_->properties.template get>().options = options; impl = std::move(impl_); observer->onLightChanged(*this); } TransitionOptions Light::get<%- camelize(property.name) %>Transition() const { - return impl->properties.template get>().transition; + return impl->properties.template get>().options; } <% } -%> diff --git a/src/mbgl/style/light_impl.hpp b/src/mbgl/style/light_impl.hpp index 7cf160f43..f094c9d46 100644 --- a/src/mbgl/style/light_impl.hpp +++ b/src/mbgl/style/light_impl.hpp @@ -15,7 +15,7 @@ namespace style { template class LightProperty { public: - using CascadingType = Transitionable>; + using TransitionableType = Transitionable>; using UnevaluatedType = Transitioning>; using EvaluatorType = PropertyEvaluator; using PossiblyEvaluatedType = T; @@ -52,7 +52,7 @@ using LightProperties = Properties class PaintProperty { public: - using CascadingType = Cascading>; + using TransitionableType = Cascading>; using UnevaluatedType = Transitioning>; using EvaluatorType = PropertyEvaluator; using PossiblyEvaluatedType = T; @@ -26,7 +26,7 @@ public: template class DataDrivenPaintProperty { public: - using CascadingType = Cascading>; + using TransitionableType = Cascading>; using UnevaluatedType = Transitioning>; using EvaluatorType = DataDrivenPropertyEvaluator; using PossiblyEvaluatedType = PossiblyEvaluatedPropertyValue; @@ -39,7 +39,7 @@ public: template class CrossFadedPaintProperty { public: - using CascadingType = Cascading>; + using TransitionableType = Cascading>; using UnevaluatedType = Transitioning>; using EvaluatorType = CrossFadedPropertyEvaluator; using PossiblyEvaluatedType = Faded; diff --git a/src/mbgl/style/properties.hpp b/src/mbgl/style/properties.hpp index c808554c9..cd69ffb9b 100644 --- a/src/mbgl/style/properties.hpp +++ b/src/mbgl/style/properties.hpp @@ -2,10 +2,10 @@ #include #include -#include +#include #include #include -#include +#include #include #include @@ -82,15 +82,16 @@ template class Transitionable { public: Value value; - TransitionOptions transition; + TransitionOptions options; - Transitioning cascade(const CascadeParameters& params, Transitioning prior) const { + Transitioning transition(const TransitionParameters& params, Transitioning prior) const { return Transitioning(value, std::move(prior), - transition.reverseMerge(params.transition), + options.reverseMerge(params.transition), params.now); } }; + template class Cascading { public: @@ -118,7 +119,7 @@ public: transitions[klass ? ClassDictionary::Get().lookup(*klass) : ClassID::Default] = transition; } - Transitioning cascade(const CascadeParameters& params, Transitioning prior) const { + Transitioning transition(const TransitionParameters& params, Transitioning prior) const { TransitionOptions transition; Value value; @@ -168,7 +169,7 @@ public: */ using PropertyTypes = TypeList; - using CascadingTypes = TypeList; + using TransitionableTypes = TypeList; using UnevaluatedTypes = TypeList; using PossiblyEvaluatedTypes = TypeList; using EvaluatedTypes = TypeList; @@ -251,14 +252,14 @@ public: } }; - class Cascading : public Tuple { + class Transitionable : public Tuple { public: - using Tuple::Tuple; + using Tuple::Tuple; - Unevaluated cascade(const CascadeParameters& parameters, Unevaluated&& prior) const { + Unevaluated transition(const TransitionParameters& parameters, Unevaluated&& prior) const { return Unevaluated { this->template get() - .cascade(parameters, std::move(prior.template get()))... + .transition(parameters, std::move(prior.template get()))... }; } }; diff --git a/src/mbgl/style/style.cpp b/src/mbgl/style/style.cpp index 7a76d289c..962ba0f39 100644 --- a/src/mbgl/style/style.cpp +++ b/src/mbgl/style/style.cpp @@ -22,7 +22,7 @@ #include #include #include -#include +#include #include #include #include @@ -341,7 +341,7 @@ void Style::update(const UpdateParameters& parameters) { } classIDs.push_back(ClassID::Default); - const CascadeParameters cascadeParameters { + const TransitionParameters transitionParameters { classIDs, parameters.timePoint, parameters.mode == MapMode::Continuous ? transitionOptions : TransitionOptions() @@ -367,7 +367,7 @@ void Style::update(const UpdateParameters& parameters) { if (lightChanged) { renderLight.impl = light->impl; - renderLight.transition(cascadeParameters); + renderLight.transition(transitionParameters); } if (lightChanged || zoomChanged || renderLight.hasTransition()) { @@ -433,7 +433,7 @@ void Style::update(const UpdateParameters& parameters) { const bool layerChanged = layerDiff.changed.count(entry.first); if (classesChanged || layerAdded || layerChanged) { - layer.cascade(cascadeParameters); + layer.transition(transitionParameters); } if (classesChanged || layerAdded || layerChanged || zoomChanged || layer.hasTransition()) { diff --git a/src/mbgl/tile/geometry_tile_worker.cpp b/src/mbgl/tile/geometry_tile_worker.cpp index 19f953288..1dfc739ad 100644 --- a/src/mbgl/tile/geometry_tile_worker.cpp +++ b/src/mbgl/tile/geometry_tile_worker.cpp @@ -248,7 +248,7 @@ static std::vector> toRenderLayers(const std::vecto for (auto& layer : layers) { renderLayers.push_back(RenderLayer::create(layer)); - renderLayers.back()->cascade(CascadeParameters { + renderLayers.back()->transition(TransitionParameters { { ClassID::Default }, Clock::time_point::max(), TransitionOptions()