diff --git a/test/fixtures/fixture_log_observer.cpp b/test/fixtures/fixture_log_observer.cpp index b3b8e56fd..1d3517ac6 100644 --- a/test/fixtures/fixture_log_observer.cpp +++ b/test/fixtures/fixture_log_observer.cpp @@ -8,14 +8,11 @@ FixtureLogObserver::LogMessage::LogMessage(EventSeverity severity_, Event event_ : severity(severity_), event(event_), code(code_), msg(msg_) { } -FixtureLogObserver::LogMessage::LogMessage() : severity(), event(), code(), msg() { -} - bool FixtureLogObserver::LogMessage::operator==(const LogMessage &rhs) const { - return (!severity || !rhs.severity || severity.get() == rhs.severity.get()) && - (!event || !rhs.event || event.get() == rhs.event.get()) && - (!code || !rhs.code || code.get() == rhs.code.get()) && - (!msg || !rhs.msg || msg.get() == rhs.msg.get()); + return severity == rhs.severity && + event == rhs.event && + code == rhs.code && + msg == rhs.msg; } FixtureLogObserver::~FixtureLogObserver() { @@ -60,11 +57,9 @@ std::vector FixtureLogObserver::unchecked() cons } ::std::ostream &operator<<(::std::ostream &os, const FixtureLogObserver::LogMessage &message) { - os << "[\"" << message.severity.get() << "\", \"" << message.event.get() << "\""; - if (message.code) - os << ", " << message.code.get(); - if (message.msg) - os << ", \"" << message.msg.get() << "\""; + os << "[\"" << message.severity << "\", \"" << message.event << "\""; + os << ", " << message.code; + os << ", \"" << message.msg << "\""; return os << "]" << std::endl; } diff --git a/test/fixtures/fixture_log_observer.hpp b/test/fixtures/fixture_log_observer.hpp index 7e419a617..cadff84d3 100644 --- a/test/fixtures/fixture_log_observer.hpp +++ b/test/fixtures/fixture_log_observer.hpp @@ -2,7 +2,6 @@ #define MBGL_TEST_FIXTURE_LOG_OBSERVER #include -#include #include #include @@ -14,14 +13,13 @@ class FixtureLogObserver : public Log::Observer { public: struct LogMessage { LogMessage(EventSeverity severity_, Event event_, int64_t code_, const std::string &msg_); - LogMessage(); bool operator==(const LogMessage &rhs) const; - const mapbox::util::optional severity; - const mapbox::util::optional event; - const mapbox::util::optional code; - const mapbox::util::optional msg; + const EventSeverity severity; + const Event event; + const int64_t code; + const std::string msg; mutable bool checked = false; }; diff --git a/test/style/resource_loading.cpp b/test/style/resource_loading.cpp index c37e17d71..700a42c42 100644 --- a/test/style/resource_loading.cpp +++ b/test/style/resource_loading.cpp @@ -124,7 +124,7 @@ void runTestCase(MockFileSource::Type type, std::vector logMessages = log->unchecked(); for (auto& logMessage : logMessages) { - if (std::regex_match(*logMessage.msg, std::regex(message))) { + if (std::regex_match(logMessage.msg, std::regex(message))) { match++; } }