tei/MapLibreParticleLab
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[core] Fix readability-avoid-const-params-in-decls errors in header files

Browse Source 
As reported by clang-tidy-8.
This commit is contained in:
Thiago Marcos P. Santos
2020-03-27 18:30:35 +02:00
parent 2eebd7170a
commit dffe00feea
49 changed files with 260 additions and 217 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/mbgl/programs/fill_extrusion_program.hpp
View File

@@ -85,8 +85,8 @@ public:
};
}
static LayoutUniformValues
layoutUniformValues(mat4, const TransformState&, const float opacity, const EvaluatedLight&, const float verticalGradient);
static LayoutUniformValues layoutUniformValues(
mat4, const TransformState&, float opacity, const EvaluatedLight&, float verticalGradient);
};
class FillExtrusionPatternProgram : public Program<
@@ -106,11 +106,11 @@ public:
const CrossfadeParameters&,
const UnwrappedTileID&,
const TransformState&,
const float opacity,
const float heightFactor,
const float pixelRatio,
float opacity,
float heightFactor,
float pixelRatio,
const EvaluatedLight&,
const float verticalGradient);
float verticalGradient);
};
using FillExtrusionLayoutVertex = FillExtrusionProgram::LayoutVertex;

2
src/mbgl/programs/fill_program.hpp
View File

@@ -72,7 +72,7 @@ public:
const CrossfadeParameters& crossfade,
const UnwrappedTileID&,
const TransformState&,
const float pixelRatio);
float pixelRatio);
};
class FillOutlineProgram : public Program<

37
src/mbgl/programs/line_program.hpp
View File

@@ -88,12 +88,11 @@ public:
*/
static const int8_t extrudeScale = 63;
static LayoutUniformValues
layoutUniformValues(const style::LinePaintProperties::PossiblyEvaluated&,
const RenderTile&,
const TransformState&,
const std::array<float, 2>& pixelsToGLUnits,
const float pixelRatio);
static LayoutUniformValues layoutUniformValues(const style::LinePaintProperties::PossiblyEvaluated&,
const RenderTile&,
const TransformState&,
const std::array<float, 2>& pixelsToGLUnits,
float pixelRatio);
};
class LinePatternProgram : public Program<
@@ -115,14 +114,13 @@ class LinePatternProgram : public Program<
public:
using Program::Program;
static LayoutUniformValues
layoutUniformValues(const style::LinePaintProperties::PossiblyEvaluated&,
const RenderTile&,
const TransformState&,
const std::array<float, 2>& pixelsToGLUnits,
const float pixelRatio,
Size atlasSize,
const CrossfadeParameters& crossfade);
static LayoutUniformValues layoutUniformValues(const style::LinePaintProperties::PossiblyEvaluated&,
const RenderTile&,
const TransformState&,
const std::array<float, 2>& pixelsToGLUnits,
float pixelRatio,
Size atlasSize,
const CrossfadeParameters& crossfade);
};
class LineSDFProgram : public Program<
@@ -175,12 +173,11 @@ class LineGradientProgram : public Program<
public:
using Program::Program;
static LayoutUniformValues
layoutUniformValues(const style::LinePaintProperties::PossiblyEvaluated&,
const RenderTile&,
const TransformState&,
const std::array<float, 2>& pixelsToGLUnits,
const float pixelRatio);
static LayoutUniformValues layoutUniformValues(const style::LinePaintProperties::PossiblyEvaluated&,
const RenderTile&,
const TransformState&,
const std::array<float, 2>& pixelsToGLUnits,
float pixelRatio);
};
using LineLayoutVertex = LineProgram::LayoutVertex;

34
src/mbgl/programs/symbol_program.hpp
View File

@@ -73,9 +73,9 @@ public:
uniforms::size>;
using UniformValues = gfx::UniformValues<UniformList>;
static std::unique_ptr<SymbolSizeBinder> create(const float tileZoom,
static std::unique_ptr<SymbolSizeBinder> create(float tileZoom,
const style::PropertyValue<float>& sizeProperty,
const float defaultValue);
float defaultValue);
virtual Range<float> getVertexSizeData(const GeometryTileFeature& feature) = 0;
virtual ZoomEvaluatedSize evaluateForZoom(float currentZoom) const = 0;
@@ -406,15 +406,15 @@ class SymbolIconProgram : public SymbolProgram<
public:
using SymbolProgram::SymbolProgram;
static LayoutUniformValues layoutUniformValues(const bool isText,
const bool hasVariablePacement,
static LayoutUniformValues layoutUniformValues(bool isText,
bool hasVariablePacement,
const style::SymbolPropertyValues&,
const Size& texsize,
const std::array<float, 2>& pixelsToGLUnits,
const bool alongLine,
bool alongLine,
const RenderTile&,
const TransformState&,
const float symbolFadeChange);
float symbolFadeChange);
};
enum class SymbolSDFPart {
@@ -457,17 +457,17 @@ public:
using BaseProgram::BaseProgram;
static LayoutUniformValues layoutUniformValues(const bool isText,
const bool hasVariablePacement,
static LayoutUniformValues layoutUniformValues(bool isText,
bool hasVariablePacement,
const style::SymbolPropertyValues&,
const Size& texsize,
const std::array<float, 2>& pixelsToGLUnits,
const float pixelRatio,
const bool alongLine,
float pixelRatio,
bool alongLine,
const RenderTile&,
const TransformState&,
const float SymbolFadeChange,
const SymbolSDFPart);
float SymbolFadeChange,
SymbolSDFPart);
};
using SymbolTextAndIconProgramUniforms = TypeList<uniforms::texsize_icon>;
@@ -491,17 +491,17 @@ public:
using BaseProgram::BaseProgram;
static LayoutUniformValues layoutUniformValues(const bool hasVariablePacement,
static LayoutUniformValues layoutUniformValues(bool hasVariablePacement,
const style::SymbolPropertyValues&,
const Size& texsize,
const Size& texsize_icon,
const std::array<float, 2>& pixelsToGLUnits,
const float pixelRatio,
const bool alongLine,
float pixelRatio,
bool alongLine,
const RenderTile&,
const TransformState&,
const float SymbolFadeChange,
const SymbolSDFPart);
float SymbolFadeChange,
SymbolSDFPart);
};
class SymbolSDFIconProgram : public SymbolSDFProgram<SymbolSDFIconProgram, style::IconPaintProperties> {