tei/MapLibreParticleLab
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[core] Fix readability-avoid-const-params-in-decls errors in header files

Browse Source 
As reported by clang-tidy-8.
This commit is contained in:
Thiago Marcos P. Santos
2020-03-27 18:30:35 +02:00
parent 2eebd7170a
commit dffe00feea
49 changed files with 260 additions and 217 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/mbgl/storage/database_file_source.hpp
View File

@@ -152,7 +152,7 @@ public:
/*
* Update an offline region metadata in the database.
*/
virtual void updateOfflineMetadata(const int64_t regionID,
virtual void updateOfflineMetadata(int64_t regionID,
const OfflineRegionMetadata& metadata,
std::function<void(expected<OfflineRegionMetadata, std::exception_ptr>)>);

3
include/mbgl/style/expression/get_covering_stops.hpp
View File

@@ -10,8 +10,7 @@ namespace style {
namespace expression {
// Return the smallest range of stops that covers the interval [lower, upper]
Range<float> getCoveringStops(const std::map<double, std::unique_ptr<Expression>>& stops,
const double lower, const double upper);
Range<float> getCoveringStops(const std::map<double, std::unique_ptr<Expression>>& stops, double lower, double upper);
} // namespace expression
} // namespace style

2
include/mbgl/style/expression/step.hpp
View File

@@ -24,7 +24,7 @@ public:
void eachStop(const std::function<void(double, const Expression&)>& visit) const;
const std::unique_ptr<Expression>& getInput() const { return input; }
Range<float> getCoveringStops(const double lower, const double upper) const;
Range<float> getCoveringStops(double lower, double upper) const;
bool operator==(const Expression& e) const override;

2
include/mbgl/style/expression/value.hpp
View File

@@ -93,7 +93,7 @@ struct ValueConverter<mbgl::Value> {
template <>
struct ValueConverter<float> {
static type::Type expressionType() { return type::Number; }
static Value toExpressionValue(const float value);
static Value toExpressionValue(float value);
static optional<float> fromExpressionValue(const Value& value);
};

4
include/mbgl/style/property_expression.hpp
View File

@@ -17,8 +17,8 @@ public:
bool isZoomConstant() const noexcept;
bool isFeatureConstant() const noexcept;
bool isRuntimeConstant() const noexcept;
float interpolationFactor(const Range<float>&, const float) const noexcept;
Range<float> getCoveringStops(const float, const float) const noexcept;
float interpolationFactor(const Range<float>&, float) const noexcept;
Range<float> getCoveringStops(float, float) const noexcept;
const expression::Expression& getExpression() const noexcept;
// Can be used for aggregating property expressions from multiple

6
include/mbgl/style/sources/geojson_source.hpp
View File

@@ -49,10 +49,8 @@ public:
virtual void getTile(const CanonicalTileID&, const std::function<void(TileFeatures)>&) = 0;
// SuperclusterData
virtual Features getChildren(const std::uint32_t) = 0;
virtual Features getLeaves(const std::uint32_t,
const std::uint32_t limit = 10u,
const std::uint32_t offset = 0u) = 0;
virtual Features getChildren(std::uint32_t) = 0;
virtual Features getLeaves(std::uint32_t, std::uint32_t limit = 10u, std::uint32_t offset = 0u) = 0;
virtual std::uint8_t getClusterExpansionZoom(std::uint32_t) = 0;
virtual std::shared_ptr<Scheduler> getScheduler() { return nullptr; }

2
include/mbgl/style/sources/image_source.hpp
View File

@@ -12,7 +12,7 @@ namespace style {
class ImageSource final : public Source {
public:
ImageSource(std::string id, const std::array<LatLng, 4>);
ImageSource(std::string id, std::array<LatLng, 4>);
~ImageSource() override;
optional<std::string> getURL() const;

2
include/mbgl/util/chrono.hpp
View File

@@ -30,7 +30,7 @@ std::string iso8601(Timestamp);
Timestamp parseTimestamp(const char *);
Timestamp parseTimestamp(const int32_t timestamp);
Timestamp parseTimestamp(int32_t timestamp);
// C++17 polyfill
template <class Rep, class Period, class = std::enable_if_t<

2
include/mbgl/util/geo.hpp
View File

@@ -161,7 +161,7 @@ public:
bool contains(const LatLng& point, LatLng::WrapMode wrap = LatLng::Unwrapped) const;
bool contains(const LatLngBounds& area, LatLng::WrapMode wrap = LatLng::Unwrapped) const;
bool intersects(const LatLngBounds area, LatLng::WrapMode wrap = LatLng::Unwrapped) const;
bool intersects(LatLngBounds area, LatLng::WrapMode wrap = LatLng::Unwrapped) const;
private:
LatLng sw;