diff --git a/.github/actions/aws-device-farm-run/action.yml b/.github/actions/aws-device-farm-run/action.yml index 76c1ef87b..755d4f288 100644 --- a/.github/actions/aws-device-farm-run/action.yml +++ b/.github/actions/aws-device-farm-run/action.yml @@ -40,6 +40,9 @@ inputs: AWS_DEVICE_FARM_DEVICE_POOL_ARN: description: "AWS_DEVICE_FARM_DEVICE_POOL_ARN" required: true + testSpecArn: + description: "ARN of test spec" + required: false runs: using: "composite" steps: @@ -111,7 +114,7 @@ runs: --name "MapLibre Native ${{ matrix.test.name }}" \ --app-arn ${{ env.app_arn }} \ --device-pool-arn ${{ inputs.AWS_DEVICE_FARM_DEVICE_POOL_ARN }} \ - --test type=${{ inputs.testType }},testPackageArn=${{ env.test_package_arn }}${{ inputs.testFilter && ',filter=' }}${{ inputs.testFilter }} \ + --test type=${{ inputs.testType }},testPackageArn=${{ env.test_package_arn }}${{ inputs.testFilter && ',filter=' }}${{ inputs.testFilter }}${{ inputs.testSpecArn && ',testSpecArn=' }}${{ inputs.testSpecArn }} \ ${{ inputs.externalData && '--configuration extraDataPackageArn=' }}${{ inputs.externalData }} \ --output text --query "run.arn")" diff --git a/.github/workflows/android-device-test.yml b/.github/workflows/android-device-test.yml index bf2eaf8e9..1d7c063ec 100644 --- a/.github/workflows/android-device-test.yml +++ b/.github/workflows/android-device-test.yml @@ -33,7 +33,10 @@ jobs: # aws devicefarm get-upload externalData: "arn:aws:devicefarm:us-west-2:373521797162:upload:20687d72-0e46-403e-8f03-0941850665bc/c27174c2-63f4-4cdb-9af9-68957d75ebed", # top devices, query with `aws list-device-pools --arn ` - devicePool: "arn:aws:devicefarm:us-west-2::devicepool:082d10e5-d7d7-48a5-ba5c-b33d66efa1f5" + devicePool: "arn:aws:devicefarm:us-west-2::devicepool:082d10e5-d7d7-48a5-ba5c-b33d66efa1f5", + # benchmark-android.yaml + # see https://github.com/maplibre/ci-runners/tree/main/aws-device-farm/custom-test-envs + "testSpecArn": "arn:aws:devicefarm:us-west-2:373521797162:upload:20687d72-0e46-403e-8f03-0941850665bc/14862afb-cf88-44aa-9f1e-5131cbb22f01" } ] runs-on: ubuntu-latest diff --git a/platform/android/MapboxGLAndroidSDKTestApp/src/main/AndroidManifest.xml b/platform/android/MapboxGLAndroidSDKTestApp/src/main/AndroidManifest.xml index ee0bffdca..54132f347 100644 --- a/platform/android/MapboxGLAndroidSDKTestApp/src/main/AndroidManifest.xml +++ b/platform/android/MapboxGLAndroidSDKTestApp/src/main/AndroidManifest.xml @@ -2,8 +2,7 @@ - - + = Build.VERSION_CODES.R && Environment.isExternalStorageManager() && jsonFile.isFile) { val jsonFileContents = jsonFile.readText() val jsonElement = Json.parseToJsonElement(jsonFileContents) val styleNames = jsonElement.jsonObject["styleNames"]?.jsonArray?.map { it.jsonPrimitive.content }